summaryrefslogtreecommitdiff
path: root/crates/tor-rpcbase/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'rpc-references-cleanup' into 'main'Nick Mathewson2025-01-282-16/+1
|\ | | | | | | | | rpc: Move support for weak references behind an experimental feature See merge request tpo/core/arti!2742
| * rpc: Move support for weak references behind an experimental featureNick Mathewson2025-01-272-16/+1
| | | | | | | | | | We haven't decided how these should work (see #868), so having them present by default is a bad idea.
* | Merge branch 'strongrefs_are_not_deduped' into 'main'Nick Mathewson2025-01-281-6/+2
|\ \ | | | | | | | | | | | | rpc: Clean up comments surrounding strong references See merge request tpo/core/arti!2741
| * | rpc: Clean up comments surrounding strong referencesNick Mathewson2025-01-271-6/+2
| |/ | | | | | | They used to be deduplicated, but they haven't been for a while.
* | rpcbase: Enforce validity on error datum keywords.Nick Mathewson2025-01-271-3/+10
| |
* | rpcbase: Make recognized namespace list optional.Nick Mathewson2025-01-272-8/+11
| |
* | rpcbase: Move is_valid_rpc_identifier to crate root.Nick Mathewson2025-01-272-91/+89
| |
* | rpc: Rename InvalidMethodName to InvalidRpcIdentifier.Nick Mathewson2025-01-272-14/+16
| | | | | | | | We're about to use this error type for other things too.
* | Remove RPC TODO about bypass_method_dispatch method.Nick Mathewson2025-01-271-6/+1
|/ | | | | | There was formally a redundant method of this name, which could get out-of-sync with invoke_without_dispatch. But now that method is gone, and this TODO is wrong.
* rpc: Make cancel requests uncancellable.Nick Mathewson2025-01-221-1/+18
| | | | | | | | | The current cancel code is prone to deadlock, so the easiest way to solve it appears to be making cancel requests themselves uncancellable. I've included a test to verify the behavior; previously, this test caused a deadlock.
* clippy: deny `mod_module_files`Steven Engler2025-01-061-0/+1
| | | | | | Denies 'mod.rs' files for consistency. https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
* add_warnings, *: Allow clippy::needless_lifetimesNick Mathewson2024-12-031-0/+1
| | | | | | | | In 1.83, this warning triggers on many of our crates. We're thinking of fixing them all, but for now, we're going to disable the warning. This is part of #1765.
* rpc: Simplify method-dispatch-bypass logic a bitNick Mathewson2024-10-233-25/+39
| | | | | | | | | | | | | | | This commit removes the separate function for asking whether to bypass the dispatch code. Instead, it gives the "invoke with bypass" function an error to return when no dispatch is warranted, and moves the whole responsibility for method dispatch or non-dispatch back into tor-rpcbase. I had to add an ObjectId argument to `invoke_rpc_method` to make this work, but that's probably a good thing. Additionally, this commit tweaks the derive-deftly macro to prevent you from asking for dispatch bypass on special methods, where it isn't implemented (and doesn't really make sense).
* rpc: do not attempt to dispatch methods with bypassed dispatch.Nick Mathewson2024-10-231-0/+12
|
* rpc: Add a mechanism for method that bypass regular dispatchNick Mathewson2024-10-231-2/+34
| | | | | | | I'm about to use this for rpc:release, which is special because it doesn't actually look at the type of the object that it's invoked on. Later it might be useful for manipulating weakrefs, cloning referenes, detecting reference equality, etc.
* rpc: Include "data" field in error.Nick Mathewson2024-10-171-3/+43
| | | | | | | | In older versions of the rpc spec, this field held a serialized version of the Arti error object. That's no longer the design: now it provides a way for specific errors to include extra, specified, machine-readable data. For more information see the section "Errors" in rpc-meta-draft.md
* Remove Rpc* variants from tor_error::ErrorKindNick Mathewson2024-10-173-31/+29
| | | | | | | | | | | | | These are not regular ErrorKinds, since they can never occur in an error that's meant to be returned from a Rust API like `arti-client`. Instead, they only exist for errors returned from RpcError. (I can't find the place where we discussed this previously, but the rationale is that if an ErrorKind never makes sense in response to something that the user does from Rust, we should never have that be an ErrorKind. The fact that the removed kinds do not actually appear outside the RPC system suggests that this is reasonable.)
* Tweak some RpcErrorKind member names.Nick Mathewson2024-10-171-4/+4
| | | | In some cases, the tor_error::ErrorKind names were nicer.
* rpc: Create a constructor for RpcError.Nick Mathewson2024-10-171-0/+14
| | | | | | | We'll use this to make RpcErrors directly, without having to go through an error that implements HasKind. Later, we'll add the ability to set the `data` fields on an RpcError.
* rpc: Allow the "RpcError.kinds" to be an RpcErrorKind.Nick Mathewson2024-10-171-10/+33
| | | | | This change will let us start removing the not-entirely-logical `Rpc.*` variants from tor_error::ErrorKind.
* rpc: Make RpcErrorKind public.Nick Mathewson2024-10-172-2/+3
|
* rpc: Rename RpcCode to RpcErrorKind.Nick Mathewson2024-10-171-6/+13
| | | | This is about to be a public competitor with tor_error::ErrorKind.
* rpc: Use an alias for RpcCode.Nick Mathewson2024-10-171-9/+10
|
* rpc: Remove prefix from RpcCode members.Nick Mathewson2024-10-171-20/+19
|
* tor-{error,rpcbase}: Add new RPC error codes from spec.Nick Mathewson2024-10-071-0/+6
| | | | | | These, like the other RPC-only error kinds, probably don't belong in `tor-error`. But for now, that's where they all are, and moving them is out of scope for this branch. See #1668.
* Merge branch 'rename_singleton_id' into 'main'Jim Newsome2024-09-251-1/+1
|\ | | | | | | | | | | | | rpc: Rename SingletonId to SingleIdResponse Closes #1585 See merge request tpo/core/arti!2448
| * rpc: Rename SingletonId to SingleIdResponseNick Mathewson2024-09-241-1/+1
| | | | | | | | | | | | | | | | | | | | Calling it "singleton" might have suggested that it was using the [singleton pattern](https://en.wikipedia.org/wiki/Singleton_pattern), which it isn't. (Renaming done with rust-analyzer and double-checked with `git grep`.) Closes #1585.
* | rpc: Expose a delegation table in arti:x_list_all_rpc_methodsNick Mathewson2024-09-244-1/+69
| | | | | | | | Closes #1624.
* | rpc: add mandatory delegate-type attribute to Object templateNick Mathewson2024-09-242-3/+12
|/ | | | | | | When specifying a delegation, the template user must also say what type they're delegating to. We're going to use this to document and expose delegations.
* Fix typosDimitris Apostolou2024-09-031-2/+2
|
* rpcbase: Implement RPC method delegation support.Nick Mathewson2024-08-143-32/+138
| | | | | | | | (Couldn't use Deref here, since we needed to get an Arc.) Only one delegation target per object is permitted for now. This will help with #1523.
* Add a missing incantation to fix doc(cfg=...).Nick Mathewson2024-08-131-0/+1
| | | | Without this, we get a warning when we run `cargo doc`.
* rpcbase: Feature to list the RPC methods and what they apply to.Nick Mathewson2024-08-123-0/+106
|
* rpcbase: Facility for looking up RPC method informationNick Mathewson2024-08-122-5/+43
| | | | | We'll need this to refer to the names of RPC methods as visible to the caller, and to cross-reference them with their related types.
* rpcbase: Expose Invocable type names directly.Nick Mathewson2024-08-121-6/+11
| | | | | | Previously, we exposed them only via `describe_invocable`, which would have required the caller to parse a string in order to find these.
* rpc: Remove special conversion for SendUpdateError.Nick Mathewson2024-07-252-10/+6
|
* rpc: Rename the error codes for something like consistency.Nick Mathewson2024-07-251-16/+17
|
* rpc: Remove RpcError data field and use ReportNick Mathewson2024-07-252-87/+31
| | | | | | | | | | | | Per discussion, this field isn't really specified in a way that lets us fill it sensibly at the moment. So for now, we're going to just omit it. Additionally, we said that we'd Report on our errors; this branch changes the implementation of RpcError to do that. Question: Will the blanket implementation for Into<RpcError> make it harder to re-add a Data field later on if we want to do so?
* rpc: Refactor errors part 1: a new RpcMethod trait.Nick Mathewson2024-07-253-28/+35
| | | | | It is no longer necessary to say, for every RPC method, that its error type is RpcError.
* rpcbase: remove now-unused invoke methodsNick Mathewson2024-07-252-71/+34
| | | | | | | These methods were defined on DispatchTable, and then replaced by top-level functions in the crate. (The reason for using top-level functions instead is so that we get the locking on the dispatch table correct.)
* rpcbase: Remove a TODO RPC about duplicationNick Mathewson2024-07-251-1/+0
| | | | | The duplication is only a few lines. I've looked into a couple of ways for removing it, but they make the code flow even less clear.
* rpcbase: Replace a TODO with a set of notes and caveatsNick Mathewson2024-07-251-7/+10
| | | | | | We have decided not to remove the "anybody can define methods" property. This commit documents the consequences, and warns extenders away from some really bad ideas.
* rpc: remove TODO about adding an extension traitNick Mathewson2024-07-251-4/+0
| | | | | These functions are called rarely enough that it is probably okay for the ergonomics to be a bit verbose.
* rpc: Remove TODO about moving @special to a different macro.Nick Mathewson2024-07-251-4/+0
|
* rpc: Do not hide InvokeError::Bug when converting to RpcErrorNick Mathewson2024-07-251-18/+35
|
* rpc: split "method not found"Nick Mathewson2024-07-251-7/+7
| | | | | We've wanted separate error codes for "no such method exists" and "this method exists, but this object doesn't have it."
* rpcbase: remove "Nil" TODO.Nick Mathewson2024-07-251-3/+0
| | | | This change would take some serde magic that is probably not worth it.
* rpcbase: Use newer "tgens" deftly syntaxNick Mathewson2024-07-251-3/+1
|
* rpcbase: remove a TODO about expose_outside_of_sessionNick Mathewson2024-07-251-4/+0
| | | | (There is no longer such a thing as a "pseudomethod.")
* rpcbase: tests for crate-level invoke functions.Nick Mathewson2024-07-152-20/+73
|
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-26 22:30:32 +0000