summaryrefslogtreecommitdiff
path: root/crates/tor-protover/src
Commit message (Collapse)AuthorAgeFilesLines
* protover: Use a faster check for unrecognized protocol uniqueness.Nick Mathewson2026-06-301-9/+13
| | | | | | | | | | Instead of doing an O(n) check every time we add an unrecognized protocol, we just scan the list of unrecognized protocols after we sort them. Closes #2601. Resolves TROVE-2026-027.
* tor-protover: Fix documentation regarding version `0`Clara Engler2026-06-251-2/+2
| | | | | See torspec!519. This is actually not legal and already rejected, the docs are just wrong.
* tor-protover: Make blocking TODO non-blockingClara Engler2026-06-241-1/+1
| | | | Let's leave this untouched for now as it is not urgent right now.
* Use Intern<T>Clara Engler2026-06-241-1/+2
| | | | | This commit modifies the codebase to actually return Intern<T> in InternCache<T> and adds calls to .into() accordingly.
* protover: remove str slice usageNick Mathewson2026-06-101-11/+4
|
* everywhere: Add #[allow(clippy::string_slice)]Clara Engler2026-06-091-0/+1
| | | | | | | | This commit adds #[allow(clippy::string_slice)] to all functions in the code where string slices are used, alongside a TODO comment. We do this add the function header to have it consistent, as things like expression based allow's are still experimental.
* maint: Run maint/add_warning to deny string slicesClara Engler2026-06-091-0/+2
| | | | | | | | | | | | This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.
* Allow clippy::collapsible_if to triggerGabriela Moldovan2026-02-161-0/+1
| | | | | | | | | `clippy::collapsible_if` started triggering after bumping the MSRV to 1.88. Since this triggers from a lot of places, and since there even are a couple of instances where we explicitly allow `clippy::collapsible_ifs`, I've opened #2342 for deciding what to do about it.
* maint/add_warning: Run script to add new warningGabriela Moldovan2026-01-271-0/+1
| | | | This adds the lint to all our crates.
* protover: document interning in Protocols docs.Nick Mathewson2025-12-041-0/+8
|
* protover: Intern ProtocolsInner.Nick Mathewson2025-12-031-1/+10
| | | | | This will help us with all the places we want to copy around Protocols objects.
* protover: Make Protocols become an Arc internally.Nick Mathewson2025-12-031-25/+42
| | | | This will help us make it self-interning.
* protover: Document un-recommended usage of Protocols::new()Nick Mathewson2025-12-031-0/+7
|
* Fix name of clippy lint to unchecked_time_subtraction (2)Ian Jackson2025-11-061-2/+2
| | | | Run maint/add_warning
* Remove "doc_auto_cfg" incantation from all crates.Nick Mathewson2025-09-291-1/+1
| | | | This feature has been removed from nightly, in favor of doc_cfg.
* tor-protover: small comment formatting fixSteven Engler2025-08-061-1/+1
| | | | | This breaks the syntax highlighting in vim for some reason and makes the file unreadable for me.
* protover: Allocate a capability number for RELAY_CRYPT_CGO.Nick Mathewson2025-07-231-0/+7
|
* Temporarily suppress mismatched_lifetime_syntaxes.Gabriela Moldovan2025-07-071-0/+1
| | | | See #2060.
* protover: New `NumberedSubver` to represent a subprotocol capNick Mathewson2025-05-071-1/+81
| | | | | This type differs from `NamedSubver` in that the represented subprotocol capability isn't necessarily recognized or valid.
* protover: Change ProtoKind to be a u8Nick Mathewson2025-05-071-2/+2
| | | | | It is not remotely close to exhausting a u8, and several of our protocols expect it to be expressible as one.
* protover, *: Add documentation about what "supported" means.Nick Mathewson2025-04-161-0/+21
|
* protover: Enforce that every unrecognized protocol entry is nonzero.Nick Mathewson2025-04-161-1/+5
| | | | This rule makes PartialEq more sensible.
* Add warnings about removing supported protocols.Nick Mathewson2025-04-161-0/+35
|
* protover,netdoc: Implement serde for Protocols etc.Nick Mathewson2025-04-161-0/+4
|
* New functions to report supported subprotocolsNick Mathewson2025-04-161-0/+7
| | | | | | | | | | | | | | | Part of #1849. Note that these functions are distributed across crates, so that if (in the future) we stop doing API breaks with every release, we will get the right outputs. Note also that these functions build the list of protocols out of specific symbolic features, rather than numbers: this makes it easier to avoid errors about "which feature was Relay=4 again", and easier to avoid accidentally referring to a protocol that doesn't exist, like "Consensus" (should be "Cons") or "HsDir" (case is wrong).
* protover: Correct capitalization of Micro[Dd]escNick Mathewson2025-04-162-10/+10
| | | | Closes #1923
* protover: Add an implementation for FromIteratorNick Mathewson2025-04-161-0/+37
|
* protover: document and enforce more invariantsNick Mathewson2025-04-161-3/+19
| | | | | | | | We have places where, if we were to create certain ProtoKinds or NamedProtos with invalid values, we could cause a panic. This isn't remotely triggerable, or even triggerable from outside the protover crate, but it's best to avoid the possibility of future mistakes.
* protover: add names for members of the Link protocol group.Nick Mathewson2025-04-161-0/+27
|
* protover: New function to intersect Protocols sets.Nick Mathewson2025-04-161-0/+53
| | | | | This will be helpful in building a list of protocols from several crates.
* protover: New function to combine (union) Protocols sets.Nick Mathewson2025-04-161-1/+57
| | | | | This will be helpful in building a list of protocols from several crates.
* protover: New function to subtract to Protocols sets.Nick Mathewson2025-04-161-0/+54
| | | | | This will be helpful in checking whether a list of protocols has any unsupported members.
* protover: Add support for subprotocol version mnemonics.Nick Mathewson2025-03-122-0/+160
| | | | | | | | It's error-prone to have to remember e.g. that "Desc=5" means "family ID support", so in torspec!251 we added mnemonic names like DESC_FAMILY_IDS. Here we use those names in tor-protover.
* protover: Add Conflux protocol group.Nick Mathewson2025-03-121-1/+3
|
* clippy: deny `mod_module_files`Steven Engler2025-01-061-0/+1
| | | | | | Denies 'mod.rs' files for consistency. https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
* add_warnings, *: Allow clippy::needless_lifetimesNick Mathewson2024-12-031-0/+1
| | | | | | | | In 1.83, this warning triggers on many of our crates. We're thinking of fixing them all, but for now, we're going to disable the warning. This is part of #1765.
* Re-run maint/add_warning.Nick Mathewson2024-05-061-2/+2
| | | | This commit is automatically generated.
* Run maint/add_warning.Nick Mathewson2024-03-131-0/+1
|
* deny clippy::unchecked_duration_subtractiontrinity-1686a2024-02-291-0/+1
|
* Run maint/add_warning to add lint block everywhereIan Jackson2023-08-231-0/+1
|
* Run add_warnings on all files.Nick Mathewson2023-08-041-2/+2
|
* Run maint/add_warning to actually apply new lint allowsIan Jackson2023-07-101-0/+2
|
* Run add_warning to remove `missing_panics_doc` deny.Nick Mathewson2023-07-061-1/+0
| | | | Closes #950.
* lints: Run maint/add_warning to actually apply new lintsIan Jackson2023-06-211-0/+2
|
* Allow clippy::unchecked_duration_subtraction in testsNick Mathewson2023-01-271-0/+1
| | | | | This panics on error, and we're fine with a panic on misbehavior in tests.
* Disable clippy::unlinlined-format-argsNick Mathewson2023-01-271-0/+1
| | | | | | | | This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748.
* test lint blocks: Add many many automaticallyIan Jackson2022-12-121-0/+8
| | | | | This is precisely the result of running the rune in maint/adhoc-add-lint-blocks.
* Run add_warnings.Nick Mathewson2022-11-031-0/+1
|
* cargo fmt to remove blank linesIan Jackson2022-10-121-1/+0
| | | | | | | Apparently cargo fmt doesn't like these, which my perl rune didn't delete. This commit is precisely the result of `cargo fmt`.
* Replace all README copies in src/lib.rs with includesIan Jackson2022-10-121-34/+1
| | | | | | | | The feature we want is `#[doc = include_str!("README.md")]`, which is stable since 1.54 and our MSRV is now 1.56. This commit is precisely the result of the following Perl rune: perl -i~ -0777 -pe 's{(^//!(?!.*\@\@).*\n)+}{#![doc = include_str!("../README.md")]\n}m' crates/*/src/lib.rs