mirrors/arti.git - mirror of https://gitlab.torproject.org/tpo/core/arti

	Commit message (Collapse)	Author	Age	Files	Lines
...
*	proto, cell: Remove RelayCellFormatTrait.	Nick Mathewson	2025-05-06	9	-197/+119
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The purpose of the trait was to parameterize the tor1 cell crypto on the different possible relay cell layouts. It made sense to have this trait when we thought we would implement the new cell layout for prop340 (packed-and-fragmented) well before we implemented CGO. But it now appears all but certain that CGO will land long before we make any more headway on prop340. Therefore, it doesn't make sense to carry the ability to customize `tor1` for other relay cell layouts. Removing this trait saves a fair bit of complexity.
*	tor-proto: Rename some no-longer-apt tor1 members.	Nick Mathewson	2025-05-06	1	-14/+13
\|
*	tor-proto: remove some now-unneeded accessors.	Nick Mathewson	2025-05-06	1	-35/+15
\|
*	Emit SendmeTag directly from cell crypto.	Nick Mathewson	2025-05-06	7	-100/+90
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This changes the code to copy a SendmeTag rather than returning a slice. This isn't actually a big change: sending a slice already required 16 bytes (on 64-bit platforms), so sending a SendmeTag around isn't a big deal. We rely extensively on the compiler's ability to optimize away all the checking in code like this: ``` let slice: &[u8]; let a: [u8;N] = slice[0..N].try_into().expect("Nope"); ``` I've spot-checked it somewhat with "cargo-show-asm", but it could use more thorough checking. Closes #1956.
*	Remove the last traces of CircTag.	Nick Mathewson	2025-05-06	5	-21/+19
\|
*	proto: Use SendmeTag in place of CircTag	Nick Mathewson	2025-05-06	2	-54/+9
\| \| \| \| \|	This doesn't make much change yet, but does save us an allocation when handling SENDMEs.
*	proto: Split out CGO BlkCipher trait for Encryption/Decryption	Nick Mathewson	2025-05-06	2	-57/+172
\| \| \| \| \| \|	This lets us use `Aes128Dec` and `Aes128Enc` in place of plain old `Aes128`, which can be less space-efficient depending on the back-end.
*	Merge branch 'clientcirc_extend' into 'main'	Nick Mathewson	2025-05-06	1	-6/+59
\|\ \| \| \| \| \| \| \| \| \| \| \| \|	tor-proto: New extend() and create_firsthop() to pick between ntor and ntor3 Closes #1970 See merge request tpo/core/arti!2967
\| *	proto: Fix documentation to avoid recommending ntor methods	Nick Mathewson	2025-04-28	1	-6/+8
\| \| \| \| \| \| \| \| \| \| \| \|	Since we have create_firsthop() and extend(), we should recommend them in our documentation, instead of recommending the no-longer-best methods.
\| *	proto: Provide and use a create_firsthop() wrapper too.	Nick Mathewson	2025-04-28	1	-0/+23
\| \|
\| *	tor-proto: New extend() to pick between ntor and ntor3	Nick Mathewson	2025-04-28	1	-0/+28
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	In the future, when we add more circuit handshakes (PQ anyone?) we'll want to have the logic for choosing which to use be unified. Almost nobody calling tor-proto should need to care which circuit handshake is going to be used. Closes #1970.
* \|	tor-proto: Use AcqRel instead of SeqCst to clarify intent.	Gabriela Moldovan	2025-05-06	2	-3/+3
\| \| \| \| \| \| \| \|	Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2946#note_3192334
* \|	tor-proto: Document the lifecycle of a ConfluxSet.	Gabriela Moldovan	2025-05-06	1	-1/+28
\| \|
* \|	tor-proto: Document why RemoveLegReason exists.	Gabriela Moldovan	2025-05-06	1	-0/+14
\| \|
* \|	tor-proto: Move error binding under is_conflux_pending condition.	Gabriela Moldovan	2025-05-06	1	-7/+6
\| \| \| \| \| \| \| \|	We don't use it outside this branch, so might as well move it there.
* \|	tor-proto: Remove already-addressed TODO.	Gabriela Moldovan	2025-05-06	1	-2/+0
\| \| \| \| \| \| \| \|	We already do this, using `note_conflux_handshake_result`.
* \|	tor-proto: Explain why the handshake result is noted before the LINKED_ACK.	Gabriela Moldovan	2025-05-06	1	-1/+10
\| \|
* \|	tor-proto: Remove confusing parts of join_point docs.	Gabriela Moldovan	2025-05-06	1	-4/+1
\| \|
* \|	tor-proto: Future-proof the unsupported_client_cell macro.	Gabriela Moldovan	2025-05-06	1	-1/+2
\| \| \| \| \| \| \| \| \| \|	Prompted by opara's suggestion in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2946#note_3192319
* \|	tor-proto: Clarify why ConfluxHandshakeComplete exists.	Gabriela Moldovan	2025-05-06	1	-0/+8
\| \|
* \|	tor-proto: s/ConfluxTunnelResult/ConfluxHandshakeResults.	Gabriela Moldovan	2025-05-06	1	-4/+4
\| \|
* \|	tor-proto: Linkify reference to HopDetail.	Gabriela Moldovan	2025-05-06	1	-1/+1
\| \|
* \|	tor-proto: Fix incorrect RemoveLeg docs.	Gabriela Moldovan	2025-05-06	1	-1/+1
\| \|
* \|	tor-proto: Clarify ConfluxHandshakeComplete docs.	Gabriela Moldovan	2025-05-06	1	-2/+3
\| \|
* \|	tor-proto: Remove unnecessary TODO.	Gabriela Moldovan	2025-05-06	1	-2/+0
\| \|
* \|	tor-proto: Add TODO about only switching legs before sending a cell.	Gabriela Moldovan	2025-05-06	1	-0/+4
\| \|
* \|	tor-proto: Increment last delivered seqno for items popped from the heap.	Gabriela Moldovan	2025-05-06	2	-4/+14
\| \|
* \|	tor-proto: Remove unnecessary &mut self.	Gabriela Moldovan	2025-05-06	1	-1/+1
\| \|
* \|	tor-proto: Fix typo in warning.	Gabriela Moldovan	2025-05-06	1	-1/+1
\| \|
* \|	tor-proto: Remove unnecessary mut in seqno check.	Gabriela Moldovan	2025-05-06	1	-1/+1
\| \|
* \|	tor-proto: Rename helper closure for clarity.	Gabriela Moldovan	2025-05-06	1	-2/+2
\| \|
* \|	tor-proto: s/leg/hop in variable name for clarity.	Gabriela Moldovan	2025-05-06	1	-2/+2
\| \|
* \|	tor-proto: Get rid of unnecessary clone().	Gabriela Moldovan	2025-05-06	1	-4/+1
\| \|
* \|	tor-proto: Note that we need to update impl based on torspec!369	Gabriela Moldovan	2025-05-06	1	-0/+2
\| \|
* \|	tor-proto: Note the LINK cell was sent after sending it.	Gabriela Moldovan	2025-05-06	1	-5/+9
\| \|
* \|	tor-proto: Shut down if conflux initiator is gone before handshake completes.	Gabriela Moldovan	2025-05-06	1	-13/+28
\| \|
* \|	tor-proto: Move SWITCH seqno validation to validate_switch_seqno.	Gabriela Moldovan	2025-05-06	1	-8/+8
\| \|
* \|	tor-proto: Validate conflux state before decoding SWITCH.	Gabriela Moldovan	2025-05-06	1	-5/+5
\| \|
* \|	tor-proto: s/link/linked_ack in variable name.	Gabriela Moldovan	2025-05-06	1	-2/+2
\| \|
* \|	tor-proto: Validate conflux state before decoding LINKED cell.	Gabriela Moldovan	2025-05-06	1	-17/+17
\| \|
* \|	tor-proto: Check that we sent a LINK cell before decoding LINKED response.	Gabriela Moldovan	2025-05-06	1	-5/+5
\| \|
* \|	tor-proto: Use u64 for the conflux seqnos.	Gabriela Moldovan	2025-05-06	4	-22/+32
\| \|
* \|	tor-proto: Mention that the error came from a conflux circuit.	Gabriela Moldovan	2025-05-06	1	-1/+1
\| \|
* \|	tor-proto: Remove references to non-client handlers from ↵	Gabriela Moldovan	2025-05-06	1	-6/+1
\| \| \| \| \| \| \| \|	ClientConfluxMsgHandler.
* \|	tor-proto: Allow cognitive complexity on handle_meta_cell.	Gabriela Moldovan	2025-05-06	1	-0/+1
\| \|
* \|	tor-proto: Deferred fmt.	Gabriela Moldovan	2025-05-06	1	-4/+1
\| \|
* \|	tor-proto: Handle conflux handshake timeout, notify on completion.	Gabriela Moldovan	2025-05-06	5	-44/+133
\| \|
* \|	tor-proto: Use wallclock time in ClientConfluxMsgHandler.	Gabriela Moldovan	2025-05-06	5	-19/+42
\| \|
* \|	tor-proto: Implement conflux set leg removal.	Gabriela Moldovan	2025-05-06	4	-7/+145
\| \|
* \|	tor-proto: Reject cells received before conflux handshake is complete.	Gabriela Moldovan	2025-05-06	1	-0/+10
\| \|