| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |
|
|
| |
Signed-off-by: David Goulet <[email protected]>
|
| |\
| |
| |
| |
| | |
Fix new warnings from Rust 1.95
See merge request tpo/core/arti!3902
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
tor-proto: Small comment and variable name changes
See merge request tpo/core/arti!3865
|
| | | |
| | |
| | |
| | | |
I think this makes the code a little easier to follow.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
proto: Remove dummy suffixes from variable name
See merge request tpo/core/arti!3903
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I used these `_foo` suffixes to make sense of things during development:
at the time, I had multiple "forward" and "backward" types, and I needed
to distinguish them without spending too much time thinking of a
provisory name. I meant to remove them before upstreaming my branch, but
I forgot...
|
| | |_|/
|/| |
| | |
| | |
| | | |
I'm removing this so that we don't accidentally suppress new instances
of this warning.
|
| |/ /
| |
| |
| | |
This will be needed for ntor handshakes.
|
| | |
| |
| |
| | |
Signed-off-by: David Goulet <[email protected]>
|
| | |
| |
| |
| |
| |
| |
| | |
The CreateRequestHandler was introduced prior to the relay handshake
unit tests so fix them now that we have a way to build one.
Signed-off-by: David Goulet <[email protected]>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
We can't access `NetParameters` in this crate to build from consensus
default value so instead add a `defaults_for_tests()` gated function for
each parameters object which puts in the defaults from the spec.
We'll need CircNetParameters in order to build create request handler
for unit tests hence why it is in src/circuit.rs.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
From the reactor.rs to channel.rs, makes more sense and we'll need it in
the handshake tests.
No behavior change, just code movement and a function rename.
Signed-off-by: David Goulet <[email protected]>
|
| | |
| |
| |
| | |
Signed-off-by: David Goulet <[email protected]>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of copying the client unit tests into the channel module, just
make both current unit tests run on a client and relay handshake.
This required a bit of trickery with type HandshakeConnectFn but works
out in the end.
It also adds the RelayMsgBuf that wraps a MsgBuf in order to implement
CertifiedConn which is very relay only.
Signed-off-by: David Goulet <[email protected]>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Just for mental sanity to have all const at the same place and easily
readable.
No behavior change.
Signed-off-by: David Goulet <[email protected]>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
No behavior change.
Make the const cells public as they will be useful for more upcoming
unit tests especially on the relay side.
Signed-off-by: David Goulet <[email protected]>
|
| | |
| |
| |
| |
| | |
If this is zero, then it means that the consensus had bad values.
But may as well check it anyways.
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Tweak TunnelId and TunnelScopedCircId Display impls
See merge request tpo/core/arti!3875
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Circuit IDs (UniqId) are displayed as "Circ <x>.<y>".
Prior to this MR, these TunnelScopedCircId's were displayed as
"Circ <t>.<x>.<y>" where t is the integer tunnel ID. This made corresponding
logs a bit confusing as to why some "Circ" identifiers had two parts and
some have three, and didn't make clear that the "<x>.<y>" part of the latter
were comparable with the two-part UniqIds.
The previous commit effectively changes the latter to
"Circ Tunnel <t>.<x>.<y>", which is still a bit confusing.
This commit changes the display of TunnelScopedCircId's to "Circ <x>.<y>
(Tunnel <t>)", which makes the distinction between the circuit and
tunnel IDs clearer.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This is akin to how circuit `UniqId`'s are prefixed with "Circ", and
helps clarify logs where it isn't always clear from context whether a
tunnel ID or circuit ID is being displayed.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
This will be needed for ntor handshakes.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
This also updates the key rotation task to call the setter whenever the
ntor keys get updated.
|
| | | |
| | |
| | |
| | | |
This will need to be updated each time the ntor keys change.
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This trickles down to the tor-proto channel handshake code. But, the
real need is in the channel builder in order to validate the outbound
channel target.
Fixes #2440
Signed-off-by: David Goulet <[email protected]>
|
| |\ \
| | |
| | |
| | |
| | | |
tor-proto: Move CREATE_FAST handling to a helper
See merge request tpo/core/arti!3869
|
| | | |
| | |
| | |
| | |
| | | |
Clippy has started warning about this since we moved the CREATE_FAST
handling to a helper, so this resolves that.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Fix formatting from previous code movement.
|
| | | |
| | |
| | |
| | |
| | | |
This moves the code, changes the indentation, and wraps the result in an
`Ok()`.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
This had already been resolved.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
From opara's comment:
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3844#note_3388789
Keep the low level AuthLogDigest type alias and return it. The callsite
is the one deciding if the returned digest is a Clog or a Slog.
Related to #2441
Signed-off-by: David Goulet <[email protected]>
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| | |
Introduce those types in order to avoid mixing them up as the previous
AuthLogDigest was just a type alias over [u8; 32]
Fixes #2441
Signed-off-by: David Goulet <[email protected]>
|
| |\ \
| | |
| | |
| | |
| | | |
Add support for handling CREATE_FAST cells and launching a circuit reactor
See merge request tpo/core/arti!3846
|
| | | | |
|
| | | |
| | |
| | |
| | | |
This reverts commit 9c38daf2d3548feca2ff555f5bd52165add0d20c.
|
| | | |
| | |
| | |
| | | |
This is needed for the revert in the following commit.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Instead of giving the `CreateRequestHandler` to the channel after it's
constructed, we integrate it into the handshake so that we can give it
to the channel constructor.
The `ChannelType` is no longer part of the `Channel`.
Some of the tests could be cleaned up slightly now that the channel
doesn't need the `ChannelType`, but I don't want to conflict with !3853.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|