aboutsummaryrefslogtreecommitdiff
path: root/crates/tor-proto/src
Commit message (Collapse)AuthorAgeFilesLines
...
| * proto: Add a control message for closing pending streamsGabriela Moldovan2026-06-232-1/+41
| |
| * proto: Replace StreamMsg with a new CtrlMsg typeGabriela Moldovan2026-06-234-26/+32
| | | | | | | | | | | | | | This replaces the `StreamMsg` `StreamReactor` sender with a new `CtrlMsg` type. This `CtrlMsg` currently only has a `DeliverStreamMsg` variant (which is the same as the old `StreamMsg` type), but will soon grow another variant, for terminating a stream.
| * proto: Make the new reject_stream() test check the END cell tooGabriela Moldovan2026-06-231-1/+5
| |
| * proto: Factor helper macro out of test functionGabriela Moldovan2026-06-231-17/+17
| | | | | | | | This is just code motion
| * proto: Refactor test macro to not rely on function contextGabriela Moldovan2026-06-231-6/+7
| | | | | | | | | | | | I am about to move this out of the `extend_and_forward()` test, because I want to reuse it in the new `reject_stream()` test for checking that the relay wrote an END cell to the stream.
| * proto: Add a test for rejecting an incoming stream in the relay reactorGabriela Moldovan2026-06-231-0/+40
| | | | | | | | | | | | | | | | This test currently fails, because `IncomingStream::reject()` calls `RelayCirc::close_pending()` under the hood, which isn't implemented yet. Part of #2590
* | proto: log hop settings at trace upon client circuit opening.Nick Mathewson2026-06-231-1/+2
|/
* proto: Update tests to use the new stream exportsGabriela Moldovan2026-06-171-4/+4
| | | | The tests don't compile otherwise.
* proto: Add crate-level exports for two extra stream types (fmt)Gabriela Moldovan2026-06-176-26/+9
|
* proto: Add crate-level exports for two extra stream typesGabriela Moldovan2026-06-171-0/+4
| | | | | For convenience. This will soon replace a corresponding re-export from `tor_proto::client::stream`.
* proto: Re-export StreamReceiver from tor_proto::streamGabriela Moldovan2026-06-171-1/+2
| | | | This will soon replace the re-export from `tor_proto::client::stream`.
* proto: Re-export the Incoming* types from tor_proto::streamGabriela Moldovan2026-06-171-0/+6
| | | | | | | | | | These will replace the pub re-exports from `tor_proto::client::stream`. This reorg is needed because currently, the only public export of the incoming stream types is from `tor_proto::client::stream`, but these aren't actually client specific: relays will use them too, for implementing exit, DNS and directory streams. So it makes more sense to export them from the top-level stream module instead.
* proto: Make the stream module pubGabriela Moldovan2026-06-171-1/+1
|
* Merge branch 'flowctrl-tests' into 'main'opara2026-06-161-13/+433
|\ | | | | | | | | tor-proto: Add unit test for `XonXoffReader` See merge request tpo/core/arti!4093
| * tor-proto: add a unit test for `XonXoffReader`Steven Engler2026-06-161-0/+398
| | | | | | | | | | The 'futures' version bump is needed so that our test can use `UnboundedSender::try_recv()` in the minimal-versions CI test.
| * tor-proto: add `DrainRateNotifier` trait for `XonXoffReader`Steven Engler2026-06-101-13/+35
| | | | | | | | This will allow us to add a unit test for `XonXoffReader`.
* | Merge branch 'destroy' into 'main'opara2026-06-122-29/+5
|\ \ | | | | | | | | | | | | | | | | | | Always use destroy reason NONE in circuit handshake code Closes #2466 See merge request tpo/core/arti!4088
| * | tor-proto: circ handshake now always uses NONE destroy reasonSteven Engler2026-06-122-29/+5
| |/
* / tor-proto: Remove a now-redundant .iter() in a call to iter_joinIan Jackson2026-06-111-1/+1
|/
* maint: Run maint/add_warning to deny string slicesClara Engler2026-06-0935-0/+36
| | | | | | | | | | | | This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.
* proto: Move RateLimitedWriter to tor-async-utilsDavid Goulet2026-06-085-766/+3
| | | | Signed-off-by: David Goulet <[email protected]>
* proto: Move TokenBucket to tor-basic-utilsDavid Goulet2026-06-083-848/+3
| | | | Signed-off-by: David Goulet <[email protected]>
* Merge branch 'destroy-cell3' into 'main'gabi-2502026-06-089-28/+395
|\ | | | | | | | | proto: Add a new channel -> circuit queue type See merge request tpo/core/arti!4025
| * proto: Update the tests to use the new CircuitRx{Receiver,Sender}sGabriela Moldovan2026-06-086-16/+17
| |
| * proto: Replace CircuitRx{Sender,Receiver} with new channel typeGabriela Moldovan2026-06-083-11/+5
| | | | | | | | | | | | | | | | | | | | This is needed for relays as part of #2490. Note that changing this type affects the client implementation too (i.e. clients will start prioritizing inbound DESTROY, discarding any queued data without forwarding it to their local streams). But that's okay, because it will generally only affect misbehaving clients, and clients unlucky enough to encounter a hibernating relay.
| * proto: Remove now-unused importGabriela Moldovan2026-06-081-1/+1
| | | | | | | | | | `CircuitRxSender` is no longer a `Sink`, so we don't need this import anymore.
| * proto: Add a new channel -> circuit queue typeGabriela Moldovan2026-06-082-0/+372
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds new a `CircuitRxSender`/`CircuitRxReceiver` queue type. The corresponding (`Sink`-link) sender and `Stream` implementations prioritize the delivery of `DESTROY` messages, which get delivered immediately, even if there are other messages queued in the underlying MPSC message queue. We are okay with the resulting data loss, because inbound DESTROY can be indicative of malicious activity on the circuit. We choose to err on the safe side, and free up the resources associated with such circuits as soon as possible. DESTROY messages are also sent by relays when they're about to hibernate, and by clients once they've decided to stop using a circuit. In the latter case, the lack of an `RELAY_COMMAND_END_ACK` does mean that this prioritization can cause data loss in cases where the client closes the circuit immediately after END-ing a stream. However, this is a deficiency in the protocol, and not something we want to fix by implementing custom flushing logic in the reactor. See torspec#196 and the discussion in #2490. Part of #2490
* | proto: Enable the relay exit stream testGabriela Moldovan2026-06-081-1/+0
| | | | | | | | | | This passes now that we can build a `DataStream` without a `ClientDataStreamCtrl`.
* | proto: Set the ClientDataStreamCtrl to None for relay streams (fmt)Gabriela Moldovan2026-06-081-5/+7
| |
* | proto: Set the ClientDataStreamCtrl to None for relay streamsGabriela Moldovan2026-06-081-3/+3
| | | | | | | | Previously this would panic.
* | proto: Make the ClientDataStreamCtrl optional throughoutGabriela Moldovan2026-06-081-12/+22
|/ | | | | | | We will reuse `DataStream` for relay exit streams, and those aren't going to have a `ClientDataStreamCtrl`. Part of #2557
* proto: add regression tests for verify_link_auth_certmoumenalaoui2026-06-021-0/+79
| | | | Signed-off-by: David Goulet <[email protected]>
* proto: Fix inverted cert sig and AUTHENTICATE compareDavid Goulet2026-06-022-5/+2
| | | | | | | | | | | | Missed at review and no unit tests at the time catched those. The next commit has a unit tests to make sure these checks are now valid. Fixes #2501 Fixes #2502 Special thanks to Moumen Alaoui for reporting this early! Signed-off-by: David Goulet <[email protected]>
* Merge branch 'minor-doc-fix' into 'main'gabi-2502026-06-021-1/+1
|\ | | | | | | | | proto: Fix typo in ResolveCmdChecker docs See merge request tpo/core/arti!4035
| * proto: Fix typo in ResolveCmdChecker docsGabriela Moldovan2026-05-281-1/+1
| | | | | | | | This returns a boxed `ResolveCmdChecker`, not a `DataCmdChecker`.
* | Merge branch 'stream-docs' into 'main'David Goulet2026-05-283-4/+4
|\ \ | | | | | | | | | | | | proto: Replace outdated references to RawCellStream See merge request tpo/core/arti!4036
| * | proto: Replace outdated references to RawCellStreamGabriela Moldovan2026-05-283-4/+4
| |/ | | | | | | | | `RawCellStream` was removed long ago, in c559754116678866eabe525f5b189b50cc78b5cc.
* / tor-proto: remove `use asynchronous_codec as futures_codec` in ↵Neel Chauhan2026-05-271-13/+14
|/ | | | | | `/channel/handler.rs` Closes #1690.
* Merge branch 'relay-destroy' into 'main'gabi-2502026-05-263-31/+161
|\ | | | | | | | | proto: Add tests for DESTROY and TRUNCATE handling See merge request tpo/core/arti!4008
| * proto: Remove TODOs about flushing pending dataGabriela Moldovan2026-05-262-8/+0
| | | | | | | | | | | | We decided the reactor is the wrong place to handle this. See discussion in #2490
| * proto: Remove unused asyncGabriela Moldovan2026-05-201-3/+2
| |
| * proto: Make TRUNCATE trigger a proto violationGabriela Moldovan2026-05-202-5/+25
| |
| * proto: Add some tests for DESTROY handlingGabriela Moldovan2026-05-201-1/+60
| |
| * proto: Make do_create2_handshake() check EXTENDED2 was sentGabriela Moldovan2026-05-201-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds an extra assertion that ensures the relay reactor does in fact send an EXTENDED2 on its towards-the-client channel after receiving the CREATED2 response from the fake hop. This check is nice to have in general, but the main reason I'm doing this now is because for the DESTROY tests I'm about to add, I need the inbound MPSC queue (towards the client) drained of these handshake messages in order to check that the "next" cell we've sent is a destroy. I could've added some custom code to drain it just for the purposes of that test, but I think it's better to have `do_create2_handshake()` take care of it.
| * proto: Extend helper to check that DESTROY was sent in both directionsGabriela Moldovan2026-05-201-7/+21
| |
| * proto: Rename a test helper and adjust its docsGabriela Moldovan2026-05-201-7/+6
| | | | | | | | | | | | | | | | The new name is (hopefully) a bit more descriptive. I'm planning on extending this function soon to support checking if a DESTROY has been sent on the outbound channel too, so I'm tweaking the docs a bit in preparation for that.
| * proto: Return the CircId from test handshake helperGabriela Moldovan2026-05-201-2/+4
| | | | | | | | I'll soon need this for a DESTROY test.
| * proto: Add test helper for sending AnyChanMsgsGabriela Moldovan2026-05-201-0/+5
| |
| * proto: Add a comment clarifying why we don't need to propagate DESTROYGabriela Moldovan2026-05-201-0/+7
| |
| * proto: Adjust DESTROY-related logs in the backward reactorGabriela Moldovan2026-05-201-2/+6
| | | | | | | | | | | | | | This changes a debug log to have the same format as the corresponding DESTROY-related log from the forward reactor. Part of #2490
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 03:28:57 +0000