aboutsummaryrefslogtreecommitdiff
path: root/crates/tor-proto/src
Commit message (Collapse)AuthorAgeFilesLines
...
* tor-proto: Add note about raciness of last_hop_num.Gabriela Moldovan2025-05-151-0/+15
|
* tor-proto: Add TODO about possibly replacing LegIdKey with UniqId.Gabriela Moldovan2025-05-151-0/+3
|
* tor-proto: Remove the CircuitSharedState type alias.Gabriela Moldovan2025-05-151-6/+2
| | | | Hiding the underlying type makes the code less readable.
* tor-proto: Clarify the MutableState::path() docs.Gabriela Moldovan2025-05-151-1/+1
|
* tor-proto: Update the TunnelMutableState when a circuit is removed.Gabriela Moldovan2025-05-152-17/+28
| | | | | | | | This is messy, because `ClientCirc::{path_ref, n_hops, ..}` become fallible (we can't unwrap the result, because when a circuit is closed, its state gets removed from the `TunnelSharedState`, but its `ClientCirc` handle continues to exist, so any attempt to retrieve the state will result in an `Err`).
* tor-proto: Rework MutableState to work with multi-path circuits.Gabriela Moldovan2025-05-154-31/+176
| | | | | | | | | | We now have a new `TunnelSharedState` type for storing the shared state of a tunnel. It consists of the `MutableState`s of all the circuits in the tunnel, which are shared between it and `Circuit` (the circuit subcomponent of the reactor). The `TunnelSharedState` itself is shared between `ConfluxSet` (which manages the `Circuits`), and `ClientCirc` (the reactor handle used to access information about circuits, such as their `Path`).
* tor-proto: Add From<LegIdKey> impl for LegId.Gabriela Moldovan2025-05-151-0/+6
| | | | This will simplify some callsites.
* tor-proto: Encapsulate MutableState operations inside impl.Gabriela Moldovan2025-05-153-42/+66
| | | | | Not locking the `MutableState` mutex outside of this impl makes it easier to see it's currently impossible deadlock.
* tor-proto: Rename MutableState to CircuitState.Gabriela Moldovan2025-05-153-9/+9
| | | | | | This renaming is in preparation for the addition of a newtype wrapper for what used to be `Mutex<MutableState>`. That newtype wrapper will be called `MutableState`.
* tor-proto: Make the MutableState internals private.Gabriela Moldovan2025-05-152-5/+18
|
* tor-proto: Remove deprecated ClientCirc functions.Gabriela Moldovan2025-05-151-48/+11
| | | | | | These functions have been deprecated for a while, and are now complicating the `MutableState` changes we need to do for #1840, so it seems like a good time to remove them.
* proto: use consts for bench throuputsLionel Goffaux2025-05-142-0/+6
|
* proto: fix doc typosLionel Goffaux2025-05-143-4/+4
|
* proto: fix name mismatch in the bench utils docLionel Goffaux2025-05-083-10/+10
|
* proto: fix typo s(t)ateLionel Goffaux2025-05-081-3/+3
|
* proto: extend benchmarksLionel Goffaux2025-05-085-147/+303
|
* Use simpler way to refer to last byte of tag.Nick Mathewson2025-05-071-1/+1
|
* proto: Clear low 6 bits of counter in CGO PRF.Nick Mathewson2025-05-071-3/+4
| | | | See torspec#332.
* cell,proto: Split request/response extensions into seprate typesNick Mathewson2025-05-073-15/+14
| | | | Implements part of proposal 358.
* cell: Use ExtList to implement CircRequestExt.Nick Mathewson2025-05-075-17/+20
| | | | This required some renaming, so that the types and their codes matched.
* Rename NtorV3Extension to CircRequestExtNick Mathewson2025-05-075-27/+28
| | | | | | | This type will, because of prop358, be shared by ntorv3, hs-ntor, and probably other future handshakes. There will also be a CircResponseExt type.
* tor_proto: name fields in bench_utils.Nick Mathewson2025-05-061-7/+10
|
* proto: Apply type-specific wrappers for tor1 cryptoNick Mathewson2025-05-066-79/+143
| | | | | | | | | | | | | Now instead of using CryptState for everything, we have specific types for each role and direction of crypto. This turned up a harmless-so-far bug in our onion service code: as an onion service, we were using _client_ crypto layers to respond to a client request. That's not correct, and wouldn't have worked with CGO. Instead, we need to use relay crypto layers, wrapped as client layers. Closes #1975.
* proto, cell: Remove RelayCellFormatTrait.Nick Mathewson2025-05-065-163/+94
| | | | | | | | | | | | | | | | The purpose of the trait was to parameterize the tor1 cell crypto on the different possible relay cell layouts. It made sense to have this trait when we thought we would implement the new cell layout for prop340 (packed-and-fragmented) well before we implemented CGO. But it now appears all but certain that CGO will land long before we make any more headway on prop340. Therefore, it doesn't make sense to carry the ability to customize `tor1` for other relay cell layouts. Removing this trait saves a fair bit of complexity.
* tor-proto: Rename some no-longer-apt tor1 members.Nick Mathewson2025-05-061-14/+13
|
* tor-proto: remove some now-unneeded accessors.Nick Mathewson2025-05-061-35/+15
|
* Emit SendmeTag directly from cell crypto.Nick Mathewson2025-05-065-91/+81
| | | | | | | | | | | | | | | | | | | | This changes the code to copy a SendmeTag rather than returning a slice. This isn't actually a big change: sending a slice already required 16 bytes (on 64-bit platforms), so sending a SendmeTag around isn't a big deal. We rely extensively on the compiler's ability to optimize away all the checking in code like this: ``` let slice: &[u8]; let a: [u8;N] = slice[0..N].try_into().expect("Nope"); ``` I've spot-checked it somewhat with "cargo-show-asm", but it could use more thorough checking. Closes #1956.
* Remove the last traces of CircTag.Nick Mathewson2025-05-065-21/+19
|
* proto: Use SendmeTag in place of CircTagNick Mathewson2025-05-062-54/+9
| | | | | This doesn't make much change yet, but does save us an allocation when handling SENDMEs.
* proto: Split out CGO BlkCipher trait for Encryption/DecryptionNick Mathewson2025-05-062-57/+172
| | | | | | This lets us use `Aes128Dec` and `Aes128Enc` in place of plain old `Aes128`, which can be less space-efficient depending on the back-end.
* Merge branch 'clientcirc_extend' into 'main'Nick Mathewson2025-05-061-6/+59
|\ | | | | | | | | | | | | tor-proto: New extend() and create_firsthop() to pick between ntor and ntor3 Closes #1970 See merge request tpo/core/arti!2967
| * proto: Fix documentation to avoid recommending ntor methodsNick Mathewson2025-04-281-6/+8
| | | | | | | | | | | | Since we have create_firsthop() and extend(), we should recommend them in our documentation, instead of recommending the no-longer-best methods.
| * proto: Provide and use a create_firsthop() wrapper too.Nick Mathewson2025-04-281-0/+23
| |
| * tor-proto: New extend() to pick between ntor and ntor3Nick Mathewson2025-04-281-0/+28
| | | | | | | | | | | | | | | | | | In the future, when we add more circuit handshakes (PQ anyone?) we'll want to have the logic for choosing which to use be unified. Almost nobody calling tor-proto should need to care which circuit handshake is going to be used. Closes #1970.
* | tor-proto: Use AcqRel instead of SeqCst to clarify intent.Gabriela Moldovan2025-05-062-3/+3
| | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2946#note_3192334
* | tor-proto: Document the lifecycle of a ConfluxSet.Gabriela Moldovan2025-05-061-1/+28
| |
* | tor-proto: Document why RemoveLegReason exists.Gabriela Moldovan2025-05-061-0/+14
| |
* | tor-proto: Move error binding under is_conflux_pending condition.Gabriela Moldovan2025-05-061-7/+6
| | | | | | | | We don't use it outside this branch, so might as well move it there.
* | tor-proto: Remove already-addressed TODO.Gabriela Moldovan2025-05-061-2/+0
| | | | | | | | We already do this, using `note_conflux_handshake_result`.
* | tor-proto: Explain why the handshake result is noted before the LINKED_ACK.Gabriela Moldovan2025-05-061-1/+10
| |
* | tor-proto: Remove confusing parts of join_point docs.Gabriela Moldovan2025-05-061-4/+1
| |
* | tor-proto: Future-proof the unsupported_client_cell macro.Gabriela Moldovan2025-05-061-1/+2
| | | | | | | | | | Prompted by opara's suggestion in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2946#note_3192319
* | tor-proto: Clarify why ConfluxHandshakeComplete exists.Gabriela Moldovan2025-05-061-0/+8
| |
* | tor-proto: s/ConfluxTunnelResult/ConfluxHandshakeResults.Gabriela Moldovan2025-05-061-4/+4
| |
* | tor-proto: Linkify reference to HopDetail.Gabriela Moldovan2025-05-061-1/+1
| |
* | tor-proto: Fix incorrect RemoveLeg docs.Gabriela Moldovan2025-05-061-1/+1
| |
* | tor-proto: Clarify ConfluxHandshakeComplete docs.Gabriela Moldovan2025-05-061-2/+3
| |
* | tor-proto: Remove unnecessary TODO.Gabriela Moldovan2025-05-061-2/+0
| |
* | tor-proto: Add TODO about only switching legs before sending a cell.Gabriela Moldovan2025-05-061-0/+4
| |
* | tor-proto: Increment last delivered seqno for items popped from the heap.Gabriela Moldovan2025-05-062-4/+14
| |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 12:06:51 +0000