summaryrefslogtreecommitdiff
path: root/crates/tor-proto/src/tunnel
Commit message (Collapse)AuthorAgeFilesLines
* tor-proto: Add _mut suffix to functions returning mutable circs (fmt).Gabriela Moldovan2025-02-261-1/+5
|
* tor-proto: Add _mut suffix to functions returning mutable circs.Gabriela Moldovan2025-02-263-20/+20
|
* tor-proto: s/legs/leg in variable name.Gabriela Moldovan2025-02-261-2/+2
|
* tor-proto: Add TODO about removing CtrlMsg::SendSendme.Gabriela Moldovan2025-02-261-0/+2
|
* tor-proto: Update misleading comment about SENDMEs.Gabriela Moldovan2025-02-261-1/+2
|
* tor-proto: Make the reactor shut down when all the legs close.Gabriela Moldovan2025-02-262-1/+17
|
* tor-proto: Simplify expression using is_ok_and.Gabriela Moldovan2025-02-261-1/+1
| | | | As suggested by opara in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2804#note_3165059
* tor-proto: Rename Circuit variable to circ.Gabriela Moldovan2025-02-261-4/+4
| | | | | It used to be a Reactor, but the `reactor` variable name no longer makes sense.
* tor-proto: Avoid using Reactor in the circuit extender.Gabriela Moldovan2025-02-262-12/+9
| | | | | | This helps us get rid of some unnecessary error handling. Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2804#note_3165058
* tor-proto: Begin documenting the circuit removal behavior.Gabriela Moldovan2025-02-261-1/+17
|
* tor-proto: Forbid CtrlMsg::Extend* on multipath tunnels.Gabriela Moldovan2025-02-251-0/+20
| | | | We definitely don't want to ever allow this.
* tor-proto: Avoid panicking on double CtrlMsg::Create.Gabriela Moldovan2025-02-252-16/+35
| | | | | | | | | | | | | | Previously, sending two `CtrlMsg::Create` to the reactor would cause it to panic. This makes it so that the double `Create` just leads to the caller receiving an error response via the completion channel. Note: this was not triggerable via the network, only via the tor-proto API. Moreover, the panic was unreachable from the public client API, because the `PendingClientCirc`/`ClientCirc` typestate makes it impossible to send a second `Create` (the `PendingClientCirc` becomes `ClientCirc` after the `Create` completes, and `PendingClientCirc` doesn't have an API for sending `Create` control messages to the reactor).
* tor-proto: Update docs to refer to Circuit instead of Reactor.Gabriela Moldovan2025-02-251-3/+3
|
* tor-proto: Add some more conflux-related TODOs.Gabriela Moldovan2025-02-251-0/+10
|
* tor-proto: Use a ConfluxSet in the circuit reactor.Gabriela Moldovan2025-02-254-48/+98
| | | | | | | | | | | | | | | | | | | | | | | This is the first step toward supporting traffic splitting in the circuit reactor. While the logic has changed slightly to support handling circuits instead of just one, the reactor still only supports `ConfluxSet`s of size 1, so this should effectively be a no-op. In the future, this code will be extended to support the conflux-specific cells and to implement the conflux proto. The code uses `ConfluxSet::primary_leg()` and `ConfluxSet::single_leg()` somewhat interchangeably. This is not *currently* a problem because`primary_leg()` is the same as `single_leg()` for single path tunnels, but we will need to adjust some of these call sites when we add support for multipath tunnels (I have left a `TODO(conflux)` for every dubious call site). This commit also makes `CtrlMsg::FirstHopClockSkew` fallible: if the reactor is multipath, it will return `Err(Bug(..))` to the caller (this error is returned to the caller over the `answer` channel; it does *not* shut down the reactor)
* tor-proto: Add a ConfluxSet type.Gabriela Moldovan2025-02-252-0/+77
|
* tor-proto: Move most of the reactor impl to Circuit (fmt).Gabriela Moldovan2025-02-252-8/+24
|
* tor-proto: Move most of the reactor impl to Circuit.Gabriela Moldovan2025-02-254-70/+60
| | | | | | | This is an intermediate step in rewriting the reactor to manage a "conflux set" (a set of linked circuits) rather than a single circuit. This commit contains no functional changes.
* tor-proto: Factor out stream management functionality.Gabriela Moldovan2025-02-252-21/+43
| | | | | These will soon be functions on `Circuit`, so it's a good time to pull them out of the reactor impl.
* tor-proto: Shuffle reactor impl in preparation for refactoring.Gabriela Moldovan2025-02-251-466/+466
| | | | | | | | | This reorders the functions from the `Reactor` implementation in preparation for moving some of them to `Circuit`. This commit contains no functional changes and should be reviewed with `git diff --color-moved`. A future commit will move part of the `Reactor` impl block to `Circuit`.
* tor-proto: Move cell handlers into a separate type (fmt).Gabriela Moldovan2025-02-251-3/+10
|
* tor-proto: Move cell handlers into a separate type.Gabriela Moldovan2025-02-252-44/+56
| | | | | I am moving these handlers into a separate type because they'll need to be shared with the active `Circuit`, for handling incoming cells.
* tor-proto: Add a reactor-internal Circuit type.Gabriela Moldovan2025-02-251-0/+38
| | | | | | | | | This represents a circuit "leg", in the conflux sense. The `Circuit` type will be a helper for implementing tunnel reactors that contain multiple `Circuit`s forming a conflux set. The fields from `Circuit` were extracted from the `Reactor` struct. A future commit will part of the `Reactor` implementation to `Circuit`.
* tor-proto: add variants to `HopLocation` behind `conflux` featureSteven Engler2025-02-241-0/+1
|
* tor-proto: Add a tunnel module.David Goulet2025-02-2014-0/+6647
Move StreamTarget to the tunnel module and the circuit module. From now on streams will be implemented on tunnels, not circuits. This moves `StreamTarget` to the tunnel module. A future change will replace `ClientCirc` with `ClientTunnel` inside `StreamTarget`. This is mostly code motion, best reviewed with `--color-moved`. Signed-off-by: David Goulet <[email protected]>