aboutsummaryrefslogtreecommitdiff
path: root/crates/tor-persist/src
Commit message (Collapse)AuthorAgeFilesLines
...
* | tor-persist: Error: Provide for handling BadSlugIan Jackson2024-01-311-1/+24
| | | | | | | | | | | | | | Introduce a Bug variant. Then, use it for conversions from BadSlug. See the comment for why I think this is appropriate.
* | tor-persist: state_dir: Two API fixesIan Jackson2024-01-311-2/+2
| | | | | | | | | | | | | | | | You don't need to consume a Mistrust to get a CheckedDir - you use a Verifier and then something clones it for you. So StateDirectory::new should take &Mistrust. And instance_peek_storage needs T to be deserialisable!
* | tor-persist: state_dir: Rename InstanceStateHandle::purge (from delete)Ian Jackson2024-01-311-2/+2
| | | | | | | | | | This is rather more serious than many deletions - it wipes out the whole directory. And this name goes better with purge_instances.
* | tor-persist: state_dir: Enable rustfmtIan Jackson2024-01-311-1/+0
| | | | | | | | The formatting will be normalised roughly as we go.
* | tor-persist: load_store: Add some tracingIan Jackson2024-01-311-3/+18
| | | | | | | | Now we get log messages about what we're reading/writing.
* | tor-persist: Fix a doc commentIan Jackson2024-01-311-1/+1
|/
* tor-persist: Document that slugs cannot start with '-'.Gabriela Moldovan2024-01-311-1/+1
|
* tor-persist: Make all Slugs non-empty.Gabriela Moldovan2024-01-311-10/+13
| | | | | | | | This also removes a TODO regarding adding a `Nickname` type for representing `HsClientSpecifier` and `HsNickname` (we don't need it if `Slug`s are non-empty). Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1931#note_2990227
* tor-persist: Forbid slugs from starting with a hyphen.Gabriela Moldovan2024-01-311-1/+21
|
* tor_persist::slug: Allow hyphens in Slugs.Gabriela Moldovan2024-01-311-2/+3
| | | | | | | | The internal representation of `HsNickname` will soon be `Slug`, and nicknames can contain hyphens, so let's add `-` to the allowed charset. Part of #1092
* slug: Provide BadSlug::EmptySlugNotAllowedIan Jackson2024-01-291-0/+12
|
* Merge branch 'slug2' into 'main'Ian Jackson2024-01-252-94/+62
|\ | | | | | | | | TryIntoSlug See merge request tpo/core/arti!1922
| * state_dir: Remove a now-unused allowIan Jackson2024-01-251-1/+0
| |
| * state_dir: Replace InstanceIdString with Slug and SlugRefIan Jackson2024-01-251-44/+14
| | | | | | | | And tidy up some of the docs to refer to the slug module.
| * state_dir: Abolish now-obsolete Slug trait renameIan Jackson2024-01-251-5/+3
| |
| * slugs: Provide TryIntoSlug, and replace state_dir::Slug with itIan Jackson2024-01-252-47/+48
| |
* | Merge branch 'slug4' into 'main'gabi-2502024-01-251-0/+5
|\ \ | | | | | | | | | | | | slug: Implement the AsRefs for Slug as well as for SlugRef See merge request tpo/core/arti!1929
| * | slug: Implement the AsRefs for Slug as well as for SlugRefIan Jackson2024-01-251-0/+5
| |/ | | | | | | | | Otherwise you can't use &Slug where someone wants &impl AsRef<Path>, which is rather sad.
* / slug: Fix maint/check_doc_featuresIan Jackson2024-01-251-0/+2
|/
* tor_persist::slug: Abolish ForbiddenOnWindows on non-WindowsIan Jackson2024-01-251-21/+9
| | | | | | | | | Abolish it, sprinkling cfg all over, rather than having it be uninhabited. See https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1912#note_2988746 https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1912#note_2988748
* Introduce tor_persist::slug moduleIan Jackson2024-01-252-0/+397
| | | | | | | | | I need this for state_dir (#1163, !1853). I intend that this should be used for arti paths (#1092, #1193). See also #1195. Implements the spec in #1192 but doesn't connect it to anything yet.
* tor-persist: load_store: More documentationIan Jackson2024-01-241-3/+29
|
* Fix doc comments.Nick Mathewson2024-01-242-2/+2
|
* tor-persist: state_dir: Implement the StorageHandle methodsIan Jackson2024-01-241-6/+36
| | | | | You can't call these yet and there aren't any tests. But this demonstrates use of the previous refactoring.
* tor-persist: state_dir: (intend to) use tor_persist::ErrorIan Jackson2024-01-241-16/+4
|
* tor-persist: have load_store module provide deletionIan Jackson2024-01-242-0/+10
|
* tor-persist: Provide load_store module for use by state_dirIan Jackson2024-01-243-22/+58
|
* tor-persist: Use correct pathnames in errorsIan Jackson2024-01-241-5/+8
| | | | | | | | | | | | Before this, we would say the problem happened while accessing Resource::File { container: "STATE_DIR", file: "KEY.json", } which would imply that we failed to access "STATE_DIR/KEY.json". But that's not true: we *actually* access "STATE_DIR/state/KEY.json".
* state-dir: Use a real lock guardIan Jackson2024-01-241-3/+4
| | | | | Bring in the fslock-guard crate and replace the Void in the structs. (Separated out since this contains Cargo.lock churn.)
* state-dir: Move from tor-hsservice to tor-persistIan Jackson2024-01-242-0/+581
| | | | | | | | | | And, instead of being a hidden module, it's a public experimental one. I have feature-gated all the new dependencies since we probably want to feature-gate this module in perpetuity, since some builds of Arti won't need it. Closes #1205
* tor-keymgr: Use keystore_error_kind() to get the error kind.Gabriela Moldovan2024-01-151-1/+1
| | | | Closes #1215
* todos: Reference a new ticket about errorkindsIan Jackson2024-01-111-1/+1
|
* tor-persist: Provide FsMistrustErrorExt, and use itIan Jackson2023-12-133-5/+63
| | | | | | | | | | | | | This code needs fs_mistrust::Error and tor_error::ErrorKind. I think we probably don't want fs_mistrust to depend on tor_error or vice versa. tor_persist is approximately the place where these two threads of thought come together, and it's currently the lowest place where this is needed. Use it in tor-dirmgr too, which is currently the other place that embodies this knowledge about fs_mistrust::Error.
* tor-persist: Make LockStatus #[must_use]Ian Jackson2023-11-221-0/+1
| | | | | I see other problems with this API, see #1136. but we can at least easily do this.
* Run maint/add_warning to add lint block everywhereIan Jackson2023-08-233-0/+3
|
* Run add_warnings on all files.Nick Mathewson2023-08-041-2/+2
|
* Run maint/add_warning to actually apply new lint allowsIan Jackson2023-07-104-0/+4
|
* Throughout: Use *_report!() macros for reporting Errors.Nick Mathewson2023-07-072-14/+10
| | | | | | | | | | | | | | | I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949.
* Run add_warning to remove `missing_panics_doc` deny.Nick Mathewson2023-07-061-1/+0
| | | | Closes #950.
* lints: Run maint/add_warning to actually apply new lintsIan Jackson2023-06-211-0/+2
|
* Merge branch 'shadykaty-error-hint-v2' into 'main'eta2023-02-071-1/+1
|\ | | | | | | | | | | | | Create and use an ErrorHint type to report how to fix a problem. Closes #579 and #578 See merge request tpo/core/arti!994
| * ErrorHint: Implement tryfrom_torpersistNick Mathewson2023-01-271-1/+1
| |
* | Use ErrorReport - run rustfmtIan Jackson2023-01-301-1/+5
| | | | | | | | Split off for ease of review and possible rebase.
* | Use ErrorReport for errors in warn! in tor-persistIan Jackson2023-01-302-3/+5
|/
* Allow clippy::unchecked_duration_subtraction in testsNick Mathewson2023-01-273-0/+3
| | | | | This panics on error, and we're fine with a panic on misbehavior in tests.
* Disable clippy::unlinlined-format-argsNick Mathewson2023-01-271-0/+1
| | | | | | | | This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748.
* test lint blocks: Add many many automaticallyIan Jackson2022-12-123-0/+24
| | | | | This is precisely the result of running the rune in maint/adhoc-add-lint-blocks.
* Test a couple more error cases in tor-persist.Nick Mathewson2022-12-062-8/+29
|
* Fix a bunch of "needless borrow" warnings on nightlyNick Mathewson2022-11-182-5/+5
| | | | | It looks like, despite a few false starts, they've got this warning right; there weren't any false positives.
* tor-persist: use map_whileNick Mathewson2022-11-101-4/+1
| | | | It was introduced in Rust 1.57.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 20:38:01 +0000