summaryrefslogtreecommitdiff
path: root/crates/tor-persist/src
Commit message (Collapse)AuthorAgeFilesLines
* tor-persist: Resource::Temporary: Mark with cfgIan Jackson2022-07-181-0/+1
| | | | Without this, some builds get a "variant is never constructed" warning.
* tor-persist: StateMgr: vagueify docs about NoLock errorIan Jackson2022-07-121-1/+1
| | | | `NoLock` is now a variant of `err::ErrorSource` but that is private.
* tor-persist: Big refactoring on Error type.Nick Mathewson2022-07-063-51/+209
| | | | | | | | | | | Every error now has an action (what we were trying to do), a resource (what we were trying to do it to), and a source (what problem we encountered). Initially I tried to add "action" and "resource" fields to error variants individually, but that led to a combinatorial explosion. Part of #323.
* tor-persist: Move Error to a module.Nick Mathewson2022-07-064-75/+80
|
* Run maint/add_warning crates/*/src/{lib,main}.rsIan Jackson2022-06-231-0/+3
| | | | Update all lint blocks
* fs-mistrust: convert Io error variant to a struct.Nick Mathewson2022-06-221-1/+1
|
* Editorial improvements on fs-mistrust errorsNick Mathewson2022-06-221-1/+1
| | | | | | These changes make sure that the errors conform to our preferred style, and include a description of what exactly we were doing when something went wrong.
* Fix clippy::significant_drop_in_scrutinee warningsNick Mathewson2022-06-151-1/+2
| | | | | | | | | This is apparently a new warning from clippy nightly, documented in https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_in_scrutinee . I'm not in love with the temporary variables that this warning wants me to introduce, but it does seem like a decent way to avoid some kinds of deadlock.
* lints: Add let_unit_value allow to all cratesIan Jackson2022-05-311-0/+1
| | | | | From running add_warning, with manual picking of the right hunks/lines.
* lints: Add lint block delimiters to every crateIan Jackson2022-05-311-0/+2
| | | | | | This was the result of: maint/add_warning crates/*/src/{lib,main}.rs and then manually curating the results.
* Remove some stray dbg!() calls.Nick Mathewson2022-05-261-2/+1
|
* Test a few more corner cases in tor-persistNick Mathewson2022-05-252-4/+111
| | | | | Also, if we get an IoError from a call to fs-mistrust, report it as an IoError.
* fs-mistrust: make Mistrust have a corresponding Builder type.Nick Mathewson2022-05-241-1/+1
| | | | | This is an approximately minimal revision to get Builder in place; subsequent commits will clean up the API.
* tor-persist: Use fs-mistrust to verify state file permissions.Nick Mathewson2022-05-092-35/+50
|
* serde attributes: A tiny bit of reorderingIan Jackson2022-05-051-1/+1
| | | | Having a consistent order will make the nest commit easier to read.
* Fix build with Rust 1.53; we can't use map_whileNick Mathewson2022-04-141-1/+4
|
* tor-persist::fs::clean: Log warnings for directory read failuresIan Jackson2022-04-141-1/+19
|
* tor-persist::fs::clean: Tweaks based on review.Nick Mathewson2022-04-132-22/+34
| | | | | | | | | | | | Rename "deletable" to "obsolete". Simplify function structure. Report errors from `metadata()` and `modified()`. Don't claim that we're going to delete something unless we are. Comment about making CUTOFF configurable.
* Remove obsolete files from our state directory.Nick Mathewson2022-04-122-0/+138
| | | | | | | This patch removes files created by older versions of arti, if they are at least 4 weeks old. Closes #282
* Merge branch 'clippy-allow-arc-clone' into 'main'Nick Mathewson2022-03-011-1/+0
|\ | | | | | | | | Disable clippy::clone_on_ref_ptr See merge request tpo/core/arti!352
| * Disable clippy::clone_on_ref_ptrIan Jackson2022-02-241-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lint is IMO inherently ill-conceived. I have looked for the reasons why this might be thought to be a good idea and there were basically two (and they are sort of contradictory): I. "Calling ‘.clone()` on an Rc, Arc, or Weak can obscure the fact that only the pointer is being cloned, not the underlying data." This is the wording from https://rust-lang.github.io/rust-clippy/v0.0.212/#clone_on_ref_ptr It is a bit terse; we are left to infer why it is a bad idea to obscure this fact. It seems to me that if it is bad to obscure some fact, that must be because the fact is a hazard. But why would it be a hazard to not copy the underlying data ? In other languages, faliing to copy the underlying data is a serious correctness hazard. There is a whose class of bugs where things were not copied, and then mutated and/or reused in multiple places in ways that were not what the programmer intended. In my experience, this is a very common bug when writing Python and Javascript. I'm told it's common in golang too. But in Rust this bug is much much harder to write. The data inside an Arc is immutable. To have this bug you'd have use interior mutability - ie mess around with Mutex or RefCell. That provides a good barrier to these kind of accidents. II. "The reason for writing Rc::clone and Arc::clone [is] to make it clear that only the pointer is being cloned, as opposed to the underlying data. The former is always fast, while the latter can be very expensive depending on what is being cloned." This is the reasoning found here https://github.com/rust-lang/rust-clippy/issues/2048 This is saying that *not* using Arc::clone is hazardous. Specifically, that a deep clone is a performance hazard. But for this argument, the lint is precisely backwards. It's linting the "good" case and asking for it to be written in a more explicit way; while the supposedly bad case can be written conveniently. Also, many objects (in our codebase, and in all the libraries we use) that are Clone are in fact simply handles. They contain Arc(s) (or similar) and are cheap to clone. Indeed, that is the usual case. It does not make sense to distinguish in the syntax we use to clone such a handle, whether the handle is a transparent Arc, or an opaque struct containing one or more other handles. Forcing Arc::clone to be written as such makes for code churn when a type is changed from Arc<Something> to Something: Clone, or vice versa.
* | arti-client: Unlock the state manager on failure to bootstrapeta2022-02-243-5/+33
|/ | | | | | | | | | | | `StateMgr` got a new `unlock()` method that does what it says on the tin. We now call it from `bootstrap()` using the new `util::StateMgrUnlockGuard`, which works in a manner similar to the `BoolResetter` from `tor_dirmgr`. (A decent small little task in future might be to unify these types in some sort of general arti utility crate?) closes arti#335
* Merge remote-tracking branch 'origin/mr/340'Nick Mathewson2022-02-231-1/+1
|\
| * Make NoLock into BadApiUsage.Nick Mathewson2022-02-221-1/+1
| | | | | | | | | | | | To implement this, we had to refactor the tor_circmgr api for flushing state changes to disk, so that it checks if it has the lock, and only then tries to store.
* | Remove clippy::needless_borrow exception in CI.Nick Mathewson2022-02-201-1/+0
|/ | | | | This exception is no longer necessary now that the underlying CI bug is fixed.
* Change deny(clippy::all) to warn(clippy::all).Nick Mathewson2022-02-141-1/+1
| | | | Closes #338.
* errors: Drop "Error" and "Failed" from various enum variantsIan Jackson2022-02-041-1/+1
|
* tor_persist::Error: impl HasKind and adjust commentsIan Jackson2022-02-041-1/+24
| | | | | And change the comments to slightly reinterpret these errors, to relate to the circumstances rather than error generation site.
* tor-persist: Distinguish load vs. store json errorsIan Jackson2022-02-043-10/+20
| | | | | | | | Serialisation errors ought not to occur, since they would represent an attempt to store malformed data, or something. (We always convert to a string, so the JSON error never contains IO errors or the like.) Deserialisation errors mean the persistent state is corrupt.
* Temporarily disable some clippy lints on nightlyIan Jackson2022-02-021-0/+1
|
* clippy: Pass simply &output to fs::writeIan Jackson2022-02-021-1/+1
| | | | | | clippy::needless_borrow quibbles here, IMO correctly. Its suggestion didn't go far enough: output is a String and a &String can be passed to write as-is for identical effect.
* extend lints to include 'clippy::all'Daniel Eades2021-12-281-0/+1
|
* address clippy's latest lintDaniel Eades2021-12-201-0/+1
|
* Fix Rustdoc errors.Nick Mathewson2021-12-081-1/+1
|
* Test FsStateMgr::path(), and fix a bug in it.Nick Mathewson2021-12-071-1/+8
| | | | | We join "state" to the directory name, so we must call parent() to get the original.
* Sketch API for reconfiguration.Nick Mathewson2021-12-071-0/+4
| | | | | | | This patch doesn't actually make anything reconfigurable, but it does create an API that will tell you "you can't change the value of that!" If the API looks reasonable, I can start making it possible to change the values of individual items.
* add semicolons if nothing returnedDaniel Eades2021-11-251-0/+1
|
* Fix a few typos.Nick Mathewson2021-11-241-1/+1
| | | | Also fix some commonwealth spellings that had slipped in.
* Change how TestingStateMgr handles locking.Nick Mathewson2021-11-031-43/+80
| | | | | | Previously it was either all-locked or all-not-locked. Now you can simulate having the same shared storage opened by multiple managers, only one of which has the lock.
* Upgrade to fslock version 0.2Nick Mathewson2021-10-271-1/+1
| | | | | This version makes all locks per-handle rather than per-process, by moving from lockf() to flock() on unix.
* Add Futureproof<T> wrapper type, use for GuardDisabled enumeta2021-10-272-1/+73
| | | | | | | | | | | The Futureproof<T> type lets you serialize and deserialize types whose representations might change (most useful for enums that might grow additional variants). It uses #[serde(untagged)] to accomplish this. This gets used in order to make the `disabled` field of `Guard` more robust against future guard disablement reasons being added. A test was also added to verify correct behaviour of the new type.
* Add #[serde(flatten)] HashMap fields to serializable objectseta2021-10-271-0/+1
| | | | | | | | | | As per arti#175, we'd like to be able to handle newer Arti versions storing additional state in the persisted state files, without dropping this data on the floor when we write out changes to these files. Use the #[serde(flatten)] mechanism to achieve this, by adding catch-all HashMap<String, JsonValue> fields to all structs that are at risk of this happening to them.
* Remove try_lock from StorageHandle.Nick Mathewson2021-10-202-8/+2
|
* Replace the return type of StorageMgr::try_lock with a tristateNick Mathewson2021-10-204-18/+45
| | | | | It's useful to know now only if we now have the lock, but also if we just got it for the first time.
* Add a GuardMgr member to CircuitBuilderNick Mathewson2021-10-101-1/+1
|
* enable checked_conversions lint.Nick Mathewson2021-10-091-0/+1
|
* Fix some typos (via the "typos" tool)Nick Mathewson2021-10-081-2/+2
|
* Change tor-persist to use json instead of toml.Nick Mathewson2021-10-073-19/+21
| | | | | | The limitations with toml seemed to be reaching a head, and I wasn't able to refactor the guardmgr code enough to actually have its state be serializable as toml. Json's limitations are much narrower.
* Allow building tor-persist for WASMJani Monoses2021-10-011-0/+2
|
* Clarify why we use a dyn pointer for StorageHandle.Nick Mathewson2021-09-301-1/+7
|
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 02:05:55 +0000