| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
We're about to make UnverifiedAuthCert::verify return a
TimerangeBound, not an AuthCert.
For the success cases, declare the expected return type.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Lint for clippy::string_slice
See merge request tpo/core/arti!4086
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This commit adds #[allow(clippy::string_slice)] to all functions in the
code where string slices are used, alongside a TODO comment.
We do this add the function header to have it consistent, as things like
expression based allow's are still experimental.
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
All of the pieces are in place for this now.
Some of the pieces are not entirely complete or correct at this point:
that's sorted out by other MRs already open.
Currently there is no encoding, no verification functdion, and no
tests. Encoding depends on another oustanding MR (arti!4058).
Verification depends on the rework in arti!4065.
Tests are still to come.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
netdoc: Add fuzzing support for parse2 with authcert, mds
See merge request tpo/core/arti!4068
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Bump derive-deftly to 1.11.3 to get $impl
See merge request tpo/core/arti!4083
|
| | | |/ /
| |/| |
| | | |
| | | | |
New beta semver policy means we should pin the patchlevel.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
The actual item field isn't in the struct yet, because that would
produce conflicts with other outstanding work in this same struct.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
This will let us encode consensus signatures sections.
|
| | | | |
| | | |
| | | |
| | | | |
This defines ordering of routerstatus items.
|
| | | | | |
|
| |/ / /
| | |
| | |
| | |
| | |
| | | |
This is a nontrivial type with much weirdness to do with publication
times etc., so let's mark this as incomplete until we have a round
trip test.
|
| | | |
| | |
| | |
| | | |
We must reject unknown objects unless noted otherwise.
|
| | | |
| | |
| | |
| | | |
No functional change.
|
| | | |
| | |
| | |
| | |
| | | |
Changes ItemPresent to accept but ignore additional arguments and/or an
object.
|
| | | |
| | |
| | |
| | | |
Adds the actual keyword for a present object to the test.
|
| | | |
| | |
| | |
| | |
| | | |
This commit adds a test for ItemPresent in terms of encoding and
decoding.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit adds the ItemPresent type, which is intended for token types
where the mere presence implies a truthful value, such as
`tunnelled-dir-server`.
For now, it lives in `ignored_impls` because it does in fact ignore
(actually rejects) everything around the item except the keyword.
The type implements ItemValueParseable and ItemValueEncodable; both
implementations being very minimal and only parsing/emitting the
keyword.
A test will be added within the next commit.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit documents a shortcoming explained on IRC that exists with
the current derive(Transparent) and generic types that are uncovered.
See E0210.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-netdoc: minor fixes arising from netstatus work
See merge request tpo/core/arti!4055
|
| | | | |
| | | |
| | | |
| | | | |
This matches C Tor and the spec.
|
| | | | |
| | | |
| | | |
| | | | |
We need to use `-`, not `_`. So use concat! stringify!.
|
| | | | |
| | | |
| | | |
| | | | |
Now it round-trips.
|
| | | |/
| |/| |
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
tor-netdoc: ParseInput: improve
See merge request tpo/core/arti!4057
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
This makes the code clearer, especially since we're going to add
attributes.
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | | |
tor-netdoc: Avoid use of string slices in PortPolicy
See merge request tpo/core/arti!4062
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit adds a tor-netdoc test for checking for an edge case related
to UTF-8 symbols found within netdocs.
See arti#2566
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit removes the use of string slices in PortPolicy::from_str()
by making use of `str::split_once` instead.
See arti#2566
Co-authored-by: 5225225 <[email protected]>
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
tor-netdoc: No longer import crate::Result in doc::netstatus
See merge request tpo/core/arti!4050
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
This is a clearer.
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
Bump some deps that have had breaking changes
See merge request tpo/core/arti!4053
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
It is weird to have three possible states for truthiness here.
This commit removes the Option in favor of the inner type while adding a
TODO comment to somehow find a way to skip this during encoding.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Adds a TODO for using ConstantString for overload_general.
|
| | | |
| | |
| | |
| | | |
This field is taken from the spec.
|
| | | |
| | |
| | |
| | | |
This commit adds the contact field to RouterDesc.
|
| | | |
| | |
| | |
| | | |
This commit adds support for the overload-general field to RouterDesc.
|