| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | tor-netdoc: authcert: Rename verify_selfcert to verify_self_signed | Ian Jackson | 2026-01-06 | 1 | -14/+14 | |
| | | | | | | | The distinction is: `verify_selfcert` sounds like it only verifies the self certificate. `veriify_self_signed` completely verifies a document, albeit one that is expected to be self-signed. | |||||
| * | tor-netdoc: authcert: Move AuthCertVersion out of tmp | Ian Jackson | 2026-01-06 | 2 | -20/+31 | |
| | | | | | | Let's keep the existing name `AuthCert` in authcert.rs, so we want to rename this from DirKeyCertificateVersion, while we move it. | |||||
| * | tor-netdoc: authcert: Make all fields pub | Ian Jackson | 2026-01-06 | 1 | -7/+7 | |
| | | | | | This is our new style. Now there's no known-dead code. | |||||
| * | tor-netdoc: authcert: Use Iso8601TimeSp for time fields | Ian Jackson | 2026-01-06 | 2 | -11/+11 | |
| | | | | | This will let the parse2 derive work properly. | |||||
| * | tor-netdoc: authcert: Shuffle fingerprint values about | Ian Jackson | 2026-01-06 | 2 | -19/+11 | |
| | | | | | | | | | | Make AuthCert look like the network document. This means removing its stored copy of H(KP_auth_sign_rsa), which it previously had via the embedded AuthCertKeyIds. We reculculate it as needed in AuthCert::key_ids(). | |||||
| * | tor-netdoc: authcert: Abolish AuthCert::sk_fingerprint | Ian Jackson | 2026-01-06 | 2 | -6/+2 | |
| | | | | | There are no in-tree callers. | |||||
| * | tor-netdoc: authcert: Make key_ids return owned AuthCertKeyIds | Ian Jackson | 2026-01-06 | 3 | -5/+6 | |
| | | | | | | AuthCert is about to lose its copy of H(KP_auth_sign_rsa) so it needs to return an owned value. | |||||
| * | tor-netdoc: RSA: check exponent and min size in parse2 | Ian Jackson | 2026-01-06 | 2 | -1/+24 | |
| | | | | | | | | | | | | | | | | According to the spec we always use this fixed exponent, and we have a minimum size of 1024. This is checked adhoc in the old parser with some slight assistance from what is now `RsaPublicParse1Helper`. It's not clear to me that checking the exponent is actually a good idea. I think checking the size is probably a bad idea, and if it is a good idea then 1024 is clearly too short. But rather than revisit these questions, let's reproduce the old behaviour in parse2. In parse2 these checks should be features of the type. | |||||
| * | tor-netdoc: RSA: rename helper type to RsaPublicParse1Helper | Ian Jackson | 2026-01-06 | 4 | -15/+18 | |
| | | | | | | | This is used by the old parsing code, apparently as a thing to hang the checking methods off. It is confusing to have so many different RSA types! Let's at least rename this one. | |||||
| * | tor-netdoc: authcert: Improve docs a bit | Ian Jackson | 2026-01-06 | 1 | -5/+12 | |
| | | | | | Spec links from the tmp module will be added later. | |||||
| * | tor-netdoc: authcert: Rename fields in AuthCert to match the spec | Ian Jackson | 2026-01-06 | 2 | -39/+39 | |
| | | ||||||
| * | tor-netdoc: authcert: Reorder fields in AuthCert to match the spec | Ian Jackson | 2026-01-06 | 1 | -4/+4 | |
| | | ||||||
| * | tor-netdoc: parse_netdoc_multiple_with_offsets: Add comment about offsets | Ian Jackson | 2025-12-18 | 1 | -0/+5 | |
| | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3554#note_3313768 | |||||
| * | tor-netdoc: test2: Make t_ok (which takes no boundaries) take &D not &[D] | Ian Jackson | 2025-12-18 | 1 | -16/+16 | |
| | | ||||||
| * | tor-netdoc: test2: Test parse_netdoc_multiple_with_offsets | Ian Jackson | 2025-12-18 | 1 | -2/+25 | |
| | | | | | | | * Make a fancy version of t_ok, t_ok_multi, that takes the expected boundary byte offsets. * t_ok is now just for single-document files and is implemented in terms of t_ok_multi. * Use t_ok_multi for the one test case with multiple documents. | |||||
| * | tor-netdoc: test2: Add a test file with more than one document | Ian Jackson | 2025-12-18 | 1 | -0/+17 | |
| | | ||||||
| * | tor-netdoc: Provide parse2::parse_netdoc_multiple_with_offsets | Ian Jackson | 2025-12-18 | 2 | -0/+22 | |
| | | ||||||
| * | tor-netdoc: Break out and expose ItemStream::byte_position | Ian Jackson | 2025-12-18 | 2 | -3/+11 | |
| | | ||||||
| * | tor-netdoc: Fix doc comment for parse_netdoc_multiple | Ian Jackson | 2025-12-18 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc: netstatus preamble: Reorder fields to match spec order | Ian Jackson | 2025-12-18 | 1 | -21/+21 | |
| | | | | | | As suggested here https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3550#note_3313757 | |||||
| * | tor-netdoc: netstatus preamble: Add a lot of blank lines | Ian Jackson | 2025-12-18 | 1 | -0/+11 | |
| | | | | | | I'm going to reorder things and this will make that much less error-prone, at least for me. | |||||
| * | tor-netdoc: netstatus preamble: Clarify TODO for known-flags | Ian Jackson | 2025-12-18 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc: netstatus: improve TODO comments | Ian Jackson | 2025-12-18 | 1 | -1/+10 | |
| | | | | | | | | | This is the result of reading through the spec and comparing it to the struct. Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3550#note_3312672 | |||||
| * | tor-netdoc: Clarify the wrong field bug example | Ian Jackson | 2025-12-18 | 1 | -1/+4 | |
| | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3550#note_3312670 | |||||
| * | tor-netdoc: Fix typo in comment | Ian Jackson | 2025-12-18 | 1 | -1/+1 | |
| | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3550#note_3312669 | |||||
| * | tor-netdoc: rustfmt | Ian Jackson | 2025-12-18 | 1 | -2/+1 | |
| | | ||||||
| * | tor-netdoc: Preamble: Parse published in votes | Ian Jackson | 2025-12-18 | 3 | -0/+5 | |
| | | ||||||
| * | tor-netdoc: Preamble: Parse consensus-methods in votes | Ian Jackson | 2025-12-18 | 4 | -1/+5 | |
| | | ||||||
| * | tor-netdoc: Preamble: Fix consensus-method parsing in votes | Ian Jackson | 2025-12-18 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc: impl NetdocParseableFields for Preamble | Ian Jackson | 2025-12-18 | 1 | -0/+12 | |
| | | ||||||
| * | tor-netdoc: impl ItemValueParseable for NetParams<i32> | Ian Jackson | 2025-12-18 | 1 | -1/+11 | |
| | | ||||||
| * | tor-netdoc: impl NetdocParseableFields for ProtoStatuses | Ian Jackson | 2025-12-18 | 1 | -1/+63 | |
| | | ||||||
| * | tor-netdoc: Use $P for prelude in one place | Ian Jackson | 2025-12-18 | 2 | -2/+2 | |
| | | | | | This was missed, apparently. | |||||
| * | tor-netdoc encode: Fix typos in multiplicity check method docs | Ian Jackson | 2025-12-10 | 1 | -4/+4 | |
| | | ||||||
| * | tor-netdoc encode: Enhance explanation of DeterminedMultiplicitySelector | Ian Jackson | 2025-12-10 | 1 | -0/+3 | |
| | | ||||||
| * | tor-netdoc encode multiplicity: Fix wrong trait ref | Ian Jackson | 2025-12-10 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc encode multiplicity: Add a note about omission of intro items | Ian Jackson | 2025-12-10 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc Linkify three more types | Ian Jackson | 2025-12-10 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc Fix docs typo | Ian Jackson | 2025-12-10 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc: Add two TODOs re trait naming | Ian Jackson | 2025-12-10 | 2 | -0/+4 | |
| | | ||||||
| * | tor-netdoc README: Overview of the traits | Ian Jackson | 2025-12-10 | 1 | -0/+38 | |
| | | ||||||
| * | tor-netdoc README: Replace structure section | Ian Jackson | 2025-12-10 | 1 | -8/+11 | |
| | | ||||||
| * | tor-netdoc README: fix description overview | Ian Jackson | 2025-12-10 | 1 | -4/+3 | |
| | | ||||||
| * | tor-netdoc README: fix spec ref | Ian Jackson | 2025-12-10 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc README: fix terminology | Ian Jackson | 2025-12-10 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc: semver.md: Document new facilities | Ian Jackson | 2025-12-10 | 1 | -0/+1 | |
| | | ||||||
| * | tor-netdoc: Apply encoding derive to SharedRandStatus | Ian Jackson | 2025-12-10 | 1 | -2/+3 | |
| | | | | | | | | | I feel that before merging all this, I ought at least to demonstrate that it can be applied to at least one real type! We can unconditionally `#[derive(Deftly)]`. That is simpler, and harmless if no actual deftly derives are applied. | |||||
| * | tor-netdoc: test2: check round-trip encoding | Ian Jackson | 2025-12-10 | 1 | -29/+162 | |
| | | | | | | | | | | | | | | The test case documents are often not in canonical form. We don't want to change them to be in canonical form because we want to test parsing edge cases. So, we provide a mangling scheme with in-document notes, and annotate all the documents. Apply suitable annotations to all the documents. Test that the encoded forms are as expected. This reverts commit 05e7b8b60061a7e8a8d004a822cc213d3ea22d47. | |||||
| * | tor-netdoc: test2: implement encoding traits for all test types | Ian Jackson | 2025-12-10 | 2 | -20/+59 | |
| | | | | | | | | Make this whole module conditional on the encode feature. Apply the derives. Provide the necessary manual implementations for the types where we use `with`. | |||||
| * | tor-netdoc: derive netdoc encoding traits | Ian Jackson | 2025-12-10 | 4 | -0/+487 | |
| | | | | | | Signature encoding is not yet supported. We need to consider how this will work. | |||||
