aboutsummaryrefslogtreecommitdiff
path: root/crates/tor-netdoc
Commit message (Collapse)AuthorAgeFilesLines
...
| * | tor-netdoc: Fix handling of explicit vs implicit dir sig SHA1 hashIan Jackson2026-04-291-6/+2
| | | | | | | | | | | | | | | Now that everything is prepared, we can add the sha1_unnamed field in the hash accumulator.
| * | tor-netdoc: Fix signature of hash_slice_for_verificationIan Jackson2026-04-292-14/+10
| | | | | | | | | | | | | | | | | | | | | In order to handle marked vs unmarked SHA1 correctly, it needs the original DigestAlgoInSignature. The only call site is in poc's verification code.
| * | tor-netdoc: Fix signature of hash_slice_for_verification (pre-fmt)Ian Jackson2026-04-291-1/+4
| | |
| * | tor-netdoc: Abolish poc's netstatus signature typeIan Jackson2026-04-292-159/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use prod's Signature instead. This gets rid of: * The old parsing code. We have a new approach based on ItemValueParseable, KeywordOrString and and DigestAlgoInSignature. * The duplicate DirectorySignaturesHashesAccu and its temporary conversions. poc's verify_timeless function needs a little adjustment for the new struct layout.
| * | tor-netdoc: Promote hash_slice_for_verification to prodIan Jackson2026-04-292-13/+13
| | | | | | | | | | | | | | | | | | This function is not right, yet. We're going to fix it later. Review with --color-moved.
| * | tor-netdoc: impl SignatureItemParseable for netstatus::SignatureIan Jackson2026-04-291-1/+14
| | | | | | | | | | | | | | | This is now pretty straightforward. The functions it calls need some work - we have blocking TODOs for that.
| * | tor-netdoc: Introduce DirectorySignaturesHashesAccu::update_fromIan Jackson2026-04-292-16/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This now contains the hashing code that was in poc. In poc it was entangled with the signature type, mostly because once upon a time the hash was inside the signature. In the real code we can make it a standalone method. It takes DigestAlgoInSignature so that it will be able to handle the explicit vs implicit sha1 anomaly correctly - but it can't do that yet because the necessary field doesn't exist yet. Also, we are going to want to make it a bit lazier - preserve the MR-blocking todo for that. A handful of lines are being actually moved verbatim, so --color-moved may help a bit.
| * | tor-netdoc: Promote poc's DirectorySignaturesHashesAccu to prodIan Jackson2026-04-292-29/+41
| | | | | | | | | | | | | | | | | | | | | There are definitely some things wrong with this, but they all have MR-blocking TODOs so we can promote this type now. Largely code motion. Review with --color-moved.
| * | tor-netdoc: Make some items temporarily pub(crate)Ian Jackson2026-04-291-2/+4
| | |
| * | tor-netdoc: Temporary conversions between the two DirectorySignatureHashAlgosIan Jackson2026-04-291-0/+20
| | | | | | | | | | | | | | | | | | Because we have two DirectorySignatureHashAlgo types because of the macrology problem, we need to introduce temporary conversions, to let us move code from poc to prod.
| * | tor-netdoc: netstatus signature hashing: Add TODO re wasted workIan Jackson2026-04-291-0/+1
| | |
| * | tor-netdoc: netstatus signature hashing: Add TODO re unnamed sha1Ian Jackson2026-04-291-0/+16
| | | | | | | | | | | | | | | We're going to fix this in this branch, as part of promoting the poc code to prod.
| * | tor-netdoc: netstatus signing algorithms: Improve a doc commentIan Jackson2026-04-291-1/+1
| | | | | | | | | | | | There isn't a "this" here; self is DirectorySignaturesHashesAccu.
| * | tor-netdoc: derive ItemValue parsing/encoding for SignatureIan Jackson2026-04-292-4/+10
| | | | | | | | | | | | This doesn't let us do any verification or anything.
| * | tor-netdoc: impl parsing/encoding for AuthCertKeyIds in directory-signatureIan Jackson2026-04-291-1/+68
| | | | | | | | | | | | | | | This module will be used when we derive ItemValueParseable on Signature.
| * | tor-netdoc: Introduce DigestAlgoInSignature parsing/encoding typeIan Jackson2026-04-291-3/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And change the type of the field in Signature. We are going to abandon the almost completely manual parsing approach taken in poc's NdiDirectorySignature. That parsing approach was heavily influenced by poc's struct layout, which in turn was influenced by the way that previously, hashes were inside signatures. Instead we'll derive ItemValueParseable from Signature, and semi-manually implement the hash update. This type is the one that embodies the `directory-signature` item's parsing strangeness: the optional initial positional argument.
| * | tor-netdoc: Unify authcert test modules (fmt)Ian Jackson2026-04-291-313/+308
| | |
| * | tor-netdoc: Unify authcert test modulesIan Jackson2026-04-291-32/+18
| | | | | | | | | | | | | | | | | | | | | | | | Abolish the parse2_test and encode_test modules. These mostly existed because of cfg gates. Now, we can unify the test module namespace, and also remove an indentation level (that will come next, with rustfmt).
| * | tor-netdoc: derive Display for DirectorySignatureHashAlgoIan Jackson2026-04-291-1/+1
| | |
| * | tor-netdoc: netsatus: glob import from types, not types::miscIan Jackson2026-04-291-1/+1
| | | | | | | | | | | | | | | | | | This way we import via the public names, which is more sensible, and we include things that aren't in misc. The whole of types is pretty good as a glob import here.
| * | tor-netdoc: types.rs: Add a missing exportIan Jackson2026-04-291-0/+1
| | |
| * | tor-netdoc: parse2: Improve another error span for missing trait implIan Jackson2026-04-291-1/+1
| | |
| * | tor-netdoc: parse2: Add missing ItemObjectParseable to prelude (fmt)Ian Jackson2026-04-291-2/+2
| | |
| * | tor-netdoc: parse2: Add missing ItemObjectParseable to preludeIan Jackson2026-04-292-3/+1
| | | | | | | | | | | | And remove a then-unneeded import in a using module.
* | | Upgrade rand crates to 0.10.Wesley Aptekar-Cassels2026-05-128-22/+20
| |/ |/| | | | | | | | | | | | | | | | | | | When the circ-padding feature is enabled, we use maybenot, which does not yet support rand 0.10. In the meantime, enabling this feature pulls in rand 0.9. This is not ideal, but should be okay as a temporary situation. This also replaces the use of ReseedingRng (which was removed in 0.10) with the reseeding_rng crate. This is somewhat less performant, but it should be okay.
* | Merge branch 'nd-features-rm' into 'main'Clara Engler2026-05-123-39/+13
|\ \ | | | | | | | | | | | | tor-netdoc: Abolish some empty features, deprecate encode (which is empty), etc. See merge request tpo/core/arti!3972
| * | tor-netdoc: Document retain-unknown feature in READMEIan Jackson2026-05-122-2/+4
| | | | | | | | | | | | Part of #2492.
| * | tor-netdoc: Document hs-pow-full feature in READMEIan Jackson2026-05-122-1/+3
| | | | | | | | | | | | | | | | | | Move the docs from Cargo.toml to README, and expand them. Part of #2492.
| * | tor-netdoc: Deprecate encode featureIan Jackson2026-05-121-2/+3
| | | | | | | | | | | | | | | | | | | | | This feature is empty already. Part of #2492. We ought to wait a release now before we remove it completely.
| * | tor-netdoc: Abolish empty undocumented feature dangerous-expose-struct-fieldsIan Jackson2026-05-121-3/+0
| | | | | | | | | | | | This was all un-cfg-gated previously.
| * | tor-netdoc: Tidy Cargo.toml features section a bitIan Jackson2026-05-121-5/+0
| | | | | | | | | | | | | | | Remove some otiose and leftover docs ("Testing only" related to `hs-inner-docs`, now gone) and now-redundant blank lines.
| * | tor-netdoc: Document the `testing` featureIan Jackson2026-05-122-1/+3
| | | | | | | | | | | | | | | | | | | | | We don't need to say it doesn't adhere to semver since every release of tor-netdoc is uses a semver-breaking version. But we do need to say we don't take any care about compatibility.
| * | tor-netdoc: Abolish empty undocumented feature ns-voteIan Jackson2026-05-121-5/+1
| | | | | | | | | | | | | | | | | | | | | This was never documented. The relevant code is now part of "incomplete". Part of #2492.
| * | tor-netdoc: Abolish empty undocumented feature parse2Ian Jackson2026-05-121-5/+1
| | | | | | | | | | | | | | | | | | | | | This was never documented. The relevant code is now either unconditional, or part of "incomplete". Part of #2492.
| * | tor-netdoc: Abolish deprecated features plain-consensus, routerdescIan Jackson2026-05-123-18/+1
| | | | | | | | | | | | | | | | | | | | | | | | These were deprecated in the last release. Now we can remove them. Also remove ns_consensus which was never really documented. Part of #2492.
* | | tor-netdoc: Rename RouterDesc real items to their real nameClara Engler2026-05-122-19/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes the name of all (except accept/reject) real items in RouterDesc to their proper name as found in the spec. This is a breaking change and semver.md has been updated properly. In the instanciation of RouterDesc in the legacy parser, we now use a "weird" syntax of some fields using a different name throughout the code, but that is ok. Changing this would make the diff way larger at the risk of breaking things, especially because many variables such as identity_cert get shadowed countless times within the function, making it harder and error prone to change.
* | | tor-netdoc: Add fancy rustdoc to real RouterDesc itemsClara Engler2026-05-121-22/+64
| | |
* | | tor-netdoc: Reorder real RouterDesc itemsClara Engler2026-05-121-41/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit reorders the real RouterDesc items according to the spec. Unfortunately, the names of those are not real yet, meaning that verifying this is somewhat hard. Personally, I recommend to verify that this commit does not add/remove lines using --color-moved. The correct order is probably easier to verify with the next commit applied that adds nice rustdoc comments explaining to which fields in the spec the respective items belong. This is a bit of a chicken egg situation but if I would have added the nice rustdoc comments first, this diff would have been awful to review, because the hunks of reordering the nice rustdoc comments included are awful to review, so please bear with me for the next commit.
* | | tor-netdoc: Reorder RouterDesc into virtual and real itemsClara Engler2026-05-121-10/+26
| | | | | | | | | | | | | | | | | | | | | | | | This commit reorders the RouterDesc struct into virtual and real items, with real items being items that actually exist (although potentially under a different name) in router descriptors. Virtual items on the other hand do not exist this way in router descriptors and have to be removed at one point or another.
* | | tor-netdoc: Add spacing to RouterDescClara Engler2026-05-121-0/+19
| | | | | | | | | | | | Makes this much nicer to read.
* | | Merge branch 'combine-hex' into 'main'Clara Engler2026-05-121-11/+11
|\ \ \ | |/ / |/| | | | | | | | tor-netdoc: Combine two hex encoding loops into a function See merge request tpo/core/arti!3947
| * | tor-netdoc: Combine two hex encoding loops into a functionIan Jackson2026-05-051-11/+11
| | |
* | | netdoc: Adjust dead_code attrs on IndexInfoGabriela Moldovan2026-05-071-2/+2
| | | | | | | | | | | | The `revision` field is no longer dead code.
* | | netdoc: Add an accessor for revision counter of the HsDescGabriela Moldovan2026-05-072-0/+6
| | |
* | | release: Remove semver.md files.Wesley Aptekar-Cassels2026-05-061-68/+0
| | |
* | | release: Bump tor- and arti- crate versions.Wesley Aptekar-Cassels2026-05-061-13/+13
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cargo set-version -p arti-client 0.42.0 cargo set-version -p arti-config 0.42.0 cargo set-version -p arti-relay 0.42.0 cargo set-version -p arti-rpc-client-core 0.42.0 cargo set-version -p arti-rpcserver 0.42.0 cargo set-version -p arti-testing 0.42.0 cargo set-version -p arti-ureq 0.42.0 cargo set-version -p tor-async-utils 0.42.0 cargo set-version -p tor-basic-utils 0.42.0 cargo set-version -p tor-bytes 0.42.0 cargo set-version -p tor-cell 0.42.0 cargo set-version -p tor-cert 0.42.0 cargo set-version -p tor-cert-x509 0.42.0 cargo set-version -p tor-chanmgr 0.42.0 cargo set-version -p tor-checkable 0.42.0 cargo set-version -p tor-circmgr 0.42.0 cargo set-version -p tor-config 0.42.0 cargo set-version -p tor-config-path 0.42.0 cargo set-version -p tor-consdiff 0.42.0 cargo set-version -p tor-dirclient 0.42.0 cargo set-version -p tor-dircommon 0.42.0 cargo set-version -p tor-dirmgr 0.42.0 cargo set-version -p tor-dirserver 0.42.0 cargo set-version -p tor-error 0.42.0 cargo set-version -p tor-events 0.42.0 cargo set-version -p tor-general-addr 0.42.0 cargo set-version -p tor-geoip 0.42.0 cargo set-version -p tor-guardmgr 0.42.0 cargo set-version -p tor-hsclient 0.42.0 cargo set-version -p tor-hscrypto 0.42.0 cargo set-version -p tor-hsrproxy 0.42.0 cargo set-version -p tor-hsservice 0.42.0 cargo set-version -p tor-key-forge 0.42.0 cargo set-version -p tor-keymgr 0.42.0 cargo set-version -p tor-linkspec 0.42.0 cargo set-version -p tor-llcrypto 0.42.0 cargo set-version -p tor-log-ratelim 0.42.0 cargo set-version -p tor-memquota 0.42.0 cargo set-version -p tor-memquota-cost 0.42.0 cargo set-version -p tor-netdir 0.42.0 cargo set-version -p tor-netdoc 0.42.0 cargo set-version -p tor-persist 0.42.0 cargo set-version -p tor-proto 0.42.0 cargo set-version -p tor-protover 0.42.0 cargo set-version -p tor-ptmgr 0.42.0 cargo set-version -p tor-relay-crypto 0.42.0 cargo set-version -p tor-relay-selection 0.42.0 cargo set-version -p tor-rpcbase 0.42.0 cargo set-version -p tor-rpc-connect 0.42.0 cargo set-version -p tor-rtcompat 0.42.0 cargo set-version -p tor-rtmock 0.42.0 cargo set-version -p tor-socksproto 0.42.0 cargo set-version -p tor-units 0.42.0
* | Merge branch 'directory-signature-hash-algo' into 'main'Clara Engler2026-04-3010-25/+123
|\| | | | | | | | | Unknown keyword handling fixes; use a more principled type for directory signature hash algo See merge request tpo/core/arti!3923
| * tor-netdoc: Use poc's DirectorySignatureHashAlgoIan Jackson2026-04-291-7/+15
| | | | | | | | | | | | | | | | | | This type is now directly suitable for use in directory signatures. While we're changing its type, rename the digest algorithm name field from `digestname` to `digest_algo`. (The spec says `algorithm` but I don't think we're going to reuse `direcctory-signature` for non-RSA signatures so this is just the hash algorithm.)
| * tor-netdoc: Promote DirectorySignatureHashAlgo from poc as nasty macroIan Jackson2026-04-292-12/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We want DirectorySignatureHashAlgo for prod's directory Signature type. However, for complex cfg gate and macro scoping reasons, we can't just move the definition out of poc. Hence this rather unpleasant intermediate state. This will go away, and become normal again, when we can abolish poc's signatures and have poc use a prod signature type. Review with git show --color=always --color-moved-ws=allow-indentation-change --color-moved
| * tor-netdoc: poc: make DirectorySignatureHashAlgo serialise properlyIan Jackson2026-04-291-0/+1
| |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 20:15:07 +0000