| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This will let us use it in more places, more sensibly.
Sadly it means a lot of syntactic vinegar at many of the call sites in
the old parser, which has very janky ideas about how errors should
work.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Tests will come in a moment.
|
| | | |
| | |
| | |
| | | |
Tests will come in a moment.
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
tor-netdoc: derives: Three small improvements
See merge request tpo/core/arti!3887
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This can't trigger, but when messing about with some new features,
I messed up and got a syntax error here. Let's try this feature out,
here.
|
| | | |
| | |
| | |
| | | |
No functional change.
|
| | |/
| |
| |
| | |
T_SIGNATURES is false, just above.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-netdoc: parse2: Fix error for invalid item argument
See merge request tpo/core/arti!3879
|
| | |/
| |
| |
| | |
When we can't parse a NormalItemArgument, that's Invalid, not Missing.
|
| | |
| |
| |
| |
| | |
I also searched this file for FromStr impls and these types were the
only ones that ought to be NormalItemArgument but weren't.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
Unfortunately one derive can't invoke another, so we must open-code
them, just like the other traits.
|
| | |
| |
| |
| |
| |
| |
| | |
Nothing derives just Transparent yet.
Mostly code motion, with some additional furniture and docs.
Review with git show --color-moved.
|
| | |
| |
| |
| |
| |
| | |
This error message is going to be used by both Transparent and
BytesTransparent. Put it in the code that is going to be part of
Transparent, and remove the macro name from it.
|
| | | |
|
| | |
| |
| |
| | |
This reduces clutter some more.
|
| | |
| |
| |
| |
| |
| | |
This is in the use's at the top of the file. If we `use super::*`
(like we do in the newer modules): the code can get a lot more
readable.
|
| | |
| |
| |
| |
| |
| |
| | |
Test the parsing and printing success cases.
Given that the parsing implementation is just a wrapper around B16's,
we don't need explicit tests for that.
|
| | |
| |
| |
| |
| | |
Make this a public BytesTransparent newtype like B64, implementing all
the same traits etc.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
On reflection, and looking at the test cases, I think the name `B16`
should refer to the lowercase version. I'll introduce a type for
uppercase in a moment.
Test the display implementation.
|
| | |
| |
| |
| |
| |
| |
| | |
Replace the open-coded .parse() calls with a closure.
This will let us test round trips, other types, etc., for each pairs
of test values.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Firstly, make its field pub.
Secondly, make the into_array method crate-private. It has a
crate-specific (albeit public) error type, The same basic effect can
be achieved with methods from std on arrays and slices.
|
| | |
| |
| |
| |
| |
| | |
Make this type public.
The new macro call means this type now implements many more traits.
|
| | |
| |
| |
| |
| | |
I think these are all the traits that a parsing/printing newtype
adapter ought to implement.
|
| | |
| |
| |
| |
| |
| |
| | |
Actually make the macro be a proper d-d macro. Replace uses of .0
with $fname, B64 with $ftype, etc.
No functional change in this commit.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Break various open-coded impls on B64 into this macro. That will let
us reuse this code for other types, making all these bytes wrappers
similar to each other.
In this commit, we just move the code. The macro is wrong because it
ought to refer to $ttype and so on. Review with git show --color-moved.
No functional change in this commit.
|
| | |
| |
| |
| |
| | |
This is slightly more logical and will make the next commit slightly
easier to read.
|
| |/
|
|
| |
This will reduce some duplication and simplify some macrology.
|
| |\
| |
| |
| |
| | |
tor-netdoc: ContactInfo
See merge request tpo/core/arti!3866
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
Otherwise you might, for example, receive a String from a config file,
JSON API submission, RPC call, or whatever, containing a newline, and
then encode it into a netdoc giving a syntax error or, worse,
smuggling additional items into the document!
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Otherwise the cfg_attr for the field would need to name both features.
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Fix the testdata2 situation
See merge request tpo/core/arti!3861
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit adds a manual test case for happy families in microdesc with
parse2. Manual in the sense that we hardcode a microdescriptor taken
from the wild here, as testdata2 does not contain them at the current
moment, which is unfortunate but reported.
|