summaryrefslogtreecommitdiff
path: root/crates/tor-netdoc
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | tor-netdoc: poc tests: use normal names for authcertsIan Jackson2026-06-171-6/+4
| | | |
| * | | tor-netdoc: poc tests: simulate normal outside-poc variety module namesIan Jackson2026-06-171-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are going to reuse/move this test code. Ie, it is going to be testing the real network document types. The naming outside poc is different. To make future diffs a bit less noisy, change some type names in the test code and fudge it up with a use.
| * | | tor-netdoc: un-cfg-gate some use'sIan Jackson2026-06-171-5/+2
| | | | | | | | | | | | | | | | | | | | We have the #1645 allow at the top of lib.rs, so this is unnecessary bureaucracy. Let's simplify this before adding more to it.
| * | | tor-netdoc: provide verify methods on new consensus types (fmt)Ian Jackson2026-06-171-3/+2
| | | |
| * | | tor-netdoc: provide verify methods on new consensus typesIan Jackson2026-06-172-2/+116
| | | |
| * | | tor-netdoc: Break out consensus_threshold fnIan Jackson2026-06-172-3/+31
| | | | | | | | | | | | | | | | This calculation appeared 3 times.
| * | | tor-netdoc: NetworkStatus: derive EncodeIan Jackson2026-06-171-1/+1
| | | |
* | | | Merge branch 'sp-fingerprint-encode' into 'main'Clara Engler2026-06-172-5/+32
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Encode for SpFingerprint See merge request tpo/core/arti!4116
| * | | | tor-netdoc: Round-trip test SpFingerprint encodingClara Engler2026-06-171-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | This commit adds a round-trip encoding for SpFingerprint to the already existing parsing test.
| * | | | tor-netdoc: Small SpFingerprint test refactoringClara Engler2026-06-171-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Do not shadow s and provide access to Wrapper instead of just the inner fingerprint. We will make use of this soon.
| * | | | tor-netdoc: Encode for SpFingerprintClara Engler2026-06-172-0/+16
| |/ / / | | | | | | | | | | | | | | | | Implements encode::ItemArgument for SpFignerprint. A test will be added in the next commit.
* | | | Merge branch 'ntor-cc-rd' into 'main'Ian Jackson2026-06-173-7/+25
|\ \ \ \ | |/ / / |/| | | | | | | | | | | Add ntor onion key cross certificate to RouterDesc See merge request tpo/core/arti!4109
| * | | tor-netdoc: Create NtorOnionKeyCrossCert at better placeClara Engler2026-06-171-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | This commit moves the construction place for the NtorOnionKeyCrossCert from the final RouterDesc construction to the crosscert code block, which should be more correct.
| * | | tor-netdoc: Add ntor_onion_key_crosscert to RouterDescClara Engler2026-06-152-0/+13
| | | | | | | | | | | | | | | | | | | | This commit adds ntor_onion_key_crosscert to RouterDesc as well as integrating it into the legacy parser.
| * | | tor-netdoc: Extract ntor bit and cert in legacy parser (fmt)Clara Engler2026-06-151-3/+6
| | | | | | | | | | | | | | | | No functional change.
| * | | tor-netdoc: Extract ntor bit and cert in legacy parserClara Engler2026-06-151-3/+3
| | | | | | | | | | | | | | | | We will soon need it for the ntor cross certificate.
| * | | tor-netdoc: Make dangerous_new_unverified available outside testsClara Engler2026-06-151-2/+4
| | |/ | |/| | | | | | | | | | We will need it for compatibility with the legacy parser soon. Not super nice.
* | | tor-netdoc: ItemValueEncodable for ExtraInfoDigestsClara Engler2026-06-172-1/+2
| | |
* | | tor-netdoc: ItemValueEncodable for RouterDescIntroItemClara Engler2026-06-172-1/+2
| | |
* | | tor-netdoc: ItemValueEncodable for OverloadGeneralClara Engler2026-06-172-1/+2
| | |
* | | Merge branch 'display-range' into 'main'Clara Engler2026-06-172-24/+61
|\ \ \ | |_|/ |/| | | | | | | | tor-netdoc: port policies: Encode with reject if it's shorter See merge request tpo/core/arti!4108
| * | tor-netdoc: placate clippyIan Jackson2026-06-161-1/+1
| | |
| * | tor-netdoc: port policies: Encode with reject if it's shorterIan Jackson2026-06-151-9/+16
| | | | | | | | | | | | | | | When trying to repro a live consensus, I discovered that `reject 25` turned into `accept 1-24,26-65535`.
| * | tor-netdoc: port policies: tests: reformatIan Jackson2026-06-151-2/+14
| | | | | | | | | | | | | | | | | | Use // to force rustdoc to multi-line layout. That makes the layout uniform across all these test cases, and will make the next commit clearer.
| * | tor-netdoc: port policies: Provide .invertedIan Jackson2026-06-151-3/+10
| | | | | | | | | | | | | | | We'll want this in a moment, not just invert in place. I was tempted to remove the mutating form, but there are at least two call sites.
| * | tor-netdoc: port policies: Simplify display with iter_joinIan Jackson2026-06-151-6/+2
| | |
| * | tor-netdoc: port policies: Declare iter return value as CloneIan Jackson2026-06-151-1/+1
| | | | | | | | | | | | It's Copy, in fact. But Copy iterators are a hazard.
| * | tor-netdoc: port policies: Provide display method on PortRangesIan Jackson2026-06-152-11/+26
| | | | | | | | | | | | We're going to want this for a more clever formatting algorithm.
* | | Merge branch 'relay-platform-encode' into 'main'Ian Jackson2026-06-162-4/+21
|\ \ \ | | | | | | | | | | | | | | | | Encoding for RelayPlatform See merge request tpo/core/arti!4114
| * | | tor-netdoc: Add ItemValueEncodable for RelayPlatformClara Engler2026-06-162-0/+14
| | | |
| * | | tor-netdoc: Implement ItemValueParseable instead for RelayPlatformClara Engler2026-06-162-4/+7
| | | | | | | | | | | | | | | | | | | | ItemArgumentParseable does not make much sense because the field is effectively a free-form field similar to ContactInfo.
* | | | tor-netdoc: Remove unequal key check from edcertsClara Engler2026-06-161-16/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As a follow up to !4022 and discussed on IRC: > Since we don't think we need to check the keys are different I think > it's OK to delete the thing in the tests that insists we have such a > check. > [...] > We are the relying party here. That MUST is directed to the signing > party. As reliers we don't need to check it.
* | | | tor-netdoc: Merge edcert tests togetherClara Engler2026-06-161-22/+4
|/ / / | | | | | | | | | | | | | | | Fixes a TODO as discussed in !4022. Review with --color-moved.
* | | Merge branch 'fix-authcert' into 'main'Clara Engler2026-06-161-1/+2
|\ \ \ | | | | | | | | | | | | | | | | tor-netdoc: fix EncodedAuthCert parsing See merge request tpo/core/arti!4104
| * | | tor-netdoc: fix EncodedAuthCert parsingIan Jackson2026-06-151-1/+2
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | It would swallow the whole rest of the document, leading to bizarre output on re-encoding. There is no test case for this in-tree (which is why this is cfg "incomplete"), but I have a full roundtrip test of a vote (which contains an authcert) in a wip branch, which detected this problem.
* | | Merge branch 'string-slice-types' into 'main'Ian Jackson2026-06-153-36/+21
|\ \ \ | |_|/ |/| | | | | | | | Avoid string slices in netdoc types See merge request tpo/core/arti!4103
| * | tor-netdoc: Replace string slice in LongIdentClara Engler2026-06-151-7/+3
| | | | | | | | | | | | | | | This commit replaces the use of string slices in LongIdent by using .strip_prefix() and .split_once() instead.
| * | tor-netdoc: Use .rsplit_once() in AddrPortPatternClara Engler2026-06-151-4/+2
| | | | | | | | | | | | | | | Replaces the use of a string slice in conjuction with .rfind() with a call to .rsplit_once().
| * | tor-netdoc: Replace string slice in address parse helperClara Engler2026-06-151-5/+4
| | | | | | | | | | | | | | | | | | | | | This commit replaces the use of a string slice in an address parse helper by replacing calls to `.starts_with` / `.ends_with` to calls with `.strip_prefix` / `.strip_suffix` and using the respective `.is_some()` for the boolean like value, making the result functionally equivalent.
| * | tor-netdoc: Use .split_once() in IpPatternClara Engler2026-06-151-3/+2
| | | | | | | | | | | | | | | This commit replaces the use of string slices in IpPattern with a call to split_once(). Either review as it is or with --word-diff=color.
| * | tor-netdoc: Use .split_once() in PortRangeClara Engler2026-06-151-17/+10
| |/ | | | | | | | | | | | | | | | | | | This commit replaces a string slice use in PortRange with a call to .split_string(). Either review the change as an entire rewrite, as the function in itself is pretty small or use --color-moved --color-moved-ws=ignore-all-space if you want to verify that the lines regarding a port range without a hyphen is still using the same logic.
* | tor-netdoc: rs.rs: tidy importsIan Jackson2026-06-151-2/+3
| |
* | tor-netdoc: routerstatus entries: Add `stats` item (votes only)Ian Jackson2026-06-155-2/+9
|/
* tor-netdoc: Rename variants in VerifyGeneralTrustedAuthorities (fmt)Ian Jackson2026-06-111-3/+1
|
* tor-netdoc: Rename variants in VerifyGeneralTrustedAuthoritiesIan Jackson2026-06-112-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | In a wip branch I added a variant, and clippy complained. In this case, I agree with clippy. warning: all variants have the same postfix: `Authorities` --> crates/tor-netdoc/src/doc/netstatus.rs:2335:1 | 2335 | / pub(crate) enum VerifyGeneralTrustedAuthorities<'r> { 2336 | | /// Trust these authorities. 2337 | | TrustTheseAuthorities { 2338 | | /// The HKP_auth_id_rsa ... | 2357 | | }, 2358 | | } | |_^ | = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#enum_variant_names note: the lint level is defined here --> crates/tor-netdoc/src/lib.rs:9:9 | 9 | #![warn(clippy::all)] | ^^^^^^^^^^^ = note: `#[warn(clippy::enum_variant_names)]` implied by `#[warn(clippy::all)]`
* Merge branch 'verify-general' into 'main'Ian Jackson2026-06-114-100/+245
|\ | | | | | | | | tor-netdoc: overhaul consensus verification, in preparation for parse2 ns verification See merge request tpo/core/arti!4065
| * tor-netdoc: verify_general: explain an exhaustive patternIan Jackson2026-06-111-0/+1
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4065#note_3423331
| * tor-netdoc: consensuses: Add a TODO about validate's signatureIan Jackson2026-06-111-0/+2
| |
| * tor-netdoc: consensuses: Introduce VerifyGeneralTrustedAuthorities (fmt)Ian Jackson2026-06-112-10/+9
| |
| * tor-netdoc: consensuses: Introduce VerifyGeneralTrustedAuthoritiesIan Jackson2026-06-113-11/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This avoids passing the threshold around as a bare usize, separated out from the list of trusted authorities. Roughly as discussed in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/4065#note_3423775 But, VGTA::HazardouslyAssumeAllAuthCertsAreRealAuthorities contains n_authorities, not the thtreshold. That's what its user has, and that allows us to centralise the threshold calculation somewhat. The situation with votes in poc is a bit odd now: we pass one cert and then there's one authority so the threshold of 1 is calculated rather than literal. That's OK, but also we perhaps aren't going to use verify_general for votes in the production.
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-28 04:30:17 +0000