aboutsummaryrefslogtreecommitdiff
path: root/crates/tor-netdoc/src
Commit message (Collapse)AuthorAgeFilesLines
...
* microdesc: make sure we recover from an error in the final md.Nick Mathewson2022-06-071-1/+7
| | | | | | | | (This is slightly different from recovering from errors in the middle of a list of mds, since in this case we _can't_ advance to the next md.) Also, note that a given branch is probably not reachable.
* netdoc: test case for microdesc with no ed25519 id.Nick Mathewson2022-06-071-0/+1
| | | | | The "bad-id" microdescriptor is hand-edited based on one from a Chutney network.
* netdoc: test a couple of accessors for AuthCert.Nick Mathewson2022-06-071-1/+11
|
* Netdoc: test enforcement for items that mustn't take objects.Nick Mathewson2022-06-071-0/+6
| | | | Found via coverage.
* netdoc: remove an unused method.Nick Mathewson2022-06-071-12/+0
|
* netdoc: Test more accessors for tokenized documents.Nick Mathewson2022-06-072-4/+20
|
* Netdoc: add accessor to error for ParseErrorKindNick Mathewson2022-06-071-0/+5
| | | | | The kind type was already public, but we didn't give the user any way to get it.
* netdoc: tests for parsing UnvalidatedEdCert.Nick Mathewson2022-06-071-1/+47
|
* Tests for netdoc RsaPublic type.Nick Mathewson2022-06-071-2/+37
|
* Fix a copy-paste error in Ed25519 parsing tests.Nick Mathewson2022-06-011-3/+3
| | | | | We accidentally tried to validate (invalid) ed25519 keys as curve25519 keys.
* Add test for parsing bad tor version with too many elements.Nick Mathewson2022-06-011-0/+1
| | | | This is a coverage-driven test.
* Add test for mutability of RelayFamily.Nick Mathewson2022-06-011-0/+9
|
* Tests for tor_netdoc::util::internNick Mathewson2022-06-011-0/+33
|
* lints: Add let_unit_value allow to all cratesIan Jackson2022-05-311-0/+1
| | | | | From running add_warning, with manual picking of the right hunks/lines.
* lints: Add lint block delimiters to every crateIan Jackson2022-05-311-0/+2
| | | | | | This was the result of: maint/add_warning crates/*/src/{lib,main}.rs and then manually curating the results.
* lints: Suppress unknown lints in a way that works on nightly tooIan Jackson2022-05-311-2/+4
| | | | This is ridiculous.
* tor-netdoc: Allow suppressing unknown lintsIan Jackson2022-05-271-0/+2
| | | | | We want to supress the unused_macro_rules lint in one place but it's new in Nightly and this triggers yet another lint.
* tor-netdoc: Suppress new "unused_macro_rules" lint in one placeIan Jackson2022-05-271-0/+1
| | | | | | | The compiler can apparently tell that we aren't generating compile errors! Also that we're not yet using a feature provided here. (New lint in currently Nightly.)
* Resolve the new `derive_partial_eq_without_eq` lint.Nick Mathewson2022-05-234-4/+4
| | | | It's a little overzealous sometimes, but it's mostly to the good.
* Fix typoDimitris Apostolou2022-05-141-1/+1
|
* tor-netdoc: Add a Lifetime::valid_at method.Nick Mathewson2022-05-111-0/+4
|
* netdoc: add a new type for NicknamesNick Mathewson2022-05-095-11/+95
| | | | | | | | | | Relay nicknames are always between 1 and 19 characters long, and they're always ASCII: That means that storing them in a [u8;19] will always be possible, and always use less resources than storing them in a String. Fortunately, the tinystr crate already helps us with this kind of thing.
* NetParams: Document its role as a validated config parameterIan Jackson2022-05-091-0/+3
|
* Fix grammar and typosSamanta Navarro2022-04-271-2/+2
|
* squash! Bump every crate's edition to 2021.Nick Mathewson2022-04-253-5/+0
| | | | | Remove all `use` statements for `TryFrom` and `TryInto`. These are now redundant in Rust 2021.
* Re-order attributes so that we can build with Rust 1.53.Nick Mathewson2022-03-315-15/+15
|
* tor-netdoc: Conditionally expose document fields.Nick Mathewson2022-03-316-0/+83
| | | | | | | | This commit uses the `visibility` and `visible` crates to conditionally make certain structs and their fields public (respectively). This is incredibly dangerous to use for anything besides testing, and I've tried to write the documentation for the feature accordingly.
* Remove allow(clippy::disallowed_methods) lint.Nick Mathewson2022-03-302-3/+0
|
* Merge branch 'no-system-time' into 'main'eta2022-03-302-0/+3
|\ | | | | | | | | | | | | Don't use SystemTime::now() Closes #306 See merge request tpo/core/arti!365
| * use wallclock where possible in teststrinity-1686a2022-02-262-0/+3
| |
* | Change type of TorClientConfig::override_net_paramsIan Jackson2022-03-161-1/+1
| | | | | | | | | | | | | | Now we use NetParams. That implies making its constructor public, which I think it fine. This is related to #413 but is far from completing that ticket.
* | Replace a match with some as_ref and asIan Jackson2022-03-161-4/+1
| | | | | | | | | | | | | | The match was doing a deref coercion. Found by current nightly's needless_match (whose suggestion doesn't compile, https://github.com/rust-lang/rust-clippy/issues/8551 )
* | Merge branch 'main' into 'intern-more'Nick Mathewson2022-03-141-49/+20
|\ \ | | | | | | | | | # Conflicts: # doc/semver_status.md
| * \ Merge branch 'slice-from-ref' into 'main'eta2022-03-141-49/+20
| |\ \ | | | | | | | | | | | | | | | | Simpify tor-netdoc TokVal See merge request tpo/core/arti!404
| | * | tor-netdoc: Actually, make TokVal be a VecIan Jackson2022-03-111-46/+20
| | | | | | | | | | | | | | | | | | | | This enum was otiose: its set of valid values is precisely those of a Vec. (Indeed what would TokVal::Multi(vec![]) have meant?)
| | * | Remove a pointless sliceIan Jackson2022-03-111-10/+7
| | | | | | | | | | | | | | | | std::slice::from_ref exists. Spotted while reviewing !400
* | | | Canonicalize and intern protover lines on descriptorsNick Mathewson2022-03-114-11/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should save around 1MB per consensus, since every relay has a 'protocols' lines, but there are only a few distinct possibilities for such a line. Closes #385.
* | | | Canonicalize and intern family representations to save memory.Nick Mathewson2022-03-114-9/+57
|/ / / | | | | | | | | | | | | | | | This should save 1-3 MB of ram on each running arti client. Closes #384. See also tor#27359 and proposal 298.
* | | Add a more generic implementation of intern-by-refNick Mathewson2022-03-112-4/+12
| | |
* | | netdoc: Call shrink_to_fit() when we're done parsing rs sectionsNick Mathewson2022-03-111-0/+1
| | | | | | | | | | | | | | | (Once we're done parsing these, the vector will never get any longer.)
* | | netdoc: allocate no extra space for RouterStatus addresses.Nick Mathewson2022-03-111-5/+6
| | | | | | | | | | | | This should save around 181K of heap on a current directory.
* | | netdoc: Make versions smaller in GenericRouterStatusNick Mathewson2022-03-114-11/+66
| | | | | | | | | | | | | | | | | | When the version is a Tor version, we can just parse it; otherwise, we can intern it. This shrinks GenericRouterStatus and avoids a lot of extra help allocations.
* | | tor-netdoc: Remove unused or_port field from RS.Nick Mathewson2022-03-112-6/+0
| | | | | | | | | | | | Part of #387
* | | Add methods to `UnverifiedConsensus`Christian Grigis2022-03-101-0/+25
|/ /
* | tor-netdoc: Use RsaIdentity::from_hex() in critical path.Nick Mathewson2022-03-041-6/+1
| | | | | | | | | | | | | | | | | | | | | | This commit changes the main parsing code for RsaIdentity in tor-netdoc, and . Previously, parse_hex_ident was something like 10% of our startup CPU time; now it's only like ~2%. (Still not perfect, but way better.) Closes #377.
* | Fix introduced junk in doc comment.eta2022-03-041-1/+1
| |
* | Replace manual Default and new with std derive in tor-netdocIan Jackson2022-03-022-17/+5
| |
* | Disable clippy::clone_on_ref_ptrIan Jackson2022-02-241-1/+0
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lint is IMO inherently ill-conceived. I have looked for the reasons why this might be thought to be a good idea and there were basically two (and they are sort of contradictory): I. "Calling ‘.clone()` on an Rc, Arc, or Weak can obscure the fact that only the pointer is being cloned, not the underlying data." This is the wording from https://rust-lang.github.io/rust-clippy/v0.0.212/#clone_on_ref_ptr It is a bit terse; we are left to infer why it is a bad idea to obscure this fact. It seems to me that if it is bad to obscure some fact, that must be because the fact is a hazard. But why would it be a hazard to not copy the underlying data ? In other languages, faliing to copy the underlying data is a serious correctness hazard. There is a whose class of bugs where things were not copied, and then mutated and/or reused in multiple places in ways that were not what the programmer intended. In my experience, this is a very common bug when writing Python and Javascript. I'm told it's common in golang too. But in Rust this bug is much much harder to write. The data inside an Arc is immutable. To have this bug you'd have use interior mutability - ie mess around with Mutex or RefCell. That provides a good barrier to these kind of accidents. II. "The reason for writing Rc::clone and Arc::clone [is] to make it clear that only the pointer is being cloned, as opposed to the underlying data. The former is always fast, while the latter can be very expensive depending on what is being cloned." This is the reasoning found here https://github.com/rust-lang/rust-clippy/issues/2048 This is saying that *not* using Arc::clone is hazardous. Specifically, that a deep clone is a performance hazard. But for this argument, the lint is precisely backwards. It's linting the "good" case and asking for it to be written in a more explicit way; while the supposedly bad case can be written conveniently. Also, many objects (in our codebase, and in all the libraries we use) that are Clone are in fact simply handles. They contain Arc(s) (or similar) and are cheap to clone. Indeed, that is the usual case. It does not make sense to distinguish in the syntax we use to clone such a handle, whether the handle is a transparent Arc, or an opaque struct containing one or more other handles. Forcing Arc::clone to be written as such makes for code churn when a type is changed from Arc<Something> to Something: Clone, or vice versa.
* Fix a rustdoc error.Nick Mathewson2022-02-151-1/+1
|
* Refactor tor-netdoc a bit more, to use Bug right.Nick Mathewson2022-02-151-4/+23
|
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 14:46:29 +0000