| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit moves the documentation for FromIterator<RelayFamilyId> for
RelayFamilyIds to the type level documentation of RelayFamilyIds. It
also rephrases the comment to fit in there more nicely grammatically and
contextually, as a pure motion of the comment would not have been
helpful to have there in any circumstance.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Adds a TODO with regard to .sort() and .dedup() in FromIterator in
RelayFamilyIds and the fact that it is slightly weird. This is not a
new problem with the type but stems from the fact that it tries to
emulate a BTreeSet inside a Vec which is not nice.
|
| | | |
| | |
| | |
| | | |
While already here, do this change, in case it becomes useful later on.
|
| | | |
| | |
| | |
| | |
| | | |
This makes working with this more comfortable as those calls are
generally required anyways.
|
| | | |
| | |
| | |
| | |
| | | |
RsaIdentity implements Copy itself so it makes sense to derive it on
those wrappers too.
|
| | | |
| | |
| | |
| | | |
Helpful in tests instead of Deref.
|
| | | |
| | |
| | |
| | | |
Fixes an outstanding TODO.
|
| |/ /
| |
| |
| |
| | |
We will need an inverse of the existing From implementation so that
derivation makes sense because we will obtain it for free then.
|
| | | |
|
| | |
| |
| |
| | |
No functional change.
|
| | |
| |
| |
| | |
This commit deserves no explanation, it should be the default.
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
| |
This commit introduces `RouterDesc::router` using `RouterDescIntroItem`
by moving `nickname`, `orport`, `dirport`, and `ipv4addr` into it.
A notable change is that ipv4addr is no longer stored in an `Option`.
I have no idea why this was the case because it has always been
mandatory and never None anyways, but I suspect it was to be able to
treat it as an iterator, something we can also achieve using
iter::once().
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
Use FixedB64 since it is in fact fixed length.
While we're here, add the docs link I had to follow to figure this
out.
|
| |
|
|
| |
Only SharedRandStatuses was out of place.
|
| | |
|
| | |
|
| |
|
|
| |
This is rather ugly, because the protocol is being ad-hoc again.
|
| | |
|
| | |
|
| |
|
|
|
| |
Preamble now doesn't contain anything that's *wrong*. It is missing a
couple of fields that will be wanted when we generate votes.
|
| |
|
|
|
| |
This isn't needed for the arti dirauth consensus method, but it will
be needed for arti dirauth vote calculator.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
This will let us use them in types in ordered lists in netdocs,
without fuss.
|
| |
|
|
|
| |
And document its meaning when parsing and encoding as flattened
fields.
|
| | |
|
| | |
|
| |
|
|
| |
ns_type! is a non-path type.
|
| |\
| |
| |
| |
| | |
Store fingerprint in Option<SpFingerprint>
See merge request tpo/core/arti!3978
|
| | | |
|
| | |
| |
| |
| |
| | |
Will be required and unavoidable as we will change fingerprint to
Option<SpFingerprint> in the next commit.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This change might seem pointless for now but it will be required and
unavoidable later on, because we will have to change
RouterDesc::fingerprint from RsaIdentity to Option<SpFingerprint> which
will make it impossible to be used inside the getter anymore.
With this change, our only resort is to obtain the RSA identity from the
signing key but we can only return a copy then because that RSA identity
is created ad-hoc then.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-netdoc: Sort out netstatus signatures
See merge request tpo/core/arti!3937
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3937#note_3405033
Suggested-by: Clara Engler <[email protected]>
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Abolish the terrible macro.
Review with --color-moved-ws=allow-indentation-change --color-moved.
|
| | | |
| | |
| | |
| | |
| | | |
hash_slice_for_verification is still needed by code in poc, that we're
not replacing in this MR. So that TODO gets downgraded, instead.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
Now that everything is prepared, we can add the sha1_unnamed field in
the hash accumulator.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
In order to handle marked vs unmarked SHA1 correctly, it needs the
original DigestAlgoInSignature.
The only call site is in poc's verification code.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use prod's Signature instead.
This gets rid of:
* The old parsing code. We have a new approach based on
ItemValueParseable, KeywordOrString and and DigestAlgoInSignature.
* The duplicate DirectorySignaturesHashesAccu and its temporary conversions.
poc's verify_timeless function needs a little adjustment for the new
struct layout.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This function is not right, yet. We're going to fix it later.
Review with --color-moved.
|