| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | tor-netdoc: Rename RelayFlags elements for regularity vs spec | Ian Jackson | 2025-11-18 | 3 | -7/+7 | |
| | | | | | | | | | | | Add underscores so that the spec keywords and the flag constants correspond (according to `paste`'s case-changing rules). | |||||
| * | | tor-netdoc: Improve docs for RelayFlags | Ian Jackson | 2025-11-18 | 1 | -1/+10 | |
| | | | | | | | | | | | | | | | * Document the bizarre FromStr impl. That isn't in my way, so I don't intend to fix it. So I've documented it instead. * Mention the naming discrepancy. | |||||
| * | | tor-netdoc: Move RelayFlags into its own module | Ian Jackson | 2025-11-18 | 3 | -161/+185 | |
| | | | | | | | | | | | We're going to do a lot more with this and it's less confusing to have it all together. | |||||
| * | | Merge branch 'p2-dedup' into 'main' | Ian Jackson | 2025-11-11 | 1 | -123/+139 | |
| |\ \ | | | | | | | | | | | | | tor-netdoc: parse2 More deduplication of the derive macro See merge request tpo/core/arti!3455 | |||||
| | * | | tor-netdoc: parse2: Improve error message when using with= | Ian Jackson | 2025-11-10 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | This can result in "trait not implemented" errors here. Use the `${paste_spanned}` trick. | |||||
| | * | | tor-netdoc: parse2 derive: deduplicate completion | Ian Jackson | 2025-11-10 | 1 | -35/+33 | |
| | | | | ||||||
| | * | | tor-netdoc: parse2 derive: deduplicate item accumulation | Ian Jackson | 2025-11-10 | 1 | -31/+35 | |
| | | | | ||||||
| | * | | tor-netdoc: parse2 derive: deduplicate item accumulation (prep) | Ian Jackson | 2025-11-10 | 1 | -43/+54 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move what is now IF_NONSTRUCTURAL_ACCUMULATE into the common module. It's not yet suitable for reuse. The docs for ACCUMULATE_ITEM_VALUE are still wrong. We'll fix that in a moment. | |||||
| | * | | tor-netdoc: parse2 derive: Provide dtrace in NetdocParseableFields | Ian Jackson | 2025-11-10 | 1 | -12/+21 | |
| | | | | | | | | | | | | | | | | | | | This was previously only not done because of the need to c&p. Also, we're going to be expanding some common macros that will use it. | |||||
| | * | | tor-netdoc: parse2 derive: Get rid of $ITEM workaround | Ian Jackson | 2025-11-10 | 1 | -10/+4 | |
| | | | | | | | | | | | | | The hygiene is fixed in derive-deftly 1.5.x. | |||||
| * | | | Apply deferred rustfmt churn | Ian Jackson | 2025-11-10 | 3 | -4/+4 | |
| | | | | ||||||
| * | | | tor-netdoc: Introduce "encode" feature for the like-named module | Ian Jackson | 2025-11-10 | 2 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | We're going to introduce facilities for encoding more generally, and we'll want a way to enable them. Instead, have a separate feature for *encoding* documents. | |||||
| * | | | tor-netdoc: Rename the `build` module to `encode` | Ian Jackson | 2025-11-10 | 5 | -8/+8 | |
| |/ / | | | | | | | | | The word "build" so often in Rust means builder pattern. This module contains functions for encoding. | |||||
| * | | tor-netdoc: Fix typo | Ian Jackson | 2025-11-10 | 1 | -1/+1 | |
| | | | ||||||
| * | | tor-netdoc: parse2 derive: deduplicate item parsing | Ian Jackson | 2025-11-06 | 1 | -24/+23 | |
| | | | ||||||
| * | | tor-netdoc: parse2 derive: deduplicate item set selectors | Ian Jackson | 2025-11-06 | 1 | -47/+62 | |
| | | | ||||||
| * | | tor-netdoc: parse2 derive: deduplicate F_EFFECTIVE_TYPE | Ian Jackson | 2025-11-06 | 1 | -24/+13 | |
| | | | ||||||
| * | | tor-netdoc: parse2 derive: deduplication: field types and keywords | Ian Jackson | 2025-11-06 | 1 | -36/+39 | |
| | | | | | | | | | | | | | | | Have the module expect the use site to determine (mostly) the field kind. Document this expectation. Now NetdocParseableCommon can have the keyword-related definitions. | |||||
| * | | tor-netdoc: parse2 derive: deduplication: start a module | Ian Jackson | 2025-11-06 | 2 | -9/+13 | |
| | | | | | | | | | Put one textually-identical define in it, to start with. | |||||
| * | | Fix name of clippy lint to unchecked_time_subtraction (2) | Ian Jackson | 2025-11-06 | 31 | -32/+32 | |
| | | | | | | | | | Run maint/add_warning | |||||
| * | | Use a while let loop (to placate clippy) | Ian Jackson | 2025-11-06 | 1 | -2/+1 | |
| |/ | ||||||
| * | tor-netdoc: impl ItemArgumentParseable for Ignored | Ian Jackson | 2025-10-23 | 1 | -2/+10 | |
| | | | | | Change our mind about the logic for encoding an Ignored. | |||||
| * | tor-netdoc: Abolish ArgumentNotPresent alias, completing the rename | Ian Jackson | 2025-10-23 | 3 | -9/+6 | |
| | | ||||||
| * | tor-netdoc: Use NotPresent rather than Option<Ignored> to suppress fields | Ian Jackson | 2025-10-23 | 4 | -8/+8 | |
| | | ||||||
| * | tor-netdoc: Add unit tests for NotPresent and Ignored objects | Ian Jackson | 2025-10-23 | 1 | -1/+32 | |
| | | ||||||
| * | tor-netdoc: Add unit tests for NotPresent items | Ian Jackson | 2025-10-23 | 3 | -2/+6 | |
| | | ||||||
| * | tor-netcoc: Introduce NotPresent, for absent multiplicity | Ian Jackson | 2025-10-23 | 2 | -9/+86 | |
| | | | | | | | | | | Currently this is mishandled: the current use sites (in rs/each_variety.rs) use Option<Ignored>, which would reject repeated items with that keyword, which is technically wrong. And encoing will become a problem. Vec<Ignored> would be wrong too. Instead, broaden NotPresent and give it multiplicity impls. | |||||
| * | tor-netdoc: Move parse2 impls on Ignored to types/misc.rs | Ian Jackson | 2025-10-23 | 2 | -23/+22 | |
| | | | | | | | This seems to be where we're putting most of the parse2 impls on these types, now. That makes more sense as parse2 becomes more of a proper thing. | |||||
| * | tor-netdoc: NetdocParseableFields derive: support flatten (test) | Ian Jackson | 2025-10-22 | 1 | -0/+11 | |
| | | ||||||
| * | tor-netdoc: NetdocParseableFields derive: support flatten | Ian Jackson | 2025-10-22 | 1 | -2/+26 | |
| | | | | | | | | | | This allows a NetdocParseableFields inside a NetdocParseableFields. The code is rather duplicative with the NetdocParseable implementation. This is due to limitations in derive-deftly; see https://gitlab.torproject.org/Diziet/rust-derive-deftly/-/merge_requests/525 where I'm trying to start to address them. | |||||
| * | tor-netdoc: NetdocParseableFields derive: break out kw variable | Ian Jackson | 2025-10-22 | 1 | -1/+3 | |
| | | | | | We're going to reuse this. | |||||
| * | tor-netdoc: Preamble: Fix garbled doc comment | Ian Jackson | 2025-10-22 | 1 | -1/+1 | |
| | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3378#note_3277957 | |||||
| * | tor-netdoc: Preamble: rename relay_version field to server_version | Ian Jackson | 2025-10-22 | 3 | -8/+8 | |
| | | | | | This makes it match the protocol and the spec. | |||||
| * | tor-netdoc: Say Preamble doesn't contain vote-status, in summary. | Ian Jackson | 2025-10-22 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc: Explain that Preamble doesn't contain vote-status either. | Ian Jackson | 2025-10-22 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc: netstatus: Preamble: Name the protocols fields in doc | Ian Jackson | 2025-10-22 | 1 | -0/+2 | |
| | | ||||||
| * | tor-netdoc: netstatus: Preamble: rename shared rand fields to match doc | Ian Jackson | 2025-10-22 | 3 | -18/+18 | |
| | | | | | | We should use the same name everywhere, even if the name in the spec is clumsy (as it is here). | |||||
| * | tor-netdoc: Move ConsensusFlavor into Consensus struct | Ian Jackson | 2025-10-22 | 3 | -14/+22 | |
| | | | | | | | We're going to want to apply the parse2 derive to Preamble, but this field is anomalous. Rather than trying to make it regular, simply move it to the old-parser-specific Consensus struct. | |||||
| * | tor-netdoc: Declare intent not to apply parse2 to Consensus | Ian Jackson | 2025-10-22 | 1 | -4/+1 | |
| | | | | | | | | Consensus is not going to be easy to square with parse2 - especially, signature handling is very different between the two parsers. Instead, we'll have a new NetworkStatus type. | |||||
| * | tor-netdoc: Rename consensus Header to Preamble | Ian Jackson | 2025-10-22 | 4 | -40/+42 | |
| | | | | | | There is no such thing as the "header" according to the spec. We mean the preamble. | |||||
| * | Merge branch 'p2-shared-rand-status' into 'main' | Ian Jackson | 2025-10-22 | 4 | -17/+27 | |
| |\ | | | | | | | | | impl ItemValueParseable for SharedRandStatus See merge request tpo/core/arti!3380 | |||||
| | * | tor-netdoc: impl ItemValueParseable for SharedRandStatus | Ian Jackson | 2025-10-21 | 1 | -0/+1 | |
| | | | ||||||
| | * | tor-netdoc: impl Display, FromStr, NormalItemArgument for SharedRandVal | Ian Jackson | 2025-10-21 | 1 | -2/+18 | |
| | | | ||||||
| | * | tor-netdoc: derive From<Vec<u8>> and v-v for B64 | Ian Jackson | 2025-10-21 | 1 | -7/+1 | |
| | | | | | | | | | | | | | | | | | This may not be the best utility type to use for lots of the fixed-length byte strings, but we *are* using it a lot in the old and now the new parser. Implement From and Into. | |||||
| | * | tor-netdoc: Change type of timestamp in SharedRandStatus (fmt) | Ian Jackson | 2025-10-21 | 1 | -2/+1 | |
| | | | ||||||
| | * | tor-netdoc: Change type of timestamp in SharedRandStatus | Ian Jackson | 2025-10-21 | 3 | -7/+7 | |
| | | | ||||||
| * | | Merge branch 'p2-misc-fixes' into 'main' | opara | 2025-10-21 | 2 | -2/+7 | |
| |\ \ | | | | | | | | | | | | | tor-netdoc: parse2: Minor fixes See merge request tpo/core/arti!3376 | |||||
| | * | | tor-netdoc: Reference `build::ItemArgument` from `NoramlItemArgument` doc | Ian Jackson | 2025-10-21 | 1 | -1/+2 | |
| | | | | | | | | | | | | | | | | | | | Since 9ce85acb3ab0d1a0b1be6ef0f10707983f4362a3 tor-netdoc: replace impl_item_argument_as_display with NormalItemArgument this trait impl has implications for encoding as well as parsing. | |||||
| | * | | tor-netdoc: NetdocParseable derive: use more explicit syntax | Ian Jackson | 2025-10-21 | 1 | -1/+1 | |
| | | | | | | | | | | | | | In principle some other trait might be in scope. | |||||
| | * | | tor-netdoc: parse2: Don't declare internal error on subdoc intro items | Ian Jackson | 2025-10-21 | 1 | -0/+4 | |
| | |/ | | | | | | | | | subdoc intro items aren't inherently incoherent, but implementing them is nontrivial. Let's reject them with a bespoke error instead. | |||||
