aboutsummaryrefslogtreecommitdiff
path: root/crates/tor-netdoc/src
Commit message (Collapse)AuthorAgeFilesLines
* tor-netdoc: "testing" feature: Provide test_parsed_hsdescIan Jackson2023-09-181-12/+20
| | | | | | This is actually just the start of an existing test case. tor-hsservice tests will want this in a moment.
* tor-netdoc: tests: Hoist out TEST_DATA_HS_BLIND_ID (fmt)Ian Jackson2023-09-181-4/+1
|
* tor-netdoc: tests: Hoist out TEST_DATA_HS_BLIND_IDIan Jackson2023-09-181-3/+9
|
* tor-netdoc: provide a IntroPointDescBuilder (fmt)Ian Jackson2023-08-291-2/+1
|
* tor-netdoc: provide a IntroPointDescBuilderIan Jackson2023-08-291-0/+13
| | | | | | | | | | | Previously there was no way to construct one of these during descriptor generation, other than parsing. A fairly simple builder seems right. I felt the builder's setter functions for setting keys should be named precisely after official key names. But the fields weren't, so for now I have done some builder-level renaming.
* Merge branch 'clippy' into 'main'Ian Jackson2023-08-2328-0/+28
|\ | | | | | | | | clippy: Suppress needless_pass_by_value in tests See merge request tpo/core/arti!1535
| * Run maint/add_warning to add lint block everywhereIan Jackson2023-08-2328-0/+28
| |
* | tor-netdoc: Fix clippy lints.Gabriela Moldovan2023-08-232-6/+6
| |
* | tor-netdoc: Remove redundant `IntroPointDesc` struct.Gabriela Moldovan2023-08-232-33/+13
|/ | | | | | | | | | | | This commit replaces `tor_netdoc::hsdesc::inner::IntroPointDesc` with the (almost identical) `tor_netdoc::hsdesc::IntroPointDesc`. The only difference between the two structs is that `inner::IntroPointDesc` wraps a `Vec<LinkSpec>` instead of a `Vec<EncodedLinkSpec>`. Since `EncodedLinkSpec` can be derived from `LinkSpec` (and vice-versa), and since `hsdesc::inner::IntroPointDesc` never made it in our public API, this commit also removes `hsdesc::inner::IntroPointDesc` in favour of `hsdesc::IntroPointDesc`.
* Resolve warnings about ambiguous/redundant doc linksNick Mathewson2023-08-221-1/+1
| | | | | Nightly rustdoc now warns if you have a link that isn't necessary, and if you have a link that might refer to two different things.
* tor-bytes: deprecate always_bug with From traitEmil Engler2023-08-171-2/+1
| | | | | | This commit deprecates the `EncodeError::always_bug` function with a `From<EncodeError> for Bug` trait, which is a more semantically correct way to perform this action.
* Run add_warnings on all files.Nick Mathewson2023-08-041-2/+2
|
* Fix typosDimitris Apostolou2023-07-221-1/+1
|
* Merge branch 'explain_952_fix' into 'main'Nick Mathewson2023-07-111-0/+3
|\ | | | | | | | | Explain the code for the #952 fix. See merge request tpo/core/arti!1391
| * Explain the code for the #952 fix.Nick Mathewson2023-07-101-0/+3
| | | | | | | | | | Let's explain what Trinity did in its fix for #952, so that we know why this code is here the next time we find it.
* | Run maint/add_warning to actually apply new lint allowsIan Jackson2023-07-1029-0/+29
|/
* be more lenient while parsing inner hs desctrinity-1686a2023-07-071-1/+6
|
* Run add_warning to remove `missing_panics_doc` deny.Nick Mathewson2023-07-061-1/+0
| | | | Closes #950.
* Fix a rustdoc link.Nick Mathewson2023-06-291-1/+1
|
* Merge branch 'maxintro3' into 'main'Ian Jackson2023-06-293-7/+78
|\ | | | | | | | | tor-netdoc: Handle anomalous numbers of introduction points See merge request tpo/core/arti!1332
| * tor-netdoc: Placate clippy (fmt)Ian Jackson2023-06-281-2/+1
| |
| * tor-netdoc: Placate clippyIan Jackson2023-06-281-2/+1
| |
| * tor-netdoc: Test hsdescs inners with a variety of IPT counts (fmt)Ian Jackson2023-06-281-9/+18
| |
| * tor-netdoc: Test hsdescs inners with a variety of IPT countsIan Jackson2023-06-282-1/+34
| |
| * tor-netdoc: hsdesc: Disregard intro points after the MAX'thIan Jackson2023-06-282-7/+19
| |
| * tor-netdoc: Reject hsdescs with no intro pointsIan Jackson2023-06-283-0/+19
| | | | | | | | None of the existing NetdocErrorKinds seemed right.
* | netdir: Move voting_period() to netdoc::LifetimeNick Mathewson2023-06-291-0/+12
|/ | | | | I was going to add a comment about "doing this if we need the voting period anywhere else" but it turns out that we also use it in dirmgr.
* Conditionalise an importIan Jackson2023-06-281-0/+1
| | | | | Fixes a warning with cargo clippy --locked --offline --workspace --all-targets
* Back down x25519-dalek to 2.0.0-pre.1 from 2.0.0-rc.2pinkforest2023-06-272-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ========================= Notes from nickm: (This differs from pinkforest's original MR: It removes the Cargo.lock changes and the version bump on tor-llcrypto.) Minimal Cargo.lock changes from downgrade. (These are exactly those changes generated by running "build" and "test".) There are several reasons to do this: * It's best to bump all of our dalek dependencies at once to rc.3 or later, rather than the piecemeal approach we've been stuck with so far. * We don't want to do this bump right now, since there are some tricky questions about clamping we need to figure out (see #808), and we need to make sure we get them right, and we're in a distracted this week. * We _do_ need to move away from 2.0.0-rc.2 right now, since it was causing a failure in `cargo install arti`, and then it got yanked. Thanks to pinkforest for helping us out here and explaining all of this! Fixes #926. Commit-edited-by: Nick Mathewson <[email protected]>
* Merge branch 'netdoc-todos-again' into 'main'Nick Mathewson2023-06-265-42/+97
|\ | | | | | | | | netdoc: Resolve nearly all remaining TODO HS items. See merge request tpo/core/arti!1304
| * netdoc: remove final TODO HSNick Mathewson2023-06-261-1/+0
| | | | | | | | Although this Errorkind is not perfect, it is good enough.
| * netdoc: Downgrade TODO on EncryptedHsDesc::decryptNick Mathewson2023-06-261-2/+5
| |
| * netdoc: Remove "decrypted_with_id" as meaninglessNick Mathewson2023-06-261-26/+9
| | | | | | | | | | | | Actually, never mind about adding an accessor here: this value was set incorrectly and didn't match its documentation. As such it's basically useless, and we might as well throw it out.
| * netdoc: Remove dead_code exception; add accessors.Nick Mathewson2023-06-262-5/+36
| | | | | | | | | | | | | | | | | | | | | | | | This commit removes some actual dead code and additionally adds some minimal accessors to HsDesc to expose some of its properties. (I'm trying to keep these minimal since it's not yet clear whether we want to expose more detail here.) Here we also make StoredHsDescMeta a conditional type that's only present when the new "hs-dir" feature is enabled. Neither relays nor clients need this: Only HsDirs will need it, when we finally implement relays.
| * netdoc: change a TODO HS about a distinguisher to a NOTE.Nick Mathewson2023-06-261-4/+7
| | | | | | | | (We explicitly do not care if Arti can be distinguished from C tor.)
| * netdoc: replace a test TODO with a reference to other testsNick Mathewson2023-06-261-1/+8
| | | | | | | | The tests called for here already existed.
| * netdoc: fill in some test dataNick Mathewson2023-06-234-11/+40
| | | | | | | | | | This resolves some TODO HS items now that we are confident we want to have these actual examples in our tests.
* | netdoc: Note new feature in itertoolsNick Mathewson2023-06-261-1/+5
|/
* hsdescerror: Add paragraph breaks to docs.Nick Mathewson2023-06-221-3/+11
|
* netdoc: Use a dev-dependency on anyhow to fix a doc exampleNick Mathewson2023-06-221-1/+1
|
* netdoc: Introduce HsDescErrorNick Mathewson2023-06-223-37/+124
| | | | | | | | | | For higher-level HsDesc-related functions, this type indicates where exactly an error occurred. It lets us distinguish decryption errors from parsing errors, and attribute responsibility to the hsdir, the onion service, or the user's lack of encryption. This lets us remove some just-introduced complexity in tor-hsclient.
* Merge branch 'socks_errorkinds' into 'main'Nick Mathewson2023-06-222-1/+9
|\ | | | | | | | | | | | | Generate correct-ish socks5 errors for onion service errors. Closes #736 See merge request tpo/core/arti!1279
| * Generate correct ErrorKinds for hsdesc decryption failures.Nick Mathewson2023-06-212-1/+9
| | | | | | | | Part of #736
* | Merge branch 'stderr' into 'main'Alexander Færøy2023-06-211-0/+2
|\ \ | | | | | | | | | | | | lints: Promote clippy::print_stderr and clippy::print_stdout See merge request tpo/core/arti!1271
| * | lints: Run maint/add_warning to actually apply new lintsIan Jackson2023-06-211-0/+2
| |/
* | netdoc: downgrade two accessor-related TODOsNick Mathewson2023-06-201-4/+1
| |
* | netdoc: Use derive amplify::Getters for HsDesc accessors.Nick Mathewson2023-06-201-46/+8
|/ | | | Closes #909.
* hsdesc.rs: finally remove "allows".Nick Mathewson2023-06-162-13/+9
| | | | | | The last piece here is removing some needless keygen from the tests. This causes the test output (using the deterministic PRNG) to change.
* netdoc::doc::hsdesc changes to let us downgrade/remove allowsNick Mathewson2023-06-166-10/+9
|
* netdoc: unmark MAC_KEY_LEN as conjectural.Nick Mathewson2023-06-161-1/+1
| | | | | The value here is 32 bytes; I'm adding it to to the specification as torspec!141
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-26 20:00:45 +0000