| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| |
| |
| | |
Unknown keyword handling fixes; use a more principled type for directory signature hash algo
See merge request tpo/core/arti!3923
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
This type is now directly suitable for use in directory signatures.
While we're changing its type, rename the digest algorithm name field
from `digestname` to `digest_algo`. (The spec says `algorithm` but I
don't think we're going to reuse `direcctory-signature` for non-RSA
signatures so this is just the hash algorithm.)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We want DirectorySignatureHashAlgo for prod's directory Signature
type.
However, for complex cfg gate and macro scoping reasons, we can't just
move the definition out of poc. Hence this rather unpleasant
intermediate state. This will go away, and become normal again, when
we can abolish poc's signatures and have poc use a prod signature
type.
Review with
git show --color=always --color-moved-ws=allow-indentation-change --color-moved
|
| | | |
|
| | |
| |
| |
| |
| | |
We're going to use this for `directory-signature`'s hash algorithm,
which the current code always treats as a string!
|
| | | |
|
| | |
| |
| |
| |
| | |
Make the operation of disregarding the possible existence of
already-discarded information, more explicit.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows implementing NormalItemArgument for types that can only be
parsed, or only displayed - or other combinations.
I noticed this restriction while inventing a type I later decided was
unnecessary. I still think it's a good change.
There is no practical impact elsewhere, since in practice downstream
code implements NormalItemArgument rather than relying on it.
|
| | |
| |
| |
| | |
Part of #2492 phase 2.
|
| |/
|
|
|
|
| |
Change all call sites.
This completes the rename.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Change "ns-vote" gates to "incomplete":
* `vote` modules, and in the variety macro.
(And make a TODO more likely to be found.)
Change "parse2" gates to "incomplete":
* VoteAuthoritySection
|
| |
|
|
| |
Everything that this needs is un-gated now.
|
| |
|
|
|
| |
These are complete. Un-gate the RouterStatusMdDigestsVote
implementation, and the export of both.
|
| |
|
|
| |
As per #2492.
|
| |
|
|
| |
As per #2492.
|
| |
|
|
|
| |
This is only used for hsdescs right now. But it doesn't need to be
gated behind encode.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This stabilises the parse2 and encode impls of consensus tyepe:
* {plain, md}::{Preamble, RouterStatus, RouterStatusIntroItem}
It also un-gates the parse2 and encode impls of some vote types.
* VoteAuthorityEntry - this type has been completed.
* RouterStatusMdDigestsVote - whole type still gated with ns-vote
Re the remaining vote types (vote::*): although each_variety.rs
doesn't have a cfg itself, there is a feature gate in the variety
macrology.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
This stabilises the parse2 and encode impls of
* Lifetime
* ConsensusMethods
* SharedRandStatus
* ConsensusAuthorityEntry
All of these are complete.
|
| | |
|
| |
|
|
| |
There are no outstanding TODOs here.
|
| | |
|
| |
|
|
|
|
| |
Tidy the imports, and remove some now-unneeded { }.
We'll run rustfmt in a moment to sort and reindent.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This stabilises the parse2 and encode impls of
* NetParams<i32>
* ProtoStatuses
It also stabilises the parse2 impls of the following types which do
not currently have any encode impls:
* RelayWeight
* rs::SoftwareVersion
* IgnoredPublicationTimeSp
As for TODOs and incomplete code: the things we're stabilising here
are very simple, or fully formed.
Implementing encoding for IgnoredPublicationTimeSp looks impossible,
but we can cross that bridge when we come to it.
We un-cfg-gate the parse2 and encode imports too.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
These are all parse2, and there are no blocking TODOs.
We're leaving `build_docs` alone.
|
| |
|
|
| |
This is just one cfg, for RelayPlatform.
|
| |
|
|
| |
There is one irrelevant TODO.
|
| |
|
|
| |
There is only one TODO in this file and it's not really relevant.
|
| |
|
|
|
| |
There is one TODO DIRMIRROR but it's a possible API change.
I think it doesn't mean we can't un-gate this now.
|
| | |
|
| | |
|
| |
|
|
| |
These are all parse2, and there are no blocking TODOs.
|
| | |
|
| |
|
|
|
|
| |
Remove a now-pointless pair of { }.
We'll reindent this in a moment.
|
| |
|
|
| |
These are all parse2, and there are no blocking TODOs.
|
| |\
| |
| |
| |
| | |
tor-netdoc: Parsing and encoding for netstatus authority sections
See merge request tpo/core/arti!3892
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Replace poc code with new ConsensusAuthoritySection.
This is an entirely new parsing approach.
Key differences:
* We parse the arguments to dir-source, which poc didn't.
* We don't clone the input and fully parse the first item; instead,
we dismantle the dir-source line ad-hoc to determine the item type.
* Rather than a Vec of Enums, we parse into two Vecs
of the different entry types.
The few lines that aren't rewritten show up as moved in
git show --color-moved --color-moved-ws=allow-indentation-change
but I suggest reviewing the new implementation de novo.
|
| | |
| |
| |
| |
| | |
This is the type corresponding to a "superseded authority key entry",
which is a single dir-source line with a weird nickname.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is going to handle the bizarre `-legacy` nickname encoding for
superseded authority keys. That's going to be a fair amount of code,
some derived from DirSource. Make a module for it all.
We're going to take a different approach that in poc. So there's
going to be all-new code and then the poc version will be deleted.
They don't resemble each other very much.
In this commit: just code motion, and the creation of the new module
with associated doc comment. Review with --color-moved.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
We must add to our ad-hoc derive, since the normal derive can't do the
encoding either.
|
| | |
| |
| |
| |
| | |
Use deftly's field loop, rather than handcoding the two fields.
(We don't expect to add any fields, but if we did this would be more correct.)
|
