summaryrefslogtreecommitdiff
path: root/crates/tor-netdoc/src
Commit message (Collapse)AuthorAgeFilesLines
* tor-netdoc: Use the new HandshakeType enum to represent CREATE2 HTYPEs (fmt).Gabriela Moldovan2023-10-301-17/+21
|
* tor-netdoc: Use the new HandshakeType enum to represent CREATE2 HTYPEs.Gabriela Moldovan2023-10-302-15/+16
| | | | | | | | | | | Representing the supported HTYPEs as `HandshakeType`s instead of `u32`s makes it more difficult to pass in wrong/invalid values to `HsDescBuilder::create2_formats`. This also fixes a descriptor publisher bug spotted by @jnewsome, where the advertised CREATE2 HTYPEs included HTYPE `1`, which is actually supposed to be a reserved value. The publisher now only advertises the `NTOR` HTYPE (just like C Tor).
* Remove a broken rustdoc link and fix a typo.Nick Mathewson2023-10-271-3/+0
|
* tor-cert, tor-netdoc: Use EncodedEd25519Cert instead of Vec<u8>.Gabriela Moldovan2023-10-253-11/+8
|
* tor-netdoc: Change return type of create_desc_sign_key_cert.Gabriela Moldovan2023-10-251-6/+3
| | | | | | `Bug` wasn't necessarily the right error type here. Plus, with the new error type adding new errors (i.e. `CertEncodeError` variants), is not a breaking change.
* tor-netdoc: Building a descriptor now only requires the public part of ↵Gabriela Moldovan2023-10-251-8/+10
| | | | blinded_id.
* tor-netdoc: Remove now-unused blinded_id field.Gabriela Moldovan2023-10-252-7/+0
|
* tor-netdoc: Update HsDesc, HsDescOuter to accept the hs_desc_sign cert as an ↵Gabriela Moldovan2023-10-252-21/+32
| | | | | | | | | | argument. This will enable us to (eventually) the load the descriptor signing key cert from the keystore (as opposed to always recomputing it when building the `HsDesc`). Part of #1048
* tor-netdoc: Add helper function for computing the descriptor signing key cert.Gabriela Moldovan2023-10-253-15/+34
|
* tor-dirclient, tor-netdoc: Add TODO SPECs.Gabriela Moldovan2023-10-241-0/+3
|
* tor-netdoc: Use an unpadded base64 encoding for the signature.Gabriela Moldovan2023-10-241-3/+3
| | | | This is what the C Tor HsDirs want.
* Fix unresolved reference in documentationhalcyon2023-10-231-1/+2
|
* Remove deprecated ItemArgument impl for SystemTimehalcyon2023-10-231-27/+1
|
* Cleanup fmt_with doc comment after merge discussionhalcyon2023-10-231-2/+4
|
* Remove todo, std::fmt::Error doesnt allow for information transitionhalcyon2023-10-221-2/+0
|
* Handle time formatting through Time crate rather than string allocationshalcyon2023-10-201-16/+18
|
* Fix unresolved link warninghalcyon2023-10-201-1/+1
|
* Add Test for different Netdoc ItemArgument time formatshalcyon2023-10-201-0/+29
|
* Implement Netdoc ItemArgument for Iso8601TimeNoSp and Iso8601TimeSphalcyon2023-10-201-2/+15
|
* Implement Display for Iso8601TimeNoSp and Iso8601TimeSphalcyon2023-10-201-0/+38
|
* Explain why we are sorting intro points.Nick Mathewson2023-10-161-0/+7
|
* Sort introduction point lists by ntor public key.Neel Chauhan2023-10-161-16/+18
| | | | Closes #1039
* tor-netdoc: Remove outdated note.Gabriela Moldovan2023-09-251-4/+0
|
* tor-hsclient, arti-client, tor-keymgr, tor-netdoc: Use a keypair instead of ↵Gabriela Moldovan2023-09-253-6/+6
| | | | StaticSecret (fmt).
* tor-hsclient, arti-client, tor-keymgr, tor-netdoc: Use a keypair instead of ↵Gabriela Moldovan2023-09-253-13/+12
| | | | | | | | | | | | | StaticSecret. Previously, when retrieving `KS_hsc_desc_enc` keys (or any other x25519 keys) from the keystore, the keymgr would discard the public part of the key (SSH private keys contain the public part of the key too). Instead of discarding the public key and returning just the `StaticSecret`, the keymgr now returns a `StaticKeypair`. This makes the x25519 `EncodableKey`/`ToEncodableKey` implementation consistent with the ed25519 one (which retrieves key pairs rather than "unescorted" secrets).
* tor-netdoc: "testing" feature: Provide test_parsed_hsdescIan Jackson2023-09-181-12/+20
| | | | | | This is actually just the start of an existing test case. tor-hsservice tests will want this in a moment.
* tor-netdoc: tests: Hoist out TEST_DATA_HS_BLIND_ID (fmt)Ian Jackson2023-09-181-4/+1
|
* tor-netdoc: tests: Hoist out TEST_DATA_HS_BLIND_IDIan Jackson2023-09-181-3/+9
|
* tor-netdoc: provide a IntroPointDescBuilder (fmt)Ian Jackson2023-08-291-2/+1
|
* tor-netdoc: provide a IntroPointDescBuilderIan Jackson2023-08-291-0/+13
| | | | | | | | | | | Previously there was no way to construct one of these during descriptor generation, other than parsing. A fairly simple builder seems right. I felt the builder's setter functions for setting keys should be named precisely after official key names. But the fields weren't, so for now I have done some builder-level renaming.
* Merge branch 'clippy' into 'main'Ian Jackson2023-08-2328-0/+28
|\ | | | | | | | | clippy: Suppress needless_pass_by_value in tests See merge request tpo/core/arti!1535
| * Run maint/add_warning to add lint block everywhereIan Jackson2023-08-2328-0/+28
| |
* | tor-netdoc: Fix clippy lints.Gabriela Moldovan2023-08-232-6/+6
| |
* | tor-netdoc: Remove redundant `IntroPointDesc` struct.Gabriela Moldovan2023-08-232-33/+13
|/ | | | | | | | | | | | This commit replaces `tor_netdoc::hsdesc::inner::IntroPointDesc` with the (almost identical) `tor_netdoc::hsdesc::IntroPointDesc`. The only difference between the two structs is that `inner::IntroPointDesc` wraps a `Vec<LinkSpec>` instead of a `Vec<EncodedLinkSpec>`. Since `EncodedLinkSpec` can be derived from `LinkSpec` (and vice-versa), and since `hsdesc::inner::IntroPointDesc` never made it in our public API, this commit also removes `hsdesc::inner::IntroPointDesc` in favour of `hsdesc::IntroPointDesc`.
* Resolve warnings about ambiguous/redundant doc linksNick Mathewson2023-08-221-1/+1
| | | | | Nightly rustdoc now warns if you have a link that isn't necessary, and if you have a link that might refer to two different things.
* tor-bytes: deprecate always_bug with From traitEmil Engler2023-08-171-2/+1
| | | | | | This commit deprecates the `EncodeError::always_bug` function with a `From<EncodeError> for Bug` trait, which is a more semantically correct way to perform this action.
* Run add_warnings on all files.Nick Mathewson2023-08-041-2/+2
|
* Fix typosDimitris Apostolou2023-07-221-1/+1
|
* Merge branch 'explain_952_fix' into 'main'Nick Mathewson2023-07-111-0/+3
|\ | | | | | | | | Explain the code for the #952 fix. See merge request tpo/core/arti!1391
| * Explain the code for the #952 fix.Nick Mathewson2023-07-101-0/+3
| | | | | | | | | | Let's explain what Trinity did in its fix for #952, so that we know why this code is here the next time we find it.
* | Run maint/add_warning to actually apply new lint allowsIan Jackson2023-07-1029-0/+29
|/
* be more lenient while parsing inner hs desctrinity-1686a2023-07-071-1/+6
|
* Run add_warning to remove `missing_panics_doc` deny.Nick Mathewson2023-07-061-1/+0
| | | | Closes #950.
* Fix a rustdoc link.Nick Mathewson2023-06-291-1/+1
|
* Merge branch 'maxintro3' into 'main'Ian Jackson2023-06-293-7/+78
|\ | | | | | | | | tor-netdoc: Handle anomalous numbers of introduction points See merge request tpo/core/arti!1332
| * tor-netdoc: Placate clippy (fmt)Ian Jackson2023-06-281-2/+1
| |
| * tor-netdoc: Placate clippyIan Jackson2023-06-281-2/+1
| |
| * tor-netdoc: Test hsdescs inners with a variety of IPT counts (fmt)Ian Jackson2023-06-281-9/+18
| |
| * tor-netdoc: Test hsdescs inners with a variety of IPT countsIan Jackson2023-06-282-1/+34
| |
| * tor-netdoc: hsdesc: Disregard intro points after the MAX'thIan Jackson2023-06-282-7/+19
| |