| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | tor-netdoc: parse2 derive: deduplicate item accumulation | Ian Jackson | 2025-11-10 | 1 | -31/+35 | |
| | | ||||||
| * | tor-netdoc: parse2 derive: deduplicate item accumulation (prep) | Ian Jackson | 2025-11-10 | 1 | -43/+54 | |
| | | | | | | | | | | Move what is now IF_NONSTRUCTURAL_ACCUMULATE into the common module. It's not yet suitable for reuse. The docs for ACCUMULATE_ITEM_VALUE are still wrong. We'll fix that in a moment. | |||||
| * | tor-netdoc: parse2 derive: Provide dtrace in NetdocParseableFields | Ian Jackson | 2025-11-10 | 1 | -12/+21 | |
| | | | | | | | This was previously only not done because of the need to c&p. Also, we're going to be expanding some common macros that will use it. | |||||
| * | tor-netdoc: parse2 derive: Get rid of $ITEM workaround | Ian Jackson | 2025-11-10 | 1 | -10/+4 | |
| | | | | | The hygiene is fixed in derive-deftly 1.5.x. | |||||
| * | tor-netdoc: Fix typo | Ian Jackson | 2025-11-10 | 1 | -1/+1 | |
| | | ||||||
| * | tor-netdoc: parse2 derive: deduplicate item parsing | Ian Jackson | 2025-11-06 | 1 | -24/+23 | |
| | | ||||||
| * | tor-netdoc: parse2 derive: deduplicate item set selectors | Ian Jackson | 2025-11-06 | 1 | -47/+62 | |
| | | ||||||
| * | tor-netdoc: parse2 derive: deduplicate F_EFFECTIVE_TYPE | Ian Jackson | 2025-11-06 | 1 | -24/+13 | |
| | | ||||||
| * | tor-netdoc: parse2 derive: deduplication: field types and keywords | Ian Jackson | 2025-11-06 | 1 | -36/+39 | |
| | | | | | | | | Have the module expect the use site to determine (mostly) the field kind. Document this expectation. Now NetdocParseableCommon can have the keyword-related definitions. | |||||
| * | tor-netdoc: parse2 derive: deduplication: start a module | Ian Jackson | 2025-11-06 | 2 | -9/+13 | |
| | | | | | Put one textually-identical define in it, to start with. | |||||
| * | Fix name of clippy lint to unchecked_time_subtraction (2) | Ian Jackson | 2025-11-06 | 2 | -2/+2 | |
| | | | | | Run maint/add_warning | |||||
| * | Use a while let loop (to placate clippy) | Ian Jackson | 2025-11-06 | 1 | -2/+1 | |
| | | ||||||
| * | tor-netdoc: Add unit tests for NotPresent and Ignored objects | Ian Jackson | 2025-10-23 | 1 | -1/+32 | |
| | | ||||||
| * | tor-netdoc: Add unit tests for NotPresent items | Ian Jackson | 2025-10-23 | 1 | -0/+4 | |
| | | ||||||
| * | tor-netcoc: Introduce NotPresent, for absent multiplicity | Ian Jackson | 2025-10-23 | 1 | -0/+11 | |
| | | | | | | | | | | Currently this is mishandled: the current use sites (in rs/each_variety.rs) use Option<Ignored>, which would reject repeated items with that keyword, which is technically wrong. And encoing will become a problem. Vec<Ignored> would be wrong too. Instead, broaden NotPresent and give it multiplicity impls. | |||||
| * | tor-netdoc: Move parse2 impls on Ignored to types/misc.rs | Ian Jackson | 2025-10-23 | 1 | -22/+0 | |
| | | | | | | | This seems to be where we're putting most of the parse2 impls on these types, now. That makes more sense as parse2 becomes more of a proper thing. | |||||
| * | tor-netdoc: NetdocParseableFields derive: support flatten (test) | Ian Jackson | 2025-10-22 | 1 | -0/+11 | |
| | | ||||||
| * | tor-netdoc: NetdocParseableFields derive: support flatten | Ian Jackson | 2025-10-22 | 1 | -2/+26 | |
| | | | | | | | | | | This allows a NetdocParseableFields inside a NetdocParseableFields. The code is rather duplicative with the NetdocParseable implementation. This is due to limitations in derive-deftly; see https://gitlab.torproject.org/Diziet/rust-derive-deftly/-/merge_requests/525 where I'm trying to start to address them. | |||||
| * | tor-netdoc: NetdocParseableFields derive: break out kw variable | Ian Jackson | 2025-10-22 | 1 | -1/+3 | |
| | | | | | We're going to reuse this. | |||||
| * | Merge branch 'p2-misc-fixes' into 'main' | opara | 2025-10-21 | 1 | -1/+5 | |
| |\ | | | | | | | | | tor-netdoc: parse2: Minor fixes See merge request tpo/core/arti!3376 | |||||
| | * | tor-netdoc: NetdocParseable derive: use more explicit syntax | Ian Jackson | 2025-10-21 | 1 | -1/+1 | |
| | | | | | | | | | In principle some other trait might be in scope. | |||||
| | * | tor-netdoc: parse2: Don't declare internal error on subdoc intro items | Ian Jackson | 2025-10-21 | 1 | -0/+4 | |
| | | | | | | | | | | | subdoc intro items aren't inherently incoherent, but implementing them is nontrivial. Let's reject them with a bespoke error instead. | |||||
| * | | Merge branch 'p2-blanket-arc' into 'main' | David Goulet | 2025-10-21 | 2 | -7/+30 | |
| |\ \ | | | | | | | | | | | | | tor-netdoc: blanket impl parse2 traits for Arc See merge request tpo/core/arti!3381 | |||||
| | * | | tor-netdoc: blanket impl parse2 traits for Arc | Ian Jackson | 2025-10-21 | 2 | -7/+30 | |
| | |/ | | | | | | | This replaces one ad-hoc impl and will avoid having to have any more. | |||||
| * / | tor-netdoc: parse2: Provide documentation for derived Accumulator types | Ian Jackson | 2025-10-21 | 1 | -0/+3 | |
| |/ | ||||||
| * | tor-netdoc: tests: Move vote parsing test to netstatus.rs | Ian Jackson | 2025-10-15 | 1 | -12/+0 | |
| | | | | | | This is a test of real document structs now, albeit that it still uses one of the types from `poc`. | |||||
| * | tor-netdoc: tests: Use real `RouterStatus` in `parse2::poc` | Ian Jackson | 2025-10-15 | 1 | -9/+7 | |
| | | | | | This now exercises all the new parsing code. | |||||
| * | tor-netdoc: impl parse2 multiplicity for BTreeSet | Ian Jackson | 2025-10-15 | 2 | -1/+34 | |
| | | ||||||
| * | tor-netdoc: impl parse2 traits for protovers | Ian Jackson | 2025-10-15 | 2 | -0/+24 | |
| | | ||||||
| * | tor-netdoc: Provide convenience method for handling invalid arguments | Ian Jackson | 2025-10-15 | 1 | -0/+14 | |
| | | ||||||
| * | tor-netdoc: Replace NdaSystemTimeDeprecatedSyntax with Ios8601TimeSp | Ian Jackson | 2025-10-09 | 1 | -4/+5 | |
| | | | | | | Previously we needed this separate type because Ios8601TimeSp is FromStr which prevented a correct ItemArgumentParseable impl. | |||||
| * | tor-netdoc: parse2: Fix some slips in doc comments | Ian Jackson | 2025-10-09 | 1 | -3/+3 | |
| | | ||||||
| * | tor-netdoc: parse2: Work around MSRV unhelpful lifetime | Ian Jackson | 2025-10-09 | 1 | -2/+6 | |
| | | | | | | | | | | | 1.85.1 rejects this, because it doesn't extend the lifetime of the `format_args!`. 1.90 is fine with it. I want to keep `format!` not `String::new()` so that it's easy to change back. That means a clippy allow. Getting that to apply to the code inside the derive is tricky, so I've enabled it for the whole module. (IMO this clippy lint is pretty annoying anyway.) | |||||
| * | tor-netdoc: parse2 tests: Test ParseError Display and Error impl | Ian Jackson | 2025-10-09 | 1 | -6/+29 | |
| | | ||||||
| * | tor-netdoc: parse2 tests: Have t_err_* return the error | Ian Jackson | 2025-10-09 | 1 | -5/+4 | |
| | | ||||||
| * | tor-netdoc: parse2 tests: Have t_err_* return the error (pre-fmt) | Ian Jackson | 2025-10-09 | 1 | -1/+6 | |
| | | ||||||
| * | tor-netdoc: parse2 tests: Check columns | Ian Jackson | 2025-10-09 | 1 | -7/+15 | |
| | | ||||||
| * | tor-netdoc: parse2 tests: Check columns (pre-fmt) | Ian Jackson | 2025-10-09 | 1 | -1/+2 | |
| | | ||||||
| * | tor-netdoc: parse2: Add column field to PaarsError and print it | Ian Jackson | 2025-10-09 | 1 | -2/+12 | |
| | | ||||||
| * | tor-netdoc: parse2: Add .column() accessor to ErrorProblem | Ian Jackson | 2025-10-09 | 1 | -1/+28 | |
| | | | | | We'll want to general way to find the error problem column. | |||||
| * | tor-netdoc: parse2: Add column field as far as ErrorProblem | Ian Jackson | 2025-10-09 | 2 | -7/+47 | |
| | | | | | | | | Provide facilities in ArgumnetStream for determining the column, and add the field to all the error types up to and including ErrorProblem. The value still needs to be propagated to ParseError, and printed there. | |||||
| * | tor-netdoc: parse2: Replace EP with AE in derive fields rest path | Ian Jackson | 2025-10-09 | 1 | -1/+2 | |
| | | ||||||
| * | tor-netdoc: parse2: Replace EP with AE in NdiDirectorySignature (fmt) | Ian Jackson | 2025-10-09 | 1 | -7/+10 | |
| | | ||||||
| * | tor-netdoc: parse2: Replace EP with AE in NdiDirectorySignature | Ian Jackson | 2025-10-09 | 1 | -4/+4 | |
| | | ||||||
| * | tor-netdoc: Abolish now-obsolete field argument to from_args (fmt) | Ian Jackson | 2025-10-09 | 4 | -29/+7 | |
| | | ||||||
| * | tor-netdoc: Abolish now-obsolete field argument to from_args | Ian Jackson | 2025-10-09 | 7 | -20/+11 | |
| | | ||||||
| * | tor-netdoc: Introduce ArgumentError (fmt) | Ian Jackson | 2025-10-09 | 1 | -3/+1 | |
| | | ||||||
| * | tor-netdoc: Introduce ArgumentError | Ian Jackson | 2025-10-09 | 9 | -33/+84 | |
| | | | | | | This will allow us to (1) move field name handling out of the argument parser method, and also (2) add columns more easily. | |||||
| * | tor-netdoc: Have .reject_extra_args return a bespoke error | Ian Jackson | 2025-10-09 | 3 | -4/+19 | |
| | | | | | | | | We're about to have some functions return ArgumentError and some ErrorProblem. We don't want to provide a conversion directly between these types, so instead introduce a new type that will be convertible to either. | |||||
| * | tor-netdoc: UnparsedItem: Provide .args() accessor | Ian Jackson | 2025-10-09 | 1 | -0/+7 | |
| | | ||||||
