| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
| |
Found by clippy nightly
|
| |
|
|
|
|
|
|
|
|
|
| |
This function will be used to look up a relay by a set of LinkSpecs
given from an incoming HsDesc or INTRODUCE2 message. It differs
from other "lookup relay by IDs" functions in that it needs to be
able to return "here's a relay", "couldn't found a relay", or
"learned that this relay is impossible."
Closes #855: This is the only new API needed for ChanTarget
validation, I think.
|
| |
|
|
|
|
|
|
| |
We'll probably need the hsdir list to be shuffled deterministically for
testing purposes (this might be desirable, for example, when we write a
test for HS descriptor download retries).
Signed-off-by: Gabriela Moldovan <[email protected]>
|
| |
|
|
|
|
| |
lifetime configurable.
Signed-off-by: Gabriela Moldovan <[email protected]>
|
| |
|
|
|
|
| |
Now that we require a version of Rust that allows
`b.then_some(v)`, clippy complains about our use of
`b.then(|| v)`.
|
| |\
| |
| |
| |
| | |
Download HS descriptors
See merge request tpo/core/arti!1118
|
| | |
| |
| |
| | |
We'll add this later, about here.
|
| | | |
|
| | |
| |
| |
| | |
This is the HsDirIndex, not the Hs[Blind]Id.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With this
cargo +stable clippy --locked --offline -p tor-netdir --features=hs-client --all-targets
I got this:
64 | use {hsdir_params::HsDirParams, hsdir_ring::HsDirRing, itertools::chain, std::iter};
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
| | |
| |
| |
| | |
Fixes a rustdoc warning.
|
| |/
|
|
| |
Fixes a rustdoc warning.
|
| |
|
|
|
| |
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1094#note_2891857
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Don't have it take the TP, so that the caller must call it multiple
times. Instead, have it return all the relevant relays.
|
| |
|
|
|
|
|
|
| |
I don't think the server-side support will want to explicitly call
current and then secondary. Rather, it will want to iterate over all
the relevant ones.
And fix the name, and add another comment about whether we need this.
|
| |
|
|
|
|
|
|
| |
Change its name to hs_* like we do with things at this layer.
But, it turns out, that at least for hs client connections to fetch
the descriptor, I don't seem to need to call it yet ? Maybe it's not
needed.
|
| |
|
|
|
| |
* Change its name to Hs* like we do with things at this layer
* Make the Upload variant cfg-conditional
|
| |
|
|
|
| |
Provide iter_for_op, by changing iter into iter_filter_secondary and
having a new entrypoint iter.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
There are too many things called "index" here. `idx` could be read to
mean the table index `RouterStatusIdx`, the hsdir hash `HsDirIndex`,
or an entry in some other one of these tables.
Here's, it's just the sequence number of the index in the test netdir.
Use `pos` for that. (`seq` would have been another possibility.)
|
| |
|
|
|
| |
This was removed in c3e74973b4201f71275d8cf4c0c954cfb8d0eba5
netdir: Use an even smaller rep for list of microdescs
|
| |
|
|
|
|
|
|
|
| |
This is an `IndexVec` key type. Some places used `idx`, some `rsi`,
some `rs_idx`.
Use `rsidx` for it everywhere, including in locals, function names,
and fields. `rsidx` is a compromise. `rsi` might be a bit opaque,
but we want a one-"word" name since it appears inside other names.
|
| |
|
|
| |
Fixes #756
|
| | |
|
| |
|
|
|
| |
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1012#note_2876824
|
| | |
|
| | |
|
| |
|
|
|
| |
Deferred formatting changes which would have obscured the commits they
were prompted by.
|
| | |
|
| |
|
|
|
|
| |
* Provide an accessor for the HSDIR flag
* Provide a function for testing a relay for hsdir inclusion
* Provide an iterator on NetDir that returns the hsdirs
|
| |
|
|
|
|
|
|
|
|
|
| |
* Implement Netdir::compute_rings in terms of a new
HsDirRing::compute, that currently does nothing.
* Actually call Netdir::compute_rings (since now it doesn't panic).
* Make Netdir::compute_rings not be pub. We do this unconditionally,
rather than exposing the distinction between a netdir-without-hsdir
and a netdir-with-hsdir.
|
| |
|
|
|
| |
This already allows us to get rid of some duplication, and will be
useful more widely in a moment.
|
| |
|
|
|
|
|
|
|
| |
The file which contains this type is called hsdir_params.rs. We have
a general problem with slight confusion about when to includen "dir"
and when to include "ring".
Resolve this in favour of the rule now added to the module-level doc
comment.
|
| |
|
|
|
|
|
|
|
|
| |
These variables are going to be struct fields, which will sort of
enforce consistent naming. The struct fields are going to appear in a
moment. We'll call the fields "current" and "secondary" after the
naming in the test cases.
And import hsdir_params::HsRingParams, which we're going to make more
references to.
|
| |
|
|
|
|
| |
This will enable us to pass these around more conveniently.
And make empty_from_params take an owned params, which it would like.
|
| | |
|
| |
|
|
| |
We'll need this shortly.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove the return value, which was not used anywhere.
Also remove the code to calculate the return value.
* Take an Arc<NetDir> rather than a reference. We are going to want
this for HS support. This has no overall effect on the lifetime of
the4 Arc, which was owned at the one call site and then imediately
dropped.
* Change the documentation to explain what the function's role is in
the netdir API, rather than the fiddly details of what it actually
does internally. Relegate the latter to a code comment.
(When we have HS, this will do more, or, at least, make further
arrangements.)
|
| | |
|
| |
|
|
|
|
| |
Always use "index" and not "position".
Remove wording which is otiose given the type name.
|
| | |
|
| | |
|
| |
|
|
|
| |
Call it everywhere instead of the inherent method on MdConsensus.
(Verified by ad-hoc temporarily renaming MdConsensus::relays().)
|
| |
|
|
|
|
|
| |
As per
https://gitlab.torproject.org/tpo/core/arti/-/issues/756
I think this is going in the wrong direction, but it is better to fix
it so that the names agree for now, pending a decision on the naming.
|
| | |
|