| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | tor-keymgr: Add an Arti keystore error type for keys with invalid key data. | Gabriela Moldovan | 2023-11-21 | 1 | -0/+5 | |
| | | | | ||||||
| | * | | tor-keymgr: Remove a TODO that is no longer relevant. | Gabriela Moldovan | 2023-11-21 | 1 | -3/+0 | |
| | | | | | | | | | | | | | | | | | | | `KeystoreCorruptionError` is now part of `tor_keymgr::Error` and no longer implements `KeystoreError` (the `KeystoreError` trait is now only for keystore-specific errors). | |||||
| | * | | tor-keymgr: Remove unnecessary trait function. | Gabriela Moldovan | 2023-11-21 | 1 | -7/+0 | |
| | | | | | | | | | | | | | We don't use this anymore. | |||||
| | * | | tor-keymgr: Add a top-level error type (fmt). | Gabriela Moldovan | 2023-11-21 | 1 | -1/+4 | |
| | | | | ||||||
| | * | | tor-keymgr: Add a top-level error type. | Gabriela Moldovan | 2023-11-21 | 4 | -32/+42 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the `tor_keymgr::Error` type was `Box<dyn KeystoreError>`. This forced us to impl `KeystoreError` for any error returned by the keymgr (including those that were not coming from a `Keystore` impl). Now, `tor_keymgr::Error` is an non-exhaustive enum and the `Box<dyn KeystoreError>` opaque error type is only returned from `Keystore` impls The reason we're keeping the `dyn KeystoreError` error type is because it enables `Keystore` implementors to use their own error types. Without it, they would have to choose from our (closed) set of error variants, which may not be suitable for their keystore. See #901. | |||||
| | * | | tor-keymgr: Add some derives for the dummy KeyType. | Gabriela Moldovan | 2023-11-21 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | We are about to add a top-level `tor_keymgr::Error` enum that has a variant that contains a `KeyType`. The error enum needs to be `Clone`, so we need `KeyType` (both the dummy version and the "real" one, because the `err` module is not cfg'd behind the `keymgr` feature) to be `Clone`. | |||||
| | * | | tor-keymgr: Move ArtiPathError, KeystoreCorruptionError to err.rs. | Gabriela Moldovan | 2023-11-21 | 3 | -54/+53 | |
| | | | | | | | | | | | | | | | | | | | KeystoreCorruptionError is about to become a variant of the top-level keymgr Error enum (which doesn't exist yet but will be introduced in a future commit). | |||||
| | * | | tor-keymgr: Inline SshKeyError variants into ArtiNativeKeystoreError. | Gabriela Moldovan | 2023-11-20 | 2 | -43/+34 | |
| | |/ | | | | | | | An `SshKeyError` *is* an Arti keystore error, so let's unify the two. | |||||
| * / | tor-keymgr: impl ToEncodableKey for IPT keys | Ian Jackson | 2023-11-23 | 1 | -1/+25 | |
| |/ | ||||||
| * | Merge branch 'more-denotators' into 'main' | gabi-250 | 2023-11-20 | 1 | -14/+83 | |
| |\ | | | | | | | | | | | | | tor-keymgr: Support encoding more than one denotator in an ArtiPath. Closes #1093 and #1112 See merge request tpo/core/arti!1747 | |||||
| | * | tor-keymgr: Update ArtiPath docs. | Gabriela Moldovan | 2023-11-20 | 1 | -5/+9 | |
| | | | ||||||
| | * | tor-keymgr: Remove now-outdated TODO HSSs. | Gabriela Moldovan | 2023-11-20 | 1 | -6/+0 | |
| | | | ||||||
| | * | tor-keymgr: Support encoding more than one denotator in an ArtiPath. | Gabriela Moldovan | 2023-11-20 | 1 | -3/+74 | |
| | | | | | | | | | Closes arti#1112 | |||||
| * | | Merge branch 'deprecate-hs-client-intro-auth' into 'main' | gabi-250 | 2023-11-20 | 1 | -14/+2 | |
| |\ \ | |/ |/| | | | | | | | | | tor-hscrypto: Deprecate HsClientIntroAuth{Key, Keypair}. Closes #1037 See merge request tpo/core/arti!1749 | |||||
| | * | tor-keymgr: Remove the ToEncodableKey impl of HsClientIntroAuthKeypair. | Gabriela Moldovan | 2023-11-20 | 1 | -15/+0 | |
| | | | | | | | | | | | `HsClientIntroAuthKeypair` is deprecated and no longer used as an "encodable key". | |||||
| | * | tor-keymgr: Allow the use of the newly deprecated HsClientIntroAuthKeypair ↵ | Gabriela Moldovan | 2023-11-20 | 1 | -4/+4 | |
| | | | | | | | | | (fmt). | |||||
| | * | tor-keymgr: Allow the use of the newly deprecated HsClientIntroAuthKeypair. | Gabriela Moldovan | 2023-11-20 | 1 | -1/+4 | |
| | | | ||||||
| * | | tor-keymgr: Add TODO about possibly abolishing arti_pattern. | Gabriela Moldovan | 2023-11-20 | 1 | -0/+3 | |
| | | | ||||||
| * | | tor-keymgr: Make the arti_path_prefix() helper private. | Gabriela Moldovan | 2023-11-20 | 1 | -1/+1 | |
| | | | ||||||
| * | | tor-keymgr: Abolish the `role()` public key specifier function. | Gabriela Moldovan | 2023-11-20 | 1 | -9/+0 | |
| | | | | | | | | | We don't use this anymore. | |||||
| * | | tor-keymgr: Use ${for fields} to count the number of denotators (fmt). | Gabriela Moldovan | 2023-11-20 | 1 | -5/+4 | |
| | | | ||||||
| * | | tor-keymgr: Use ${for fields} to count the number of denotators. | Gabriela Moldovan | 2023-11-20 | 1 | -8/+3 | |
| | | | ||||||
| * | | tor-keymgr: Refactor a commonly used condition into a defcond. | Gabriela Moldovan | 2023-11-20 | 1 | -5/+8 | |
| | | | ||||||
| * | | tor-keymgr: Apply review suggestions to various doc comments. | Gabriela Moldovan | 2023-11-20 | 2 | -6/+13 | |
| | | | ||||||
| * | | tor-keymgr: Do not require owned types in arti_pattern(). | Gabriela Moldovan | 2023-11-20 | 1 | -3/+3 | |
| | | | | | | | | | This also fixes a clippy warning about a needless borrow. | |||||
| * | | tor-keymgr: Suppress a confused clippy warning. | Gabriela Moldovan | 2023-11-20 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | Clippy is wrong here: it's complaining about us not using `$crate`, when we _are_ using `$crate`. See https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1733#note_2965924 | |||||
| * | | tor-keymgr: Remove unused macro. | Gabriela Moldovan | 2023-11-20 | 1 | -241/+0 | |
| | | | ||||||
| * | | tor-keymgr: Rewrite define_key_specifier using derive-adhoc (fmt). | Gabriela Moldovan | 2023-11-20 | 1 | -37/+36 | |
| | | | ||||||
| * | | tor-keymgr: Rewrite define_key_specifier using derive-adhoc. | Gabriela Moldovan | 2023-11-20 | 3 | -18/+151 | |
| | | | | | | | | | | | | | | | | | For the most part, this is just code movement. The implementation was copied over to `define_derive_adhoc` from `define_key_specifier`, with some minor adjustments that were needed to make it compile. Closes #1093 | |||||
| * | | tor-keymgr: Add tests for arti_prefix(). | Gabriela Moldovan | 2023-11-20 | 1 | -0/+11 | |
| | | | ||||||
| * | | tor-keymgr: Add tests for arti_pattern(). | Gabriela Moldovan | 2023-11-20 | 1 | -0/+15 | |
| |/ | | | | | | | | | `T::arti_pattern()` returns an `ArtiPath` pattern that can can match any key of type `T`, regardless of the values of its denotators (the denotators are replaced by wildcards in the pattern). These tests will allow us to check we're not breaking pattern matching when we transition to derive-adhoc. | |||||
| * | Upgrade to itertools 0.12.0 | Nick Mathewson | 2023-11-15 | 1 | -1/+1 | |
| | | ||||||
| * | tor-keymgr: Add missing backticks (fmt). | Gabriela Moldovan | 2023-11-13 | 2 | -3/+2 | |
| | | ||||||
| * | tor-keymgr: Add missing backticks. | Gabriela Moldovan | 2023-11-13 | 1 | -2/+2 | |
| | | ||||||
| * | tor-keymgr: Move module-level docs to KeyMgr. | Gabriela Moldovan | 2023-11-13 | 1 | -13/+13 | |
| | | | | | The module is private so it won't show up in the public docs. | |||||
| * | tor-keymgr: Expand the ArtiNativeKeystore docs. | Gabriela Moldovan | 2023-11-13 | 1 | -1/+19 | |
| | | ||||||
| * | tor-keymgr: Clarify how the default/secondary stores are used. | Gabriela Moldovan | 2023-11-13 | 1 | -2/+25 | |
| | | ||||||
| * | tor-keymgr: Mention the custom SSH algorithm name for expanded ed keys. | Gabriela Moldovan | 2023-11-13 | 1 | -1/+2 | |
| | | ||||||
| * | tor-keymgr: Clarify what ArtiPath are used for. | Gabriela Moldovan | 2023-11-13 | 2 | -2/+7 | |
| | | ||||||
| * | tor-keymgr: Add some doctests. | Gabriela Moldovan | 2023-11-13 | 1 | -0/+35 | |
| | | ||||||
| * | tor-keymgr: Abolish KeyPathPatternSet. | Gabriela Moldovan | 2023-11-13 | 3 | -56/+36 | |
| | | | | | | | We don't really need it. Closes #1066 | |||||
| * | tor-keymgr: Downgrade a TODO HSS to TODO. | Gabriela Moldovan | 2023-11-13 | 1 | -1/+1 | |
| | | ||||||
| * | tor-keymgr: Add TODO about adding helper for implementing KeyDenotator. | Gabriela Moldovan | 2023-11-02 | 1 | -0/+2 | |
| | | ||||||
| * | tor-keymgr: Map all errors to KeystoreCorruptionError (fmt). | Gabriela Moldovan | 2023-11-02 | 1 | -4/+2 | |
| | | ||||||
| * | tor-keymgr: Map all errors to KeystoreCorruptionError. | Gabriela Moldovan | 2023-11-02 | 1 | -2/+2 | |
| | | ||||||
| * | tor-keymgr: Use KeystoreCorruptionError instead of internal!. | Gabriela Moldovan | 2023-11-02 | 1 | -3/+3 | |
| | | ||||||
| * | tor-keymgr: Add an error type for keystore corruption (fmt). | Gabriela Moldovan | 2023-11-02 | 2 | -4/+4 | |
| | | ||||||
| * | tor-keymgr: Add an error type for keystore corruption. | Gabriela Moldovan | 2023-11-02 | 2 | -1/+30 | |
| | | ||||||
| * | tor-keymgr: Use ArrayVec to avoid an unnecessary allocation. | Gabriela Moldovan | 2023-11-02 | 2 | -2/+4 | |
| | | ||||||
| * | tor-keymgr: Use parse() instead of from_str(). | Gabriela Moldovan | 2023-11-02 | 1 | -5/+3 | |
| | | ||||||
