| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | tor-key-forge: Replace EncodableItem::key_type() with item_type(). | Gabriela Moldovan | 2024-12-04 | 2 | -19/+19 | |
| | | | | | | This function now returns a `KeystoreItemType`, enabling us to represent certs as `EncodableItem`s. | |||||
| * | tor-keymgr: Update docs post-renaming. | Gabriela Moldovan | 2024-12-04 | 1 | -9/+9 | |
| | | ||||||
| * | tor-keymgr: Replace KeyType with KeystoreItemType (fmt). | Gabriela Moldovan | 2024-12-04 | 7 | -21/+70 | |
| | | ||||||
| * | tor-keymgr: Remove now-unused import. | Gabriela Moldovan | 2024-12-04 | 1 | -1/+1 | |
| | | ||||||
| * | tor-key-forge: Remove no longer needed KeyType::Unknown variant. | Gabriela Moldovan | 2024-12-04 | 1 | -14/+0 | |
| | | | | | | Items that have an unrecognized file extension now get mapped to `KeystoreItemType::Unknown`. | |||||
| * | tor-keymgr: Replace KeyType with KeystoreItemType. | Gabriela Moldovan | 2024-12-04 | 9 | -148/+172 | |
| | | | | | | This is part of the work needed to support storing certificates in the keystore (they won't have a `KeyType`, but rather `CertType`). | |||||
| * | tor-key-forge: Rename EncodableKey to EncodableItem. | Gabriela Moldovan | 2024-12-04 | 8 | -27/+27 | |
| | | | | | | | | | This is the first step in replacing `EncodableKey` with the new `EncodableItem` trait (see doc/dev/keymgr-certificates.md). (this refactoring is split over multiple commits to make reviewing easier) | |||||
| * | tor-keymgr: Add a KeyCertificateSpecifier trait (fmt). | Gabriela Moldovan | 2024-12-04 | 1 | -3/+2 | |
| | | ||||||
| * | tor-keymgr: Add a KeyCertificateSpecifier trait. | Gabriela Moldovan | 2024-12-04 | 2 | -0/+28 | |
| | | | | | This will be used for defining key certificate specifiers. | |||||
| * | add_warnings, *: Allow clippy::needless_lifetimes | Nick Mathewson | 2024-12-03 | 1 | -0/+1 | |
| | | | | | | | | | In 1.83, this warning triggers on many of our crates. We're thinking of fixing them all, but for now, we're going to disable the warning. This is part of #1765. | |||||
| * | tor-keymgr: Remove now-unnecessary cfg_attr. | Gabriela Moldovan | 2024-11-20 | 1 | -6/+0 | |
| | | | | | This doesn't seem to be needed anymore. | |||||
| * | tor-keymgr: Remove now-unnecessary clippy allows from dummy impl. | Gabriela Moldovan | 2024-11-20 | 1 | -2/+0 | |
| | | ||||||
| * | tor-keymgr: Feature-gate RelKeyPath::from_parts constructor. | Gabriela Moldovan | 2024-11-20 | 1 | -0/+1 | |
| | | | | | | Otherwise, we get a dead code warning when the `ctor-keystore` feature is disabled. | |||||
| * | tor-keymgr: Allow dead code in dummy KeyMgr. | Gabriela Moldovan | 2024-11-20 | 1 | -0/+2 | |
| | | | | | | | | | | The fields are never read but need to be present in order for the dummy `KeyMgrBuilder` to have the same interface as the real one. (We could of course manually implement the builder, or let the dummy `KeyMgrBuilder` impl diverge from the real one, but for now let's leave this as-is and simply mark the fields as unused). | |||||
| * | tor-keymgr: Remove unused dummy error type. | Gabriela Moldovan | 2024-11-20 | 1 | -16/+1 | |
| | | | | | | We no longer have any dummy keymgr operations that return an error, so this error type is unused. | |||||
| * | tor-keymgr: Remove unused imports from dummy module. | Gabriela Moldovan | 2024-11-20 | 1 | -2/+1 | |
| | | ||||||
| * | tor-keymgr: Remove unused dummy KeyType. | Gabriela Moldovan | 2024-11-20 | 1 | -14/+0 | |
| | | | | | This is not used anywhere (or exported publicly). | |||||
| * | tor-keymgr: Say that another option is to enable keymgr unconditionally. | Gabriela Moldovan | 2024-11-14 | 1 | -0/+2 | |
| | | | | | | This commit applies Diziet's suggestion from https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2631#note_3130234 | |||||
| * | tor-keymgr: Remove a couple of dummy KeyMgr functions. | Gabriela Moldovan | 2024-11-14 | 1 | -14/+0 | |
| | | | | | | | | These are not actually needed anywhere. In fact, it's a bad idea to have them in the first place (see the comment from the dummy `KeyMgr` impl block). | |||||
| * | tor-keymgr: Explain why the dummy keymgr is missing some functions. | Gabriela Moldovan | 2024-11-14 | 1 | -1/+28 | |
| | | | | | | | | | This is based on a recent discussion with @Diziet on IRC. For the full context, see the chat log attached to the ticket. Closes #1732 | |||||
| * | tor-config: removed re-export of `CfgPath` | Steven Engler | 2024-11-04 | 1 | -1/+2 | |
| | | | | | | Also updated other packages to get `CfgPath` directly from `tor-config-path' instead of 'tor-config'. | |||||
| * | Disable a lot of dead code warnings (fmt) | Ian Jackson | 2024-10-17 | 1 | -1/+4 | |
| | | ||||||
| * | Disable a lot of dead code warnings | Ian Jackson | 2024-10-17 | 1 | -0/+3 | |
| | | | | | | | | Now cargo check --workspace --no-default-features --all-targets cargo build -p arti --no-default-features --features=memquota,tokio,native-tls are both clean. | |||||
| * | tor-keymgr: Reformat a long line for readability. | Gabriela Moldovan | 2024-10-15 | 1 | -1/+3 | |
| | | | | | This breaks up a long statement to improve readability. | |||||
| * | tor-keymgr: Add missing docs for keypair_specifier. | Gabriela Moldovan | 2024-10-15 | 1 | -0/+12 | |
| | | | | | | This is a follow-up to !2393, which added support for the `key_specifier` top-level attribute. | |||||
| * | tor-config: Fix indentation in doc comment. | Gabriela Moldovan | 2024-10-09 | 1 | -1/+1 | |
| | | | | | | | It looks like my previous attempt from !2516 didn't fix it. This adds an extra space to fix the `doc_lazy_continuation` lint. | |||||
| * | tor-keymgr: Fix indentation in doc comment. | Gabriela Moldovan | 2024-10-09 | 1 | -1/+1 | |
| | | | | | | Addresses the `doc_lazy_continuation` lint, fixing the `rust-latest` job that's currently failing on main. | |||||
| * | tor-keymgr: Move C Tor keystore configs under ctor key (fmt). | Gabriela Moldovan | 2024-10-08 | 1 | -5/+10 | |
| | | ||||||
| * | tor-keymgr: Move C Tor keystore configs under ctor key. | Gabriela Moldovan | 2024-10-08 | 1 | -35/+46 | |
| | | | | | | | | This way we have a more intuitive layout, where all C Tor keystore configuration is under the `ctor` key. Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2481#note_3090486 | |||||
| * | tor-keymgr: Add tests for CTorServiceKeystore. | Gabriela Moldovan | 2024-10-08 | 1 | -1/+148 | |
| | | ||||||
| * | tor-keymgr: Add tests for CTorClientKeystore. | Gabriela Moldovan | 2024-10-08 | 3 | -2/+179 | |
| | | ||||||
| * | tor-keymgr: Move assert_found helper to test_utils. | Gabriela Moldovan | 2024-10-08 | 2 | -14/+24 | |
| | | | | | | This moves `assert_found` out of the `keystore::arti::test` so we can reuse it for testing other keystore implementations too. | |||||
| * | tor-keymgr: Add tests for the keystore config. | Gabriela Moldovan | 2024-10-08 | 1 | -0/+164 | |
| | | ||||||
| * | tor-keymgr: Validate keystore ID uniqueness in ArtiKeystoreConfigBuilder. | Gabriela Moldovan | 2024-10-08 | 1 | -1/+23 | |
| | | ||||||
| * | arti-client, tor-keymgr: Remove a couple of now-addressed TODOs. | Gabriela Moldovan | 2024-10-08 | 1 | -5/+0 | |
| | | ||||||
| * | arti-client: Use the configured C Tor client keystores. | Gabriela Moldovan | 2024-10-08 | 2 | -2/+2 | |
| | | ||||||
| * | tor-keymgr: Add configuration for C Tor client keystores. | Gabriela Moldovan | 2024-10-08 | 1 | -0/+82 | |
| | | | | | | This is intentionally partially mis-indented to make this more reviewable (in case the reviewer isn't using `ignore-all-space`). | |||||
| * | arti-client: Use the configured C Tor keystores, if any. | Gabriela Moldovan | 2024-10-08 | 1 | -0/+4 | |
| | | ||||||
| * | tor-keymgr: Derive Getters for CTorKeystoreConfig. | Gabriela Moldovan | 2024-10-08 | 1 | -1/+1 | |
| | | ||||||
| * | tor-keymgr: Derive Getters for the ArtiKeystoreConfig. | Gabriela Moldovan | 2024-10-08 | 1 | -1/+2 | |
| | | ||||||
| * | tor-keymgr: Add a keystore for C Tor client keys. | Gabriela Moldovan | 2024-10-08 | 3 | -0/+330 | |
| | | ||||||
| * | tor-keymgr: Add a keystore for C Tor service keys. | Gabriela Moldovan | 2024-10-08 | 4 | -0/+478 | |
| | | ||||||
| * | tor-keymgr: Rename Filesystem variant to Io for clarity (fmt). | Gabriela Moldovan | 2024-10-08 | 2 | -44/+57 | |
| | | ||||||
| * | tor-keymgr: Rename Filesystem variant to Io for clarity. | Gabriela Moldovan | 2024-10-08 | 2 | -3/+3 | |
| | | | | | | The `FilesystemError::Filesystem` variant was actually just for IO errors. | |||||
| * | tor-keymgr: Refactor common fs errors into a separate error enum. | Gabriela Moldovan | 2024-10-08 | 3 | -76/+96 | |
| | | | | | | | | | This will be reused by other on-disk key stores (such as the C Tor ones we're about to add). I recommend reviewing this commit using `git diff --color-moved=zebra --ignore-space-change` | |||||
| * | tor-keymgr: Add RelKeyPath::from_parts constructor. | Gabriela Moldovan | 2024-10-08 | 1 | -0/+5 | |
| | | | | | This will be used to create relative paths representing C Tor keys. | |||||
| * | tor-keymgr: Rename RelKeyPath::new to RelKeyPath::arti. | Gabriela Moldovan | 2024-10-08 | 2 | -3/+3 | |
| | | | | | We're about to add a separate constructor for CTor paths. | |||||
| * | tor-keymgr: Move the checked_op utils out of the arti module. | Gabriela Moldovan | 2024-10-08 | 3 | -10/+16 | |
| | | | | | We are about to use this for the ctor keystore implementation too. | |||||
| * | tor-keymgr: Rename KeyPathRange to ArtiPathRange (fmt). | Gabriela Moldovan | 2024-10-08 | 2 | -5/+5 | |
| | | ||||||
| * | tor-keymgr: Rename KeyPathRange to ArtiPathRange. | Gabriela Moldovan | 2024-10-08 | 3 | -8/+8 | |
| | | | | | | This is only used for representing portions of `ArtiPath`s, so let's rename it accordingly. | |||||
