| Commit message (Collapse) | Author | Age | Files | Lines |
| | |
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
|
|
| |
This currently can't be used due to upstream limitations in the ssh_key
crate, which will be removed likely in the next release. In the
meantime, we can put in all the groundwork.
|
| |
|
|
| |
This feature has been removed from nightly, in favor of doc_cfg.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
```text
error: implicitly cloning a `String` by calling `to_string` on its dereferenced type
--> crates/tor-config/src/lib.rs:109:32
|
109 | V::String(_, s) => s.to_string(),
| ^^^^^^^^^^^^^ help: consider using: `s.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
note: the lint level is defined here
--> crates/tor-config/src/lib.rs:20:9
|
20 | #![deny(clippy::implicit_clone)]
| ^^^^^^^^^^^^^^^^^^^^^^
```
|
| |
|
|
|
|
|
|
|
|
| |
The two main causes of errors were:
- Since some of the lifetime rules have changed, we no longer need
to do as many "bind a variable and immediately return it"
patterns, and so clippy now warns about them.
- We needed to adjust the explicit captures (`use<...>`)
in a couple of our RPIT instances.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Run cargo fix --edition
2. Selectively revert the "if let"->"match" changes.
These changes are meant to protect us from the lifetime changes
for "if let" bindings in Rust 2024.
But we're not actually relying on the old lifetime rules
anywhere, and the match syntax here is quite ugly.
3. Automatically revert `$pat:expr_2021` to `$pat:expr`.
(We don't actually want to restrict the expression syntax
that our macros accept).
Done with
`git grep -l expr_2021 | xargs perl -i -pe 's/expr_2021/expr/g;'`
4. Run cargo fmt.
|
| | |
|
| |
|
|
| |
Closes #2012.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CLI: Add `keys-raw` and subcommand `remove-by-path`
* arti: Add `arti::subcommand::raw` for the CLI `keys-raw`
* tor-keymgr: Add `ArtiNativeKeystoreError::UnexpectedRawEntry`,
`ArtiEphemeralKeystoreError::NotSupported`
* tor-keymgr: Add `tor-keymgr::raw` module
* tor-keymgr: Add `Keystore::remove_unchecked`
* tor-keymgr: Change `Keystore::list` to return `KeystoreEntry`
* tor-keymgr: Add field `KeystoreEntry::raw_id`
* doc: Update keys.md
* doc: Add raw.md
* tor-keymgr: BREAKING: `UnrecognizedEntryError::new` associated
function is now only accessible within the crate `tor-keymgr`
* tor-keymgr: BREAKING: `UnrecognizedEntryId` is renamed to
`UnrecognizedEntry`
* tor-keymgr: BREAKING: `KeyMgr::list()` and `Keystore::list()`
now return `Result<Vec<KeystoreEntryResult<KeystoreEntry>>>`
|
| |\
| |
| |
| |
| | |
Typo fixes (automatic and hand-verified)
See merge request tpo/core/arti!3089
|
| | |
| |
| |
| | |
Made with https://crates.io/crates/typos-cli
|
| |/ |
|
| |
|
|
| |
See #2060.
|
| | |
|
| |
|
|
|
| |
* Change return type `Result<Vec<(KeyPath, KeystoreItemType)>>` if favor
of `Result<Vec<StdResult<(KeyPath, KeystoreItemType), UnrecognizedEntryError>>>`
|
| |
|
|
|
|
|
| |
The `IoError::other` function is an easier way to say
`IoError::new(IoErrorKind::Other, ...)`. It's been around since
1.74, but clippy started warning about the more verbose version in
1.87.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Drop redundant/unused param item_type: &KeystoreItemType from
keystore::Keystore::insert. Method now uses param
key: &dyn EncodableItem to obtain a KeystoreItemType
|
| |
|
|
|
|
|
|
| |
Motivation: Param _item_type is redundant since prev commit. No point
in checking if key_data's item type and _item_type are the same, we
do things as per key_data's item type from now on.
- Removes a test for item type validation.
|
| |
|
|
| |
Makes param item_type redundant. Renames item_type -> _item_type.
|
| |\
| |
| |
| |
| | |
Add some allow(unused)
See merge request tpo/core/arti!2893
|
| | |
| |
| |
| |
| | |
Fixes several warnings from
cargo check --workspace --no-default-features
|
| | |
| |
| |
| | |
Closes #1455
|
| | |
| |
| |
| | |
Closes #1455 [PATCH 4(v3)/4]
|
| | |
| |
| |
| | |
Part of #1455 [PATCH 3(v3)/4]
|
| | |
| |
| |
| | |
Part of #1455
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Closes #1455 [PATCH 4(v2)/4]
|
| | |
| |
| |
| | |
Part of #1455 [PATCH 3(v2)/4]
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Part of #1455 [PATCH 2(v2)/4]
- Rework sshkeygen::ed25519_encoded to also work as replacement for
sshkeygen::exists
- Drop sshkeygen::exists
- Rename sshkeygen::{ed25519_encoded -> sshkeygen_ed25519_strings}
- Pull out sshkeygen_ed25519_strings from mod sshkeygen
- Drop mod sshkeygen
|
| | |
| |
| |
| | |
_sigh_
|
| | |
| |
| |
| | |
Closes #1455 [PATCH 4/4]
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Part of #1455 [PATCH 3/4]
Abstract of the test(s):
Encoded (key) A -> Decoded (key) A
Decoded A -> Encoded B
Encoded B -> Decoded B
Assert that Decoded A == Decoded B
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Part of #1455 [PATCH 2/4]
Utils include:
- mod sshkeygen
- sshkeygen::exists - check if ssh-keygen is available
- sshkeygen::ed25519_encoded - generate encoded Ed25519 keys
|
| |/
|
|
|
|
|
| |
TestSpecifier::new(prefix: ...) -> new(suffix: ...)
Prefix is given by TestSpecifier::path_prefix() which returns
const TEST_SPECIFIER_PATH = "..."
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
We want to require that whenever we generate a key that's persistent
(stored in KeyMgr), it's going to be made from a stronger-than-usual
Rng. This trait helps us enforce that.
We also add a FakeEntropicRng struct to use for testing.
Note that this turned up a case that we'd missed, which required
an internal change in tor-hsservice.
|
| |
|
|
| |
- `rand::thread_rng()` has been deprecated and renamed to `rand::rng()`
|
| |\
| |
| |
| |
| |
| |
| | |
tor-keymgr: Resolve TODOs from key_specifier::tests
Closes #1889
See merge request tpo/core/arti!2849
|
| | | |
|