| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | tor-keymgr: Fix two docs links | Ian Jackson | 2024-02-05 | 2 | -2/+2 |
| | | | | | (These were broken by recent MRs so don't need a CHANGELOG update in !1950.) | ||||
| * | tor-keymgr: Apply cargo fmt. | Gabriela Moldovan | 2024-02-01 | 1 | -1/+0 |
| | | |||||
| * | tor-keymgr: Expand the KeyAlreadyExists docs. | Ian Jackson | 2024-02-01 | 1 | -0/+7 |
| | | |||||
| * | tor-keymgr: Abolish get_or_generate_with_derived. | Gabriela Moldovan | 2024-02-01 | 1 | -58/+1 |
| | | |||||
| * | tor-keymgr: Rewrite get_or_generate() using of get() and generate(). | Gabriela Moldovan | 2024-02-01 | 1 | -6/+15 |
| | | | | | | We are about to remove `KeyMgr::get_or_generate_with_derived`, so this rewrites `KeyMgr::get_or_generate` without using it. | ||||
| * | tor-keymgr: Abolish KeyMgr::generate_with_derived. | Gabriela Moldovan | 2024-02-01 | 1 | -155/+24 |
| | | |||||
| * | tor-keymgr: Make KeyMgr::generate return the generated key. | Gabriela Moldovan | 2024-02-01 | 1 | -4/+12 |
| | | | | | | | | `KeyMgr::generate` is now quite similar to `KeyMgr::get_or_generate`, so we will soon remove the latter. Part of #1074 | ||||
| * | tor-keymgr: Add error variant for when a key shouldn't exist. | Gabriela Moldovan | 2024-02-01 | 1 | -0/+5 |
| | | | | | | | | This will be returned by `KeyMgr::generate` if the key to be generated already exists and `overwrite` is `false`. Part of #1074 | ||||
| * | tor-keymgr: Lowercase the role when building the ArtiPath. | Gabriela Moldovan | 2024-01-31 | 1 | -9/+2 |
| | | | | | | | | The role is a slug, and slugs are not allowed to contain uppercase characters. Closes #1195 | ||||
| * | tor-persist: Make all Slugs non-empty. | Gabriela Moldovan | 2024-01-31 | 2 | -5/+12 |
| | | | | | | | | | This also removes a TODO regarding adding a `Nickname` type for representing `HsClientSpecifier` and `HsNickname` (we don't need it if `Slug`s are non-empty). Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1931#note_2990227 | ||||
| * | tor-keymgr: Add roundrip test for HsId -> Slug -> HsId conversion. | Gabriela Moldovan | 2024-01-31 | 1 | -1/+22 |
| | | | | | This also fixes a bug in `HsId::from_component`. | ||||
| * | tor-keymgr: Allow empty denotators in ArtiPath (fmt). | Gabriela Moldovan | 2024-01-31 | 1 | -8/+2 |
| | | |||||
| * | tor-keymgr: Allow empty denotators in ArtiPath. | Gabriela Moldovan | 2024-01-31 | 2 | -11/+7 |
| | | |||||
| * | tor-persist: Forbid slugs from starting with a hyphen. | Gabriela Moldovan | 2024-01-31 | 1 | -3/+22 |
| | | |||||
| * | tor-keymgr: Add a TODO about removing ValidatedString. | Gabriela Moldovan | 2024-01-31 | 1 | -0/+2 |
| | | |||||
| * | tor-keymgr: Remove the Slug tests (fmt). | Gabriela Moldovan | 2024-01-31 | 1 | -4/+1 |
| | | |||||
| * | tor-keymgr: Remove the Slug tests. | Gabriela Moldovan | 2024-01-31 | 1 | -34/+0 |
| | | | | | These tests belong in tor_persist now. | ||||
| * | tor-keymgr: Abolish ArtiPathComponent. | Gabriela Moldovan | 2024-01-31 | 4 | -100/+51 |
| | | | | | | | `ArtiPathComponent`s are really just `Slugs`. Part of #1193, #1092 | ||||
| * | tor-keymgr: Make ArtiPathComponent a Slug internally (fmt). | Gabriela Moldovan | 2024-01-31 | 2 | -23/+55 |
| | | |||||
| * | tor-keymgr: Make ArtiPathComponent a Slug internally. | Gabriela Moldovan | 2024-01-31 | 3 | -104/+70 |
| | | | | | | | | | | | | | | This will make it easier to replace `ArtiPathComponent` with `Slug` later down the line. Note this changes the syntax rules of `ArtiPathComponent`: * previously `ArtiPathComponent`s could be unicode strings, (now they are lowercase ASCII alphanumerics, plus `-`, `_`) * previously `ArtiPathComponent`s couldn't start with `-` or `_`, but now they can Part of #1193, #1092 | ||||
| * | tor-keymgr: Strip .onion suffix from HsId before building Slug. | Gabriela Moldovan | 2024-01-31 | 1 | -3/+28 |
| | | | | | | | We are about to replace `ArtiPathComponent` with `Slug`, but `Slug`s don't support `.`, so let's strip the `.onion` suffix before encoding it in the `ArtiPath`. | ||||
| * | tor-keymgr: Use keystore_error_kind() to get the error kind. | Gabriela Moldovan | 2024-01-15 | 1 | -1/+2 |
| | | | | | Closes #1215 | ||||
| * | Merge branch 'expand-keystore-dir' into 'main' | gabi-250 | 2024-01-11 | 1 | -10/+31 |
| |\ | | | | | | | | | tor-keymgr: Abolish ArtiNativeKeystoreConfig::expand_keystore_dir. See merge request tpo/core/arti!1867 | ||||
| | * | tor-keymgr: Abolish ArtiNativeKeystoreConfig::expand_keystore_dir. | Gabriela Moldovan | 2024-01-10 | 1 | -10/+31 |
| | | | | | | | | | | | | | This resolves a `TODO HSS` in arti-client. Part of #1187 | ||||
| * | | tor-keymgr: Turn some TODOs into #1195. | Gabriela Moldovan | 2024-01-10 | 2 | -2/+2 |
| | | | |||||
| * | | tor-keymgr: Turn some TODO HSS into #1194. | Gabriela Moldovan | 2024-01-10 | 1 | -2/+2 |
| | | | |||||
| * | | tor-keymgr: Turn some TODOs into #1115. | Gabriela Moldovan | 2024-01-10 | 6 | -12/+13 |
| | | | |||||
| * | | tor-keymgr: Turn some TODOs into #1119. | Gabriela Moldovan | 2024-01-10 | 1 | -2/+2 |
| | | | |||||
| * | | tor-keymgr: Turn a TODO HSS into #1118. | Gabriela Moldovan | 2024-01-10 | 1 | -1/+1 |
| | | | |||||
| * | | tor-keymgr: Turn a TODO HSS into #1095. | Gabriela Moldovan | 2024-01-10 | 1 | -1/+1 |
| | | | |||||
| * | | tor-keymgr: Turn some TODO HSS into #858 | Gabriela Moldovan | 2024-01-10 | 2 | -4/+4 |
| | | | |||||
| * | | tor-keymgr: Downgrade some TODO HSS. | Gabriela Moldovan | 2024-01-10 | 3 | -7/+7 |
| | | | |||||
| * | | tor-keymgr: Turn a TODO HSS into #1193. | Gabriela Moldovan | 2024-01-10 | 1 | -1/+1 |
| | | | |||||
| * | | tor-keymgr: Implement KeySpecifierComponentViaDisplayFromStr for HsId. | Gabriela Moldovan | 2024-01-10 | 1 | -0/+3 |
| | | | | | | | | | We are about to need this implementation. | ||||
| * | | tor-keymgr: Fully qualify KeySpecifierPattern in KeySpecifier macro. | Gabriela Moldovan | 2024-01-10 | 1 | -1/+2 |
| |/ | | | | | | If you derive `KeySpecifier` and forget to import `KeySpecifierPattern` you get a confusing error. It's better to let the macro import (or fully qualify) the necessary types from tor-keymgr. | ||||
| * | Fix typos | Dimitris Apostolou | 2024-01-08 | 2 | -3/+3 |
| | | |||||
| * | Merge branch 'keyspec' into 'main' | Ian Jackson | 2024-01-08 | 4 | -348/+751 |
| |\ | | | | | | | | | | | | | KeySpecifier improvements Closes #1126, #1147, and #1151 See merge request tpo/core/arti!1851 | ||||
| | * | tor-keymgr: KeySpecifierPattern: fix grammar | Ian Jackson | 2024-01-08 | 1 | -1/+1 |
| | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1851#note_2981473 | ||||
| | * | tor-keymgr: KeySpecifierPattern: fix docs | Ian Jackson | 2024-01-08 | 1 | -3/+3 |
| | | | | | | | | | | | | | | | Swap the docs for new_any and arti_pattern to the right methods! As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1851#note_2981475 | ||||
| | * | tor-keymgr: Fix typos | gabi-250 | 2024-01-08 | 2 | -4/+4 |
| | | | |||||
| | * | KeyPathInfo: Add role field | Ian Jackson | 2024-01-04 | 2 | -2/+27 |
| | | | | | | | | | This *is* the spec name. | ||||
| | * | KeySpecifier d-a macro: Populate extra_info | Ian Jackson | 2024-01-04 | 2 | -2/+20 |
| | | | | | | | | | Finishes arti#1151 item 10. | ||||
| | * | KeySpecifier d-a macro: Use dyn for describing | Ian Jackson | 2024-01-04 | 2 | -24/+75 |
| | | | | | | | | | This also passes the information we'll need to populate extra_info. | ||||
| | * | KeySpecifier d-a macro: Add a test for describing | Ian Jackson | 2024-01-04 | 1 | -0/+16 |
| | | | |||||
| | * | KeySpecifier d-a macro: Mnaully wrap two long lines | Ian Jackson | 2024-01-04 | 1 | -2/+6 |
| | | | |||||
| | * | KeySpecifier d-a macro: Use doc-hidden re-exports | Ian Jackson | 2024-01-04 | 2 | -9/+7 |
| | | | |||||
| | * | KeySpecifier d-a macro: Name result by whole path | Ian Jackson | 2024-01-04 | 1 | -2/+2 |
| | | | | | | | | | This will make the macro work if call sites rebind Result. | ||||
| | * | KeySpecifier d-a macro: Use derive-adhoc's pasting feature | Ian Jackson | 2024-01-04 | 1 | -6/+4 |
| | | | | | | | | | | | The KeyInfoExtractor impl is still misindented but we'll change that when we replace it. | ||||
| | * | KeySpecifier d-a macro: Use dyn for parsing | Ian Jackson | 2024-01-04 | 1 | -91/+181 |
| | | | | | | | | | | | | | | | | | | | | | | | Now the only place that knows how to do all this is the one place in the macro. The indentation is -4 compared to previously, because we're going to remove the wrapping with paste::paste! later. It's convenient to do this reindent now, while we're rewriting it. arti#1151 item 5. | ||||
| | * | KeyPathError::PatternNotMatched: Remove pattern from error | Ian Jackson | 2024-01-04 | 2 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | This can only happen if we tried to parse an ArtiPath as the wrong kind of KeySpecifier, which shouldn't happen very often. If it does, the pattern isn't that interesting. Which is just as well, since we're about to make it a bit harder to obtain it in the place where this error is going to be constructed. | ||||
