| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The publisher status is obtained via `StatusSender` (rather than by
polling `Publisher::status()`).
Part of #1083
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, the status of the `OnionService` is derived from the statuses
of its subcomponents. Their initial status will be `Shutdown`, so we
don't need to explicitly initialize it.
As for setting the status when `RunnionOnionService::launch` fails, I
don't think that's necessary: `launch()` returns an error on failure, so
the user will know about it (it doesn't need to watch the stream of
status events to find out it failed).
Part of #1083
|
| | | | |
| | | |
| | | |
| | | | |
This isn't something we need to do for #1083.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
The new names are shorter and just as descriptive.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
We need it to be public, because we're about to expose it in the
`OnionServiceStatus`.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
We're about to report the inner error in the `OnionServiceStatus`
(without making `BackoffError` public).
|
| | | | |
| | | |
| | | |
| | | | |
They're not used anywhere, so let's remove them.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
The key expiration status is only relevant if the service is running in
"offline mode", so these TODOs should be part of #1194.
|
| | | | |
| | | |
| | | |
| | | | |
This field is unused now that we have `ipt_mgr_state` and `publisher_state`.
|
| | | | |
| | | |
| | | |
| | | | |
Part of #1083
|
| | | | |
| | | |
| | | |
| | | | |
The publisher needs it to notify `OnionService` of status changes.
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
For updating the underlying component statuses of an `OnionServiceStatus.
Part of #1083
|
| |\ \ \
| |/ /
|/| /
| |/
| |
| |
| | |
hsservice: Fix some errorkinds and related error handling issues.
Closes #1225
See merge request tpo/core/arti!1906
|
| | |
| |
| |
| |
| | |
Also, change `keep_intro_established`'s return type to indicate that
it has no non-failing return cases.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
We already have the NetDir in establish_intro_once, so we might as
well use it to get the intro-point details there.
This confirms that we will not need IptError::NoNetdir, since we
use wait_for_netdir in establish_intro_once.
|
| | |
| |
| |
| |
| | |
This is not typically wrong, but it may become wrong if we do not
tidy up MissingHsIdKeypair in the future. The TODO now refers to
|
| | |
| |
| |
| | |
This is now #1255, which is not a MUST.
|
| | |
| |
| |
| | |
Part of #1225, also #1237.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
Now the remove_if_expire closure, which does the actual work, is
lexically outside the macro, and the macro is trivial.
|
| | |
| |
| |
| |
| |
| | |
This allows us to have a closure containing runtime-polymorphic code,
reducing monomorphisation and moving code out of a macro into a
closure.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Our pattern is now supposed to ensure that we don't see any irrelevant
keys. So if we do, that's a bug.
(The code layout is getting increasingly odd. We'll sort that out
along with some code motion later.)
|
| | |
| |
| |
| |
| |
| |
| | |
Only examine keys for this HS.
This avoids thinking about every key for every HS for every netdir
change. That's quadratic in the number of HS's.
|
| | |
| |
| |
| |
| | |
These are now the last uses of these values, so they need the "no
clone" form.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In principle there is a small race with doing this in a separate task:
the reactor and the sweeper might process the new netdir at different
times.
For example, if two netdir updates come in quick succession, and the
sweeper is slower, the sweeper might still be running with the
previous TPs as the publisher is creating keys in the new TPs.
Theoretically, the sweeper might delete keys the reactor has just
generated.
This is also considerably simpler.
|
| | |
| |
| |
| | |
We're going to change where this is called.
|
| | |
| |
| |
| | |
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1904#note_2987777
|
| | |
| |
| |
| | |
Part of #1166
|
| | | |
|
| | |
| |
| |
| | |
Closes #1166
|
| | |
| |
| |
| |
| |
| |
| |
| | |
The publisher is the only user of `hs_dirs_upload`. It turns out it
never actually uses the first element of the yielded `Item`s, so we can
simplify `hs_dir_upload` to only return the HsDir `Relay`s.
Part of #1166
|
| | |
| |
| |
| | |
Part of #1166
|
| |/
|
|
|
|
|
|
|
| |
The descriptor publisher uses this function to obtain the list of
relevant time periods. It will soon also need to know the `srv_lifespan`
associated with each time period, so we change this function to return
`HsDirParams`.
Part of #1166
|
| |
|
|
| |
Part of #1242
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the subcredentials were computed in `IptEstablisher::launch`
and stored in `RendRequestContext`. This caused long-running services to
report errors like:
```
WARN tor_hsservice::helpers: Problem while accepting rendezvous request: error: Could not process INTRODUCE request: Introduction handshake was invalid: Circuit-extension handshake authentication failed
```
for clients using newer subcredentials than the ones the service had at
the time the IPT was established.
Fixes #1242
|
| |
|
|
|
|
|
|
| |
The subcredential lookup will be moved to
`IntroRequest::decrypt_from_introduce2`. The error returned on failure
is going to be `IntroRequestError::Subcredentials`.
Part of #1242
|
| |\
| |
| |
| |
| |
| |
| | |
Clarify shutdown behavior when RemoteOnionService is dropped.
Closes #1238 and #1236
See merge request tpo/core/arti!1899
|
| | | |
|
| | |
| |
| |
| |
| | |
We don't need to implement this for our first release of onion
services, but we shouldn't ship a function that calls todo!().
|
| | | |
|