| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | |
|
| |
|
|
|
|
|
| |
This should give us some confidence that we are not accidentally
discarding results we should actually be using.
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2251#note_3046219
|
| | |
|
| |
|
|
| |
This also makes the publisher exit if the netdir event stream ends.
|
| |
|
|
|
|
|
|
|
| |
It is OK to discard the response string (the response is validated
below where we call `DirResponse::into_output_string()`).
(Perhaps we should just make `DirResponse::check_ok()` public. That way,
we could validate the response without having to handle its output
string).
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
This is being reimplemented as #1292
|
| |
|
|
|
|
|
| |
This removes a couple of unimplemented functions.
These were supposed to be the starting point for #1217, but we won't be
implementing that any time soon.
|
| |
|
|
| |
Note: #1217 is still open and we may want to implement it at some point.
|
| |
|
|
|
|
|
| |
See
https://github.com/rust-lang/rust-clippy/issues/13001
I think it's OK to change this in our tree, nevertheless.
|
| |
|
|
|
|
|
|
|
|
|
| |
* Change `pub` to `export`
* Change the `=` in define to `:`
* Change `pub_template_semver_check` to `template_export_semver_check`
Right now, 0.12.1 supports both syntaxes. I have verified this branch
also compiles with
https://gitlab.torproject.org/Diziet/rust-derive-deftly/-/merge_requests/402
ee171ffaf56d7dcb7d75584054921153fe19b222
|
| |
|
|
|
|
| |
* Bump in Cargo.toml
* Deal with `${Xmeta as ...}` incompatible change, by
always specifying an `as`, and changing `as tokens`.
|
| |
|
|
| |
This commit is automatically generated.
|
| |
|
|
| |
RunningOnionService::status_events()
|
| |\
| |
| |
| |
| | |
Switch to derive-deftly
See merge request tpo/core/arti!2066
|
| | |
| |
| |
| | |
Found by "git grep adhoc" and manual inspection.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is the combination of a number of separate commits, many of which
were generated by seddery, and then rebased and squashed.
Cargo.toml
perl -i~ -pe 's{^derive-adhoc}{derive-deftly = "0.10"}' crates/*/Cargo.toml
(not regenerated during rebase)
update Cargo.lock
`cargo fetch` without --locked
(regenerated during rebase)
seddery
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{^use derive_adhoc}{use derive_deftly}'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bdefine_derive_adhoc\b}{define_derive_deftly}g'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bAdhoc\b}{Deftly}g if m{derive}'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\#\[derive_adhoc\b}{#[derive_deftly}g'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{use derive_adhoc}{use derive_deftly}'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bderive_adhoc\b}{derive_deftly_adhoc} if m{use.*deftly}'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bderive_adhoc!}{derive_deftly_adhoc!}'
(not regenerated during rebase)
Manually add `#[derive_deftly_adhoc]` where needed.
seddery
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\#\[adhoc\b}{#[deftly}g'
git-ls-files | grep '\.rs$' | xargs perl -i~ -pe 's{\bderive_adhoc_template}{derive_deftly_template}'
(not regenerated during rebase)
Manually fix up an import
Manually update some builder attrs
Manually fix up tor_rtmock::time_core
This was missed in my seddery, due to me rebasing the branch and not
redoing the seddery.
|
| | |
| |
| |
| | |
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2064#note_3014793
|
| | | |
|
| | | |
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
!2024 introduced `BackoffSchedule::single_attempt_timeout()`, partially
implementing #1259. This completes the implementation by moving the
per-iteration timeout from the publisher reactor to `backoff::Runner`.
Addresses https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2024?commit_id=a4f2bf5cb7d4027a49b74ec5a5298f7b9a3cf62e#note_3005097
Note: the `if should_retry` block is intentionally misindented, to make
reviewing the actual changes easier. A future commit will fix the
indentation. I originally wanted to suggest reviewing this commit using
`--ignore-space-change`, but I found that it makes things a bit
confusing (it shows some funky indentation around the parts that have
both whitespace changes and modifications).
Closes #1259
|
| |
|
|
| |
Closes #1124.
|
| |
|
|
|
|
|
| |
Based on designs in #1124.
Note that there is a TODO here about a hack I had to do to appease
the borrow checker.
|
| |
|
|
|
|
|
|
|
|
|
| |
The key insights here are:
- That relay cell format and crypto protocols aren't orthogonal:
Once we have GCO, it will require V1.
- That we only need the actual functions for layer construction to
be generic; we don't need to proliferate generic parameters
everywhere.
- That the circuit::handshake module already does most of what we
want.
|
| | |
|
| | |
|
| |
|
|
|
| |
These are mostly about explicitly linking to things that were
already in scope.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Change Path::display to this new function, in call sites where it's
being used for a diagnostic.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
We have Display/FromStr for AuthorizedClientConfig. We can't have
Display if it can containa PathBuf because a PathBuf may not have a
string representation.
If we want to support non-unicode in the future, we'll need an
escaping scheme and messing around with OsStr.
The config scheme here may not be the best, but right now I'm just
fixing uses of Path::display.
|
| | |
|
| | |
|
| |
|
|
| |
Fixes #1212
|
| | |
|
| | |
|
| |
|
|
| |
This reduces visual clutter and reclaims horizontal space.
|
| | |
|
| | |
|
| |
|
|
| |
This is too vague.
|
| |
|
|
| |
This is too vague.
|
| |
|
|
|
| |
This alphabetises the imports, ready for us to do some more manual
tidying.
|