summaryrefslogtreecommitdiff
path: root/crates/tor-hsservice/src
Commit message (Collapse)AuthorAgeFilesLines
* tor-hsservice: De-linkify a docs link to a private itemIan Jackson2023-09-051-1/+1
| | | | | | | | | | Weirdly, rustdoc says 189 | /// TODO HSS surely this should be [`tor_proto::crypto::handshake::ntor::NtorSecretKey`] ? | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `crypto` in module `tor_proto` when it should probably complain the item is private. Anyway, we can't link to it, so don't.
* Merge branch 'doc-fixes' into 'main'Nick Mathewson2023-09-052-3/+3
|\ | | | | | | | | tor-hsservice: Fix broken doc links. See merge request tpo/core/arti!1565
| * tor-hsservice: Fix IPT establisher broken doc link.Gabriela Moldovan2023-09-051-1/+1
| |
| * tor-hsservice: Fix broken publisher reactor broken doc link.Gabriela Moldovan2023-09-051-2/+2
| |
* | tor-hsservice: Add a TODO HSS re expiry timesIan Jackson2023-09-052-1/+2
| |
* | tor-hsservice: publish: Add type alias for PublishIptSetIan Jackson2023-09-053-11/+15
|/
* tor-hsservice: Add a TODO re PublishIptSetIan Jackson2023-09-051-0/+2
|
* tor-hsservice: Add commentary re VerbatimLinkSpecCircTargetIan Jackson2023-09-051-0/+9
|
* RustfmtIan Jackson2023-08-301-2/+2
|
* tor-hsservice: ipt_mgr: Clarify/correct `is_good` commentIan Jackson2023-08-301-1/+1
| | | | | Apropos https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1559#note_2937979
* tor-hsservice: ipt_mgr: Actually generate k_sidIan Jackson2023-08-301-6/+2
| | | | | Apropos https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1559#note_2937978
* tor-hsservice: Fix type of descriptor expiryIan Jackson2023-08-301-3/+3
| | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1559#note_2937976 If we're publishing with Durations, then we can use Instant at least while everything remains in-core.
* tor-hsservice: Fix type of descriptor lifetime in IptSetIan Jackson2023-08-303-6/+6
| | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1559#note_2937976
* tor-hsservice: publish: Add more docs for `Option<IptSet>`Ian Jackson2023-08-301-0/+2
| | | | | Apropos https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1559#note_2937975
* tor-hsservice: ipt_estblish: Add TODOs re netdir monitoringIan Jackson2023-08-301-0/+16
| | | | | Apropos https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1559#note_2937973
* tor-hsservice: ipt_mgr: Replace a panicIan Jackson2023-08-301-1/+1
| | | | | Apropos https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1559#note_2937971
* tor-hsservice: ipt_mgr: Discussion of IPT publication strategyIan Jackson2023-08-301-2/+20
| | | | | Apropos https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1559#note_2937970
* tor-hsservice: ipt_mgr: Remove stray commentIan Jackson2023-08-301-2/+0
| | | | | Apropos https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1559#note_2937969
* tor-hsservice: ipt_mgr: Calculate a publish::IptSetIan Jackson2023-08-291-6/+79
|
* tor-hsservice: ipt_mgr: Break out Ipt::is_good (fmt)Ian Jackson2023-08-291-2/+1
|
* tor-hsservice: ipt_mgr: Break out Ipt::is_goodIan Jackson2023-08-291-4/+11
| | | | | I'm going to want to reuse this, and it makes the code clearer at the one call site already.
* tor-hsservice: ipt_mgr: Sort-of create IPT key materialIan Jackson2023-08-291-2/+42
| | | | | | | | | | | | | | | Add the key material to `struct Ipt`, and add some code to generate it. However, this is all rather unsatisfactory. I got a bit lost in the maze of 25519 key types, and neded up making a provisional dummy `NtorKeyPair` type, which will need to be deleted again. And, I wasn't able to generate K_hs_ipt_sid because of a mismatch in Rng traits, which seems to be caused by us not properly wrapping up the underlying crypto key types ? At least the warts seem to be fairly localised.
* tor-hsservice: ipt_mgr: Reorganise publication set handlingIan Jackson2023-08-291-25/+23
| | | | | | | | | | | | Replace the publish_set closure (whose body is just TODOs right now) with a proper function. Change the type of the publication set to be Option<publish::IptSet>, like the publisher now wants. The value of the enum IptSetStatus is now no longer reified; instead, these situations are the three branches of an if, and described in comments.
* tor-hsservice: ipt_mgr: Rename `irelays` field from `relays`Ian Jackson2023-08-291-12/+12
| | | | | | Previous code review comments suggested this variable would be better with a name that more clearly distinguished it from (say) something containing `Relay`s.
* tor-hsservice: Have the manager be in charge of expiry timeIan Jackson2023-08-293-5/+34
| | | | | | | | | | | Add the expiry time (as wall clock time) to publish::IptSet. The manager is in a good position to know this information. Provide constants that will be used (for now) for actually calculating the expiry times. (Right now the part where the expiry time would actually be calculated doesn't exist, but it will come soon.)
* tor-hsservice: Allow the manager to tell the publisher to pauseIan Jackson2023-08-292-3/+11
| | | | | This is to implement the "Unknown" state described in "hssvc-ipt-algorithms.md".
* tor-hsservice: Dispose of a done TODO commentIan Jackson2023-08-291-3/+0
| | | | This function *does* take the new introduction points as an argument!
* tor-hsservice: Change publisher doc comment re intro point changesIan Jackson2023-08-291-1/+1
| | | | | | | | new_intro_points may be called even if they're actually all the same. (We have decided that it is the publisher which is responsible for eliding no-change updates: see the TODO HSS in publish/reactor.rs on Reactor, near l.50.
* tor-hsservice: Reconcile types between manager and publisherIan Jackson2023-08-294-22/+21
| | | | | | | | | | Move ipt_mgr::IptSetToPublish to be publish::IptSet, and use it everywhere appropriate. Define descriptor::Ipt to be an IntroPointDesc from tor_netdoc. The manager will have all the information to produce these, so it will be convenient to simply hand them, pre-canned, to the publisher.
* tor-hsservice: Have Establisher provide more information to Manager (fmt)Ian Jackson2023-08-291-1/+4
|
* tor-hsservice: Have Establisher provide more information to ManagerIan Jackson2023-08-293-6/+35
| | | | | | The establisher has a netdir; the manager generally doesn't. So it will be convenient for the establisher to provide the linkspecs and so on.
* hs: Intro point selection: Actually call is_hs_intro_point() (fmt)Ian Jackson2023-08-291-5/+5
|
* hs: Intro point selection: Actually call is_hs_intro_point()Ian Jackson2023-08-291-0/+1
| | | | | | | | Call site as per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1550#note_2936401 Plus a TODO comment with an opinion from me about this API. (Note not a TODO HSS so this is on the back burner.)
* tor-hsservice: Actually select new intro point relays (fmt)Ian Jackson2023-08-291-2/+6
|
* tor-hsservice: Actually select new intro point relaysIan Jackson2023-08-291-9/+59
| | | | | | | | I doubt this would work yet because it will probably crash at startup due to the unhandled error case. Handling the error case would have a conflict with !1549 so let's do that later.
* Merge branch 'mgr-split' into 'main'Ian Jackson2023-08-291-4/+19
|\ | | | | | | | | tor-hsservice: ipt mgr: Split up idempotently_progress_things_now See merge request tpo/core/arti!1549
| * tor-hsservice: ipt mgr: Split up idempotently_progress_things_nowIan Jackson2023-08-251-4/+19
| | | | | | | | | | | | | | | | Break publication out of this function, which was rather long. This does seem to make conceptual sense, now I've done it. For example, note how the 2nd half didn't need &mut self, and so doesn't ever `return CONTINUE;`
* | tor-hsservice: Add TODOs for the unimplemented parts.Gabriela Moldovan2023-08-251-0/+57
| |
* | tor-hsservice: Get rid of an unnecessary clone.Gabriela Moldovan2023-08-251-5/+3
| |
* | tor-hsservice: Remove unnecessary validate() function.Gabriela Moldovan2023-08-252-29/+11
| |
* | tor-hsservice: If we can't build the descriptor, log the error (fmt).Gabriela Moldovan2023-08-251-12/+15
| |
* | tor-hsservice: If we can't build the descriptor, log the error.Gabriela Moldovan2023-08-251-3/+6
| |
* | tor-hsservice: Document the non-Event events handled by the Reactor.Gabriela Moldovan2023-08-251-0/+10
| |
* | tor-hsservice: Clarify when `descriptor` is expected to be incomplete.Gabriela Moldovan2023-08-251-0/+3
| |
* | tor-hsservice: Explain what UPLOAD_RATE_LIM_THRESHOLD is used for.Gabriela Moldovan2023-08-251-0/+5
| |
* | tor-hsservice: Document when recompute_hs_dirs should be called.Gabriela Moldovan2023-08-251-0/+8
| |
* | tor-hsservice: s/fetch_hsdirs/compute_hsdirs (fmt).Gabriela Moldovan2023-08-251-1/+2
| |
* | tor-hsservice: s/fetch_hsdirs/compute_hsdirs.Gabriela Moldovan2023-08-251-3/+3
| |
* | tor-hsservice: Use [v].into_iter() instead of iter::once(v).Gabriela Moldovan2023-08-251-1/+1
| |
* | tor-hsservice: Handle schedule_upload_rx.recv() errors.Gabriela Moldovan2023-08-251-2/+4
| |