| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | Merge branch 'desc-error' into 'main' | Nick Mathewson | 2023-06-22 | 2 | -33/+6 | |
| |\ \ | | | | | | | | | | | | | Clean up HsDesc error types and stabilize onion-service ErrorKinds See merge request tpo/core/arti!1289 | |||||
| | * | | Remove onion service descriptor-related errorkinds. | Nick Mathewson | 2023-06-22 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | These have been subsumed by other errorkinds, mostly OnionServiceProtocolViolation and TorProtocolViolation. In particular please review the change in tor-hsclient closely; I am not sure about the new errorkinds for the error there. | |||||
| | * | | netdoc: Introduce HsDescError | Nick Mathewson | 2023-06-22 | 2 | -31/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For higher-level HsDesc-related functions, this type indicates where exactly an error occurred. It lets us distinguish decryption errors from parsing errors, and attribute responsibility to the hsdir, the onion service, or the user's lack of encryption. This lets us remove some just-introduced complexity in tor-hsclient. | |||||
| * | | | keymgr: Move dummy implementation to tor-keymgr. | Gabriela Moldovan | 2023-06-22 | 1 | -1/+3 | |
| |/ / | ||||||
| * | | Merge branch 'socks_errorkinds' into 'main' | Nick Mathewson | 2023-06-22 | 2 | -2/+25 | |
| |\ \ | | | | | | | | | | | | | | | | | | | Generate correct-ish socks5 errors for onion service errors. Closes #736 See merge request tpo/core/arti!1279 | |||||
| | * | | Generate correct ErrorKinds for hsdesc decryption failures. | Nick Mathewson | 2023-06-21 | 2 | -2/+25 | |
| | | | | | | | | | | | | | Part of #736 | |||||
| * | | | tor-hsclient: Delete/rewrite out-of-date commentary | Ian Jackson | 2023-06-22 | 1 | -13/+5 | |
| | |/ |/| | ||||||
| * | | Merge branch 'stderr' into 'main' | Alexander Færøy | 2023-06-21 | 1 | -0/+2 | |
| |\ \ | | | | | | | | | | | | | lints: Promote clippy::print_stderr and clippy::print_stdout See merge request tpo/core/arti!1271 | |||||
| | * | | lints: Run maint/add_warning to actually apply new lints | Ian Jackson | 2023-06-21 | 1 | -0/+2 | |
| | | | | ||||||
| * | | | Upgrade to strum 0.25. | Nick Mathewson | 2023-06-21 | 1 | -1/+1 | |
| | |/ |/| | ||||||
| * | | tor-hsclient: Apply deferred clippy churn needed by fmt churn | Ian Jackson | 2023-06-21 | 1 | -1/+1 | |
| | | | | | | | | | rustfmt *introduced* this clippy warning. | |||||
| * | | tor-hsclient: Apply deferred rustfmt churn | Ian Jackson | 2023-06-21 | 2 | -11/+6 | |
| | | | ||||||
| * | | tor-hsclient: Drop most allows that are marked for removal | Ian Jackson | 2023-06-21 | 3 | -9/+0 | |
| | | | ||||||
| * | | tor-hsclient: Drop a large number of unneeded imports | Ian Jackson | 2023-06-21 | 4 | -19/+9 | |
| | | | ||||||
| * | | tor-hsclient: Add HSID to some log messages | Ian Jackson | 2023-06-21 | 1 | -6/+7 | |
| | | | | | | | | | | | For the debug!, we can use the unredacted form. For error!, we use Sensitive. | |||||
| * | | tor-hsclient: Do Debug the descriptor as part of Data | Ian Jackson | 2023-06-21 | 1 | -1/+0 | |
| | | | | | | | | | | | Empirically, this does not cause the descriptor to be spat out in normal operation. And it seems right. | |||||
| * | | tor-hsclient: Drop some temporary trace calls | Ian Jackson | 2023-06-21 | 2 | -8/+2 | |
| | | | | | | | | | | | These were added as part of a debugging #885, and are no longer needed. | |||||
| * | | tor-hsclient: Drop two eprintlns in production code | Ian Jackson | 2023-06-21 | 1 | -2/+0 | |
| | | | ||||||
| * | | tor-hsclinet: Promote dead code allows to cover all tests | Ian Jackson | 2023-06-21 | 1 | -1/+3 | |
| | | | | | | | | | | | We want to remove the crate-level dead code allows. The tests are incomplete and there are multiple todos for that. | |||||
| * | | tor-hsclient: Use a formulaic TODO mark for incompleteness of tests | Ian Jackson | 2023-06-21 | 1 | -5/+5 | |
| | | | ||||||
| * | | tor-hsclinet: Add a narrow allow, pending answer to open question | Ian Jackson | 2023-06-21 | 1 | -0/+1 | |
| | | | | | | | | | | | I need to talk to HS expert(s) about when this circuit can be torn down. | |||||
| * | | tor-hsclient: Remove unused Context.hs_blind_id_key | Ian Jackson | 2023-06-21 | 1 | -3/+0 | |
| | | | ||||||
| * | | tor-hsclient: Add an allow for a deliberately-unused variable | Ian Jackson | 2023-06-21 | 1 | -0/+1 | |
| | | | ||||||
| * | | tor-hsclient: Omit some unussed struct fields in patterns | Ian Jackson | 2023-06-21 | 1 | -2/+2 | |
| |/ | | | | | For the arms that have a fixed retry time, or a fixed ErrorKind, dont't bind the unused inner error. | |||||
| * | Merge branch 'netdoc-todos' into 'main' | Nick Mathewson | 2023-06-16 | 1 | -0/+2 | |
| |\ | | | | | | | | | Resolve many TODO HS items in tor-netdoc See merge request tpo/core/arti!1251 | |||||
| | * | hsclient: note that we should check revctr. | Nick Mathewson | 2023-06-16 | 1 | -0/+2 | |
| | | | ||||||
| * | | keymgr: Move the HS client and service key specifiers out of tor-keymgr. | Gabriela Moldovan | 2023-06-15 | 4 | -2/+83 | |
| | | | | | | | | | | | | | The HS `HsClientSpecifier` and `HsClientSecretKeySpecifier` are moved to `tor-hsclient`. The HS service secret key specifier stubs are moved to `tor-hsservice`. | |||||
| * | | hsclient: Change builder error return type to ConfigBuildError. | Gabriela Moldovan | 2023-06-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | | It's not perfectly clear what this error type should be, so let's use `ConfigBuildError` for now (it makes things easier in `arti-client`, as we already have an `ErrorDetail` for it). | |||||
| * | | tor-hsclient: Make Untried a {}-less unit | Ian Jackson | 2023-06-15 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | Suggested here https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1247#note_2912642 It's unlikely this will grow any content, so fine. | |||||
| * | | tor-hsclient: Insert a blank line | gabi-250 | 2023-06-15 | 1 | -0/+1 | |
| | | | ||||||
| * | | tor-hsclient: Docs improvements. | gabi-250 | 2023-06-15 | 1 | -2/+2 | |
| | | | ||||||
| * | | tor-hsclient: Remove two done TODOs | Ian Jackson | 2023-06-15 | 1 | -2/+0 | |
| | | | ||||||
| * | | tor-hsclient: provide intro_index accessor for FailedAttemptError (xref) | Ian Jackson | 2023-06-15 | 1 | -1/+2 | |
| | | | | | | | | | Add a cross-reference to docs arising from MR comments in !1246. | |||||
| * | | tor-hsclient: Actually store our IPT experiences | Ian Jackson | 2023-06-15 | 1 | -7/+42 | |
| | | | ||||||
| * | | tor-hsclient: intro_rend_connect: bind `outcome` | Ian Jackson | 2023-06-15 | 1 | -3/+3 | |
| | | | | | | | | | This will be used in a moment. | |||||
| * | | tor-hsclient: Actually choose which intro points to use | Ian Jackson | 2023-06-15 | 1 | -3/+75 | |
| | | | | | | | | | | | Right now this just always chooses randomly because nothing stores anything in the HashMap. | |||||
| * | | tor-hsclient: Introduce RelayIdForExperience | Ian Jackson | 2023-06-15 | 1 | -9/+37 | |
| | | | | | | | | | | | Wrap this up in a newtype so we don't accidentally use it for anything else. Provide two constructors, one for storing and one for lookups. | |||||
| * | | tor-hsclient: Add random sort key to UsableIpt | Ian Jackson | 2023-06-15 | 1 | -0/+6 | |
| | | | ||||||
| * | | tor-hsclient: provide intro_index accessor for FailedAttemptError | Ian Jackson | 2023-06-15 | 2 | -1/+24 | |
| | | | ||||||
| * | | tor-hsclient: InvalidTarget::ImpossibleRelayIds is RetryTime::Never | Ian Jackson | 2023-06-14 | 1 | -1/+1 | |
| | | | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1246#note_2912105 | |||||
| * | | tor-hsclient: Correction to HasRetryTime for InvalidTarget doc | Nick Mathewson | 2023-06-14 | 1 | -1/+2 | |
| | | | ||||||
| * | | tor-hsclient: Add doc for HasKind for FailedAttemptError | Ian Jackson | 2023-06-14 | 1 | -0/+16 | |
| | | | | | | | | | | | There is a cross-reference here to code (`IptSortKey`) in another branch that I haven't made an MR for yet. | |||||
| * | | tor-hsclient: Add docs and comments about HasRetryTime for InvalidTarget | Ian Jackson | 2023-06-14 | 1 | -0/+18 | |
| | | | ||||||
| * | | tor-hsclient: impl HasRetryTime for FailedAttemptError | Ian Jackson | 2023-06-14 | 2 | -2/+25 | |
| | | | ||||||
| * | | tor-hsclient: impl HasRetryTime for InvalidTarget | Ian Jackson | 2023-06-14 | 1 | -1/+14 | |
| |/ | ||||||
| * | tor-hsclient: Add some more debugging | Ian Jackson | 2023-06-13 | 1 | -2/+39 | |
| | | ||||||
| * | tor-hsclient: Return the circuit | Ian Jackson | 2023-06-13 | 1 | -4/+1 | |
| | | ||||||
| * | tor-hsclient: Conduct the INTRODUCE1 exchange | Ian Jackson | 2023-06-13 | 2 | -6/+59 | |
| | | ||||||
| * | tor-hsclient: Remove an already-done TODO | Ian Jackson | 2023-06-13 | 1 | -3/+0 | |
| | | | | | Since !1238 we do pass the handshake_state along. | |||||
| * | tor-hsclient: Rename some errors for greater consistency | Ian Jackson | 2023-06-13 | 2 | -15/+15 | |
| | | ||||||
