summaryrefslogtreecommitdiff
path: root/crates/tor-hsclient
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge branch 'desc-error' into 'main'Nick Mathewson2023-06-222-33/+6
|\ \ | | | | | | | | | | | | Clean up HsDesc error types and stabilize onion-service ErrorKinds See merge request tpo/core/arti!1289
| * | Remove onion service descriptor-related errorkinds.Nick Mathewson2023-06-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | These have been subsumed by other errorkinds, mostly OnionServiceProtocolViolation and TorProtocolViolation. In particular please review the change in tor-hsclient closely; I am not sure about the new errorkinds for the error there.
| * | netdoc: Introduce HsDescErrorNick Mathewson2023-06-222-31/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For higher-level HsDesc-related functions, this type indicates where exactly an error occurred. It lets us distinguish decryption errors from parsing errors, and attribute responsibility to the hsdir, the onion service, or the user's lack of encryption. This lets us remove some just-introduced complexity in tor-hsclient.
* | | keymgr: Move dummy implementation to tor-keymgr.Gabriela Moldovan2023-06-221-1/+3
|/ /
* | Merge branch 'socks_errorkinds' into 'main'Nick Mathewson2023-06-222-2/+25
|\ \ | | | | | | | | | | | | | | | | | | Generate correct-ish socks5 errors for onion service errors. Closes #736 See merge request tpo/core/arti!1279
| * | Generate correct ErrorKinds for hsdesc decryption failures.Nick Mathewson2023-06-212-2/+25
| | | | | | | | | | | | Part of #736
* | | tor-hsclient: Delete/rewrite out-of-date commentaryIan Jackson2023-06-221-13/+5
| |/ |/|
* | Merge branch 'stderr' into 'main'Alexander Færøy2023-06-211-0/+2
|\ \ | | | | | | | | | | | | lints: Promote clippy::print_stderr and clippy::print_stdout See merge request tpo/core/arti!1271
| * | lints: Run maint/add_warning to actually apply new lintsIan Jackson2023-06-211-0/+2
| | |
* | | Upgrade to strum 0.25.Nick Mathewson2023-06-211-1/+1
| |/ |/|
* | tor-hsclient: Apply deferred clippy churn needed by fmt churnIan Jackson2023-06-211-1/+1
| | | | | | | | rustfmt *introduced* this clippy warning.
* | tor-hsclient: Apply deferred rustfmt churnIan Jackson2023-06-212-11/+6
| |
* | tor-hsclient: Drop most allows that are marked for removalIan Jackson2023-06-213-9/+0
| |
* | tor-hsclient: Drop a large number of unneeded importsIan Jackson2023-06-214-19/+9
| |
* | tor-hsclient: Add HSID to some log messagesIan Jackson2023-06-211-6/+7
| | | | | | | | | | For the debug!, we can use the unredacted form. For error!, we use Sensitive.
* | tor-hsclient: Do Debug the descriptor as part of DataIan Jackson2023-06-211-1/+0
| | | | | | | | | | Empirically, this does not cause the descriptor to be spat out in normal operation. And it seems right.
* | tor-hsclient: Drop some temporary trace callsIan Jackson2023-06-212-8/+2
| | | | | | | | | | These were added as part of a debugging #885, and are no longer needed.
* | tor-hsclient: Drop two eprintlns in production codeIan Jackson2023-06-211-2/+0
| |
* | tor-hsclinet: Promote dead code allows to cover all testsIan Jackson2023-06-211-1/+3
| | | | | | | | | | We want to remove the crate-level dead code allows. The tests are incomplete and there are multiple todos for that.
* | tor-hsclient: Use a formulaic TODO mark for incompleteness of testsIan Jackson2023-06-211-5/+5
| |
* | tor-hsclinet: Add a narrow allow, pending answer to open questionIan Jackson2023-06-211-0/+1
| | | | | | | | | | I need to talk to HS expert(s) about when this circuit can be torn down.
* | tor-hsclient: Remove unused Context.hs_blind_id_keyIan Jackson2023-06-211-3/+0
| |
* | tor-hsclient: Add an allow for a deliberately-unused variableIan Jackson2023-06-211-0/+1
| |
* | tor-hsclient: Omit some unussed struct fields in patternsIan Jackson2023-06-211-2/+2
|/ | | | | For the arms that have a fixed retry time, or a fixed ErrorKind, dont't bind the unused inner error.
* Merge branch 'netdoc-todos' into 'main'Nick Mathewson2023-06-161-0/+2
|\ | | | | | | | | Resolve many TODO HS items in tor-netdoc See merge request tpo/core/arti!1251
| * hsclient: note that we should check revctr.Nick Mathewson2023-06-161-0/+2
| |
* | keymgr: Move the HS client and service key specifiers out of tor-keymgr.Gabriela Moldovan2023-06-154-2/+83
| | | | | | | | | | | | The HS `HsClientSpecifier` and `HsClientSecretKeySpecifier` are moved to `tor-hsclient`. The HS service secret key specifier stubs are moved to `tor-hsservice`.
* | hsclient: Change builder error return type to ConfigBuildError.Gabriela Moldovan2023-06-151-1/+1
| | | | | | | | | | | | It's not perfectly clear what this error type should be, so let's use `ConfigBuildError` for now (it makes things easier in `arti-client`, as we already have an `ErrorDetail` for it).
* | tor-hsclient: Make Untried a {}-less unitIan Jackson2023-06-151-2/+2
| | | | | | | | | | | | | | Suggested here https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1247#note_2912642 It's unlikely this will grow any content, so fine.
* | tor-hsclient: Insert a blank linegabi-2502023-06-151-0/+1
| |
* | tor-hsclient: Docs improvements.gabi-2502023-06-151-2/+2
| |
* | tor-hsclient: Remove two done TODOsIan Jackson2023-06-151-2/+0
| |
* | tor-hsclient: provide intro_index accessor for FailedAttemptError (xref)Ian Jackson2023-06-151-1/+2
| | | | | | | | Add a cross-reference to docs arising from MR comments in !1246.
* | tor-hsclient: Actually store our IPT experiencesIan Jackson2023-06-151-7/+42
| |
* | tor-hsclient: intro_rend_connect: bind `outcome`Ian Jackson2023-06-151-3/+3
| | | | | | | | This will be used in a moment.
* | tor-hsclient: Actually choose which intro points to useIan Jackson2023-06-151-3/+75
| | | | | | | | | | Right now this just always chooses randomly because nothing stores anything in the HashMap.
* | tor-hsclient: Introduce RelayIdForExperienceIan Jackson2023-06-151-9/+37
| | | | | | | | | | Wrap this up in a newtype so we don't accidentally use it for anything else. Provide two constructors, one for storing and one for lookups.
* | tor-hsclient: Add random sort key to UsableIptIan Jackson2023-06-151-0/+6
| |
* | tor-hsclient: provide intro_index accessor for FailedAttemptErrorIan Jackson2023-06-152-1/+24
| |
* | tor-hsclient: InvalidTarget::ImpossibleRelayIds is RetryTime::NeverIan Jackson2023-06-141-1/+1
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1246#note_2912105
* | tor-hsclient: Correction to HasRetryTime for InvalidTarget docNick Mathewson2023-06-141-1/+2
| |
* | tor-hsclient: Add doc for HasKind for FailedAttemptErrorIan Jackson2023-06-141-0/+16
| | | | | | | | | | There is a cross-reference here to code (`IptSortKey`) in another branch that I haven't made an MR for yet.
* | tor-hsclient: Add docs and comments about HasRetryTime for InvalidTargetIan Jackson2023-06-141-0/+18
| |
* | tor-hsclient: impl HasRetryTime for FailedAttemptErrorIan Jackson2023-06-142-2/+25
| |
* | tor-hsclient: impl HasRetryTime for InvalidTargetIan Jackson2023-06-141-1/+14
|/
* tor-hsclient: Add some more debuggingIan Jackson2023-06-131-2/+39
|
* tor-hsclient: Return the circuitIan Jackson2023-06-131-4/+1
|
* tor-hsclient: Conduct the INTRODUCE1 exchangeIan Jackson2023-06-132-6/+59
|
* tor-hsclient: Remove an already-done TODOIan Jackson2023-06-131-3/+0
| | | | Since !1238 we do pass the handshake_state along.
* tor-hsclient: Rename some errors for greater consistencyIan Jackson2023-06-132-15/+15
|