| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | hs desc: Record a Timebound<HsDesc> (but not really for now) | Ian Jackson | 2023-04-11 | 1 | -6/+10 | |
| | | | | | | | | | | We have a local alias of `HsDesc = String` which needs to be got rid of. But, right now the alternative would be to implement all the code for signature checking and decryption of an `HsDesc`, before we can make a test case for the downloader part. | |||||
| * | hs connect: Introduce Context | Ian Jackson | 2023-04-11 | 1 | -13/+91 | |
| | | | | | | This will be convenient as the common context for the descriptor download work, and also for testing. | |||||
| * | tor-hsclient: Fix a doc link. | Nick Mathewson | 2023-03-30 | 1 | -1/+1 | |
| | | ||||||
| * | Run rustfmt | Ian Jackson | 2023-03-30 | 1 | -13/+14 | |
| | | | | | Apply this churn, which I deferred for ease of review. | |||||
| * | tor-hsconn: Rename ConnError (from HsClientConnError) | Ian Jackson | 2023-03-30 | 4 | -19/+19 | |
| | | | | | | The old name was unwieldy and other crates can just as well name it by the crate scope. | |||||
| * | tor-client: Pass a netdir for each request | Ian Jackson | 2023-03-30 | 3 | -15/+24 | |
| | | | | | | This will be more convenient inside tor-hsclient. In arti-client, this mirrors the way TorClient::get_or_launch_exit_circ works. | |||||
| * | Pass HS identity to hsclient connection function | Ian Jackson | 2023-03-28 | 2 | -2/+10 | |
| | | | | | Obviously it will need this! | |||||
| * | Pass HsCircPool to hsclient connect function, not CircMgr | Ian Jackson | 2023-03-28 | 2 | -5/+6 | |
| | | | | | | We separated this out in the circmgr API. This is what the HS client needs. It doesn't want to participate in the general circuit pool. | |||||
| * | tor-hsclient: Have the public API take StreamIsolation | Ian Jackson | 2023-03-23 | 1 | -2/+7 | |
| | | ||||||
| * | tor-hsclient: impl HasKind for errors | Ian Jackson | 2023-03-23 | 1 | -1/+20 | |
| | | ||||||
| * | tor-hsclient: Swap errors so Bug comes last | Ian Jackson | 2023-03-23 | 1 | -4/+4 | |
| | | | | | This seems more consistent with the way it's done elsewhere. | |||||
| * | tor-hsclient: Document clone-nature of HsClientConnector | Ian Jackson | 2023-03-23 | 1 | -0/+3 | |
| | | ||||||
| * | Fix typos | Dimitris Apostolou | 2023-03-03 | 1 | -3/+3 | |
| | | ||||||
| * | hsclient: Discuss HsClientConnector multiplicity/reuse | Ian Jackson | 2023-03-01 | 1 | -3/+7 | |
| | | | | | And delete the associated TODO. | |||||
| * | hsclient: Remove TODOs about circular references | Ian Jackson | 2023-03-01 | 1 | -10/+0 | |
| | | | | | | | | | These Arcs are all "downward", referencing items from layers lower in the stack. So they don't cause cycles. There was going to be a cycle involving the `OnionConnector` upcall trait, but we have just abolished that. | |||||
| * | hsclient: Abolish knowledge of HS circuits in circmgr | Ian Jackson | 2023-03-01 | 1 | -10/+1 | |
| | | | | | | | | | | | | Abolish CircMgr::get_or_launch_onion_client and everything to support it. We have decided that `.onion` diversion ccan't/shouldn't occur in tor-circmgr. Probably, it should occur much higher up - arti-client maybe - since it will sometimes need ambient authority (KS_hsc_*). Now all knowledge of HS connections is in tor-hsclient. This gets rid of a layering inversion and the trait needed for tor-circmgr to do the upcall to tor-hsclient. | |||||
| * | hsclient isol_map: Use 1:1 notation in diagram to show correspondence | Ian Jackson | 2023-03-01 | 1 | -1/+1 | |
| | | ||||||
| * | hsclient isol_map: Document invariant, fix comment, terminology | Ian Jackson | 2023-03-01 | 1 | -9/+15 | |
| | | | | | Use the occupied/vacant terminology that the slotmap docs use. | |||||
| * | hsclient state: Rename rechecks (from attempts) and add clarifying docs | Ian Jackson | 2023-03-01 | 2 | -9/+25 | |
| | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1034#note_2882079 | |||||
| * | hsclient keys: Be more explicit about HsClientSecretKeys nullable | Ian Jackson | 2023-03-01 | 1 | -5/+9 | |
| | | | | | | It can contain no keys; state this more prominently, and explain what it represents. Also fix a few typos etc. | |||||
| * | hsclient state: Implement and test MultikeyIsolatedMap::retain | Ian Jackson | 2023-03-01 | 2 | -3/+109 | |
| | | ||||||
| * | hsclient state: Split off MultikeyIsolatedMap | Ian Jackson | 2023-03-01 | 3 | -82/+189 | |
| | | ||||||
| * | hsclient state: Move all the data fields into the table | Ian Jackson | 2023-03-01 | 1 | -28/+37 | |
| | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1034#note_2881576 This is a singificant simplification, in fact. | |||||
| * | hsclient: Clarify period task handle TODO | Ian Jackson | 2023-03-01 | 1 | -1/+1 | |
| | | ||||||
| * | hsclient: Document sharing rules | Ian Jackson | 2023-03-01 | 2 | -0/+15 | |
| | | | | | | Text largely from https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1034#note_2881638 | |||||
| * | hsclient state: rustfmt | Ian Jackson | 2023-03-01 | 1 | -241/+244 | |
| | | | | | | | Autogenerated with rustfmt; no code changes. This tidies up the bizarre formatting. | |||||
| * | hsclient state: Lots more doc comments about barriers, structure, etc. | Ian Jackson | 2023-03-01 | 1 | -2/+74 | |
| | | ||||||
| * | hsclient state: Break `obtain` out into a fn | Ian Jackson | 2023-03-01 | 1 | -61/+82 | |
| | | | | | | | | | | | This is getting rather confusing; simply reformtting it won't do, I think. Also there would be much rightward drift. So move the meat out into the new function. (And introduce a convenience alias for its captures.) Docs and reformatting will follow in a moment. | |||||
| * | hsclient state: Demonstrate that our future is now Send | Ian Jackson | 2023-03-01 | 1 | -3/+9 | |
| | | ||||||
| * | hsclient state: Restructure using a scope to drop the mutex guard | Ian Jackson | 2023-03-01 | 1 | -20/+44 | |
| | | | | | | | | | | | | | Explicit drops don't work. Instead, introduce a scope. We need two scopes, actually: one where we do the initial table wrangling, and one for the retries after relock. So we must put the meat in a closure so we can reuse it. And we must return the flow control as an enum. Bah, etc. Avoid reformatting this for the moment. This makes the delta legible... | |||||
| * | hsclient state: Break out ServiceState::blank | Ian Jackson | 2023-03-01 | 1 | -5/+12 | |
| | | | | | | We're going to have another function which will want this. Leave a convenience closure to capture the runtime. | |||||
| * | hsclient state: Move error inspection before guard re-lock. | Ian Jackson | 2023-03-01 | 1 | -4/+5 | |
| | | | | | | | This is still correct from a lock hierarchy pov. It moves the guard relock to the end, which is going to be necessary since it is going to have to move right outside the loop. | |||||
| * | hsclient keys: Add a todo to remove spurious Option | Ian Jackson | 2023-03-01 | 1 | -0/+3 | |
| | | ||||||
| * | hsclient keys: Compare all empty sets of keys as equal | Ian Jackson | 2023-03-01 | 1 | -1/+5 | |
| | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1034#note_2881575 | |||||
| * | hsclient keys: Fix non-equal keys test to provide a (dummy) key (fmt) | Ian Jackson | 2023-03-01 | 1 | -1/+4 | |
| | | ||||||
| * | hsclient keys: Fix non-equal keys test to provide a (dummy) key | Ian Jackson | 2023-03-01 | 1 | -4/+10 | |
| | | | | | | We're about to fix the comparison to treat all empty key sets as equal. | |||||
| * | hsclient keys: Provide :none() and Default and .is_empty() | Ian Jackson | 2023-03-01 | 1 | -1/+22 | |
| | | ||||||
| * | hsclient keys: Fix a missing full stop | Ian Jackson | 2023-03-01 | 1 | -1/+1 | |
| | | ||||||
| * | hsclient state: Test most important code paths | Ian Jackson | 2023-03-01 | 2 | -18/+147 | |
| | | ||||||
| * | hsclient: Provide some missing debug impls and trace messages | Ian Jackson | 2023-03-01 | 2 | -2/+25 | |
| | | ||||||
| * | Apply rustfmt | Ian Jackson | 2023-03-01 | 2 | -43/+71 | |
| | | ||||||
| * | hsclient state: Provide one test | Ian Jackson | 2023-03-01 | 1 | -0/+100 | |
| | | ||||||
| * | hsclient: Use a generic to provide a mock for connect() | Ian Jackson | 2023-03-01 | 3 | -21/+76 | |
| | | | | | This will allow us to test state.rs. | |||||
| * | hsclient: Apply standard lint block | Ian Jackson | 2023-03-01 | 1 | -1/+37 | |
| | | ||||||
| * | hsclient: Move dead code allows to specific locations | Ian Jackson | 2023-03-01 | 3 | -1/+4 | |
| | | ||||||
| * | hsclient: Add vacuous comments as demanded by clippy | Ian Jackson | 2023-03-01 | 3 | -0/+7 | |
| | | ||||||
| * | hsclient state: Bind a variable to stop rustfmt doing a terrible thing | Ian Jackson | 2023-03-01 | 1 | -5/+7 | |
| | | ||||||
| * | hsclient: Provide a constructor for HsClientConnector | Ian Jackson | 2023-03-01 | 2 | -10/+25 | |
| | | ||||||
| * | hsclient: Implement connection attempt tracking state machine | Ian Jackson | 2023-03-01 | 4 | -42/+389 | |
| | | | | | This compiles, but it cannot work yet. Nor can it conveniently be tested. | |||||
| * | HS secret keys: Move aggregate/config to tor-hsclient | Ian Jackson | 2023-03-01 | 1 | -0/+79 | |
| | | | | | | | | | Provide a more cookied "secret keys for use to connecting to a particular HS" type, with a builder. This wants to use config stuff, so oughtn't to be in tor-*crypto. The individual types remain there. | |||||
