summaryrefslogtreecommitdiff
path: root/crates/tor-hsclient/src
Commit message (Collapse)AuthorAgeFilesLines
* tor-hsclient: Fix a doc link.Nick Mathewson2023-03-301-1/+1
|
* Run rustfmtIan Jackson2023-03-301-13/+14
| | | | Apply this churn, which I deferred for ease of review.
* tor-hsconn: Rename ConnError (from HsClientConnError)Ian Jackson2023-03-304-19/+19
| | | | | The old name was unwieldy and other crates can just as well name it by the crate scope.
* tor-client: Pass a netdir for each requestIan Jackson2023-03-303-15/+24
| | | | | This will be more convenient inside tor-hsclient. In arti-client, this mirrors the way TorClient::get_or_launch_exit_circ works.
* Pass HS identity to hsclient connection functionIan Jackson2023-03-282-2/+10
| | | | Obviously it will need this!
* Pass HsCircPool to hsclient connect function, not CircMgrIan Jackson2023-03-282-5/+6
| | | | | We separated this out in the circmgr API. This is what the HS client needs. It doesn't want to participate in the general circuit pool.
* tor-hsclient: Have the public API take StreamIsolationIan Jackson2023-03-231-2/+7
|
* tor-hsclient: impl HasKind for errorsIan Jackson2023-03-231-1/+20
|
* tor-hsclient: Swap errors so Bug comes lastIan Jackson2023-03-231-4/+4
| | | | This seems more consistent with the way it's done elsewhere.
* tor-hsclient: Document clone-nature of HsClientConnectorIan Jackson2023-03-231-0/+3
|
* Fix typosDimitris Apostolou2023-03-031-3/+3
|
* hsclient: Discuss HsClientConnector multiplicity/reuseIan Jackson2023-03-011-3/+7
| | | | And delete the associated TODO.
* hsclient: Remove TODOs about circular referencesIan Jackson2023-03-011-10/+0
| | | | | | | | These Arcs are all "downward", referencing items from layers lower in the stack. So they don't cause cycles. There was going to be a cycle involving the `OnionConnector` upcall trait, but we have just abolished that.
* hsclient: Abolish knowledge of HS circuits in circmgrIan Jackson2023-03-011-10/+1
| | | | | | | | | | | Abolish CircMgr::get_or_launch_onion_client and everything to support it. We have decided that `.onion` diversion ccan't/shouldn't occur in tor-circmgr. Probably, it should occur much higher up - arti-client maybe - since it will sometimes need ambient authority (KS_hsc_*). Now all knowledge of HS connections is in tor-hsclient. This gets rid of a layering inversion and the trait needed for tor-circmgr to do the upcall to tor-hsclient.
* hsclient isol_map: Use 1:1 notation in diagram to show correspondenceIan Jackson2023-03-011-1/+1
|
* hsclient isol_map: Document invariant, fix comment, terminologyIan Jackson2023-03-011-9/+15
| | | | Use the occupied/vacant terminology that the slotmap docs use.
* hsclient state: Rename rechecks (from attempts) and add clarifying docsIan Jackson2023-03-012-9/+25
| | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1034#note_2882079
* hsclient keys: Be more explicit about HsClientSecretKeys nullableIan Jackson2023-03-011-5/+9
| | | | | It can contain no keys; state this more prominently, and explain what it represents. Also fix a few typos etc.
* hsclient state: Implement and test MultikeyIsolatedMap::retainIan Jackson2023-03-012-3/+109
|
* hsclient state: Split off MultikeyIsolatedMapIan Jackson2023-03-013-82/+189
|
* hsclient state: Move all the data fields into the tableIan Jackson2023-03-011-28/+37
| | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1034#note_2881576 This is a singificant simplification, in fact.
* hsclient: Clarify period task handle TODOIan Jackson2023-03-011-1/+1
|
* hsclient: Document sharing rulesIan Jackson2023-03-012-0/+15
| | | | | Text largely from https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1034#note_2881638
* hsclient state: rustfmtIan Jackson2023-03-011-241/+244
| | | | | | Autogenerated with rustfmt; no code changes. This tidies up the bizarre formatting.
* hsclient state: Lots more doc comments about barriers, structure, etc.Ian Jackson2023-03-011-2/+74
|
* hsclient state: Break `obtain` out into a fnIan Jackson2023-03-011-61/+82
| | | | | | | | | | This is getting rather confusing; simply reformtting it won't do, I think. Also there would be much rightward drift. So move the meat out into the new function. (And introduce a convenience alias for its captures.) Docs and reformatting will follow in a moment.
* hsclient state: Demonstrate that our future is now SendIan Jackson2023-03-011-3/+9
|
* hsclient state: Restructure using a scope to drop the mutex guardIan Jackson2023-03-011-20/+44
| | | | | | | | | | | | Explicit drops don't work. Instead, introduce a scope. We need two scopes, actually: one where we do the initial table wrangling, and one for the retries after relock. So we must put the meat in a closure so we can reuse it. And we must return the flow control as an enum. Bah, etc. Avoid reformatting this for the moment. This makes the delta legible...
* hsclient state: Break out ServiceState::blankIan Jackson2023-03-011-5/+12
| | | | | We're going to have another function which will want this. Leave a convenience closure to capture the runtime.
* hsclient state: Move error inspection before guard re-lock.Ian Jackson2023-03-011-4/+5
| | | | | | This is still correct from a lock hierarchy pov. It moves the guard relock to the end, which is going to be necessary since it is going to have to move right outside the loop.
* hsclient keys: Add a todo to remove spurious OptionIan Jackson2023-03-011-0/+3
|
* hsclient keys: Compare all empty sets of keys as equalIan Jackson2023-03-011-1/+5
| | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1034#note_2881575
* hsclient keys: Fix non-equal keys test to provide a (dummy) key (fmt)Ian Jackson2023-03-011-1/+4
|
* hsclient keys: Fix non-equal keys test to provide a (dummy) keyIan Jackson2023-03-011-4/+10
| | | | | We're about to fix the comparison to treat all empty key sets as equal.
* hsclient keys: Provide :none() and Default and .is_empty()Ian Jackson2023-03-011-1/+22
|
* hsclient keys: Fix a missing full stopIan Jackson2023-03-011-1/+1
|
* hsclient state: Test most important code pathsIan Jackson2023-03-012-18/+147
|
* hsclient: Provide some missing debug impls and trace messagesIan Jackson2023-03-012-2/+25
|
* Apply rustfmtIan Jackson2023-03-012-43/+71
|
* hsclient state: Provide one testIan Jackson2023-03-011-0/+100
|
* hsclient: Use a generic to provide a mock for connect()Ian Jackson2023-03-013-21/+76
| | | | This will allow us to test state.rs.
* hsclient: Apply standard lint blockIan Jackson2023-03-011-1/+37
|
* hsclient: Move dead code allows to specific locationsIan Jackson2023-03-013-1/+4
|
* hsclient: Add vacuous comments as demanded by clippyIan Jackson2023-03-013-0/+7
|
* hsclient state: Bind a variable to stop rustfmt doing a terrible thingIan Jackson2023-03-011-5/+7
|
* hsclient: Provide a constructor for HsClientConnectorIan Jackson2023-03-012-10/+25
|
* hsclient: Implement connection attempt tracking state machineIan Jackson2023-03-014-42/+389
| | | | This compiles, but it cannot work yet. Nor can it conveniently be tested.
* HS secret keys: Move aggregate/config to tor-hsclientIan Jackson2023-03-011-0/+79
| | | | | | | | Provide a more cookied "secret keys for use to connecting to a particular HS" type, with a builder. This wants to use config stuff, so oughtn't to be in tor-*crypto. The individual types remain there.
* hsclient API: Remove notion of ambient keys fromk this layerIan Jackson2023-03-012-14/+5
|
* HS API: Remove HS client keys from circmgr APIIan Jackson2023-03-011-2/+1
| | | | | | | | *If* we're going to retain any HS knowledge in circmgr, it definitely doesn't need to know about per-operation client secrets. (Maybe there might be ambient secrets, used for .onion diversion, but they don't need to be in this API.)
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-27 03:50:28 +0000