| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | |
|
| |
|
|
| |
Found by "git grep adhoc" and manual inspection.
|
| | |
|
| | |
|
| |
|
|
|
| |
Prompted by clippy complaining that the content wasn't ever read other
than by the autogenerated Debug impl.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
This will let us impl for dyn StdError.
|
| |
|
|
|
| |
This impl can only compile for Self: Sized. This will let us remove
the Sized bound from the trait itself.
|
| |
|
|
|
|
| |
We're going to need to make change to this trait which would be
breaking for out-of-crate implementors. This should have been sealed
all along.
|
| |
|
|
|
|
|
|
| |
Our HSS code isn't going to work if you run more than one copy. Soon
we'll detect this (via our use of tor_persist).
There may be other places this ought to be used. Eg if we get
EADDRINUSE from trying to set up a proxy, maybe ...
|
| |
|
|
|
|
|
|
|
| |
Tbis will result in "some message ...: the error" which I think is OK.
We don't use a Unicode single-character ellipsis because that
character can be hard to read at font sizes which are otherwise OK for
text, and because use of non-ascii in logfiles and error messages is
unecessary and might cause unnecessary trouble (for example, if the
log messages end up going somewhere which isn't 100% valid UTF-8).
|
| |
|
|
|
| |
Possibly at some point in the past, matching a slice directly wasn't
possible. But it is now.
|
| | |
|
| |
|
|
|
|
|
|
| |
According to the `ErrorKind` lumping guidelines, `KeystoreFsPermissions`
should be lumped with `FsPermissions`: they represent the same type
of error, and their "location" is the same ("Host").
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1315#note_2916455
|
| | |
|
| |
|
|
|
| |
This code came from tor-error. So now tor-error depends on
retry-error.
|
| |
|
|
|
|
|
|
|
|
| |
This launders the closure so that clippy's
clippy::redundant_closure_call can't see it.
We can't have a local #[allow] because it would be on an expression,
which isn't allowed on stable.
This avoids having to use more clumsy idioms at call sites.
|
| | |
|
| |
|
|
|
|
|
|
|
| |
Originally they didn't check err.kind(), since err.kind() can never
increase their severity. We lost that behavior with !1386, and we
became dependent on it with arti!1383. Since they both merged at
the same time, CI broke.
This patch restores their original behavior.
|
| |
|
|
|
|
|
|
|
|
| |
This abolishes some quintuplication.
The output is identical except that:
* The syntax display in the rustdoc output for the resulting macros
seems to have somewhat less whitepsace.
* The whimsical error messages in the examples are all identical.
Ah well.
|
| | |
|
| |\
| |
| |
| |
| | |
Optional tracing support in tor-error for error reporting
See merge request tpo/core/arti!1379
|
| | |
| |
| |
| |
| | |
(Also, document that this static assertion is the reason why you are
seeing a confusing error message.)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The main contribution here is a set of convenience macros for
logging error `Report`s. Notably, this macros always logs
`Internal` and `BadAspiUsage` errors at `WARN`, unless they
are already at `ERROR` or more.
This is a little tricky because `tracing::event!()` requires
its Level argument to be a constant.
|
| |/
|
|
| |
Closes #950.
|
| | |
|
| |
|
|
| |
Let's defer this decision.
|
| | |
|
| | |
|
| |
|
|
|
| |
(I see no problems with this macro. In the worst case, we deprecate
it someday.)
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
These have been subsumed by other errorkinds, mostly
OnionServiceProtocolViolation and TorProtocolViolation.
In particular please review the change in tor-hsclient closely;
I am not sure about the new errorkinds for the error there.
|
| |\
| |
| |
| |
| |
| |
| | |
Generate correct-ish socks5 errors for onion service errors.
Closes #736
See merge request tpo/core/arti!1279
|
| | |
| |
| |
| | |
Use this to emit HS_BAD_ADDRESS as appropriate.
|
| | |
| |
| |
| |
| | |
These errors are orthogonal to our actual error kinds. See
discussion on #736.
|
| |\ \
| |/
|/|
| |
| | |
lints: Promote clippy::print_stderr and clippy::print_stdout
See merge request tpo/core/arti!1271
|
| | | |
|
| |/ |
|
| |
|
|
|
| |
Having a newtype for this kind of thing is considerably more
convenient. I'm going to use this in a moment.
|
| | |
|
| |
|
|
| |
Signed-off-by: Gabriela Moldovan <[email protected]>
|
| |
|
|
|
|
| |
OnionServiceDescriptorValidationFailed.
Signed-off-by: Gabriela Moldovan <[email protected]>
|
| |
|
|
|
| |
We're going to use this for rendezvous completion timeout, which could
be due to basically anything.
|
| |
|
|
|
|
| |
This basically always means we couldn't cope with the descriptor.
We need to extend the description of OnionServiceDescriptorValidationFailed
|
| |
|
|
|
| |
This factors out an ad-hoc AsRef impl. We're going to want to reuse
this for another error type.
|
| |
|
|
| |
Signed-off-by: Gabriela Moldovan <[email protected]>
|
| |
|
|
| |
Signed-off-by: Gabriela Moldovan <[email protected]>
|