summaryrefslogtreecommitdiff
path: root/crates/tor-error/src
Commit message (Collapse)AuthorAgeFilesLines
* Allow clippy::unchecked_duration_subtraction in testsNick Mathewson2023-01-273-0/+3
| | | | | This panics on error, and we're fine with a panic on misbehavior in tests.
* Disable clippy::unlinlined-format-argsNick Mathewson2023-01-271-0/+1
| | | | | | | | This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748.
* Fix typosDimitris Apostolou2023-01-071-1/+1
|
* Merge branch 'test-lints' into 'main'eta2023-01-062-0/+18
|\ | | | | | | | | Add test lint blocks to all "mod test" See merge request tpo/core/arti!937
| * test lint blocks: Add many many automaticallyIan Jackson2022-12-122-0/+18
| | | | | | | | | | This is precisely the result of running the rune in maint/adhoc-add-lint-blocks.
* | tor-error: tests: Add a test case for Report and Bug wrappingIan Jackson2022-12-151-0/+11
| |
* | tor-error: Provide ErrorReport extension trait with .report() methodIan Jackson2022-12-121-0/+32
| |
* | tor_error: Promote internal StdError alias to reportIan Jackson2022-12-121-5/+5
|/ | | | | The std::error::Error repetition was getting rather repetitively repetitious, and is about to get more so.
* Rename LocalLoginFailed to ExternalToolFailed.Nick Mathewson2022-11-291-2/+2
|
* Document better what LocalProtocolViolation does not cover.Nick Mathewson2022-11-291-1/+4
|
* ptmgr: Fill in some error-related code; resolve TODOs.Nick Mathewson2022-11-281-0/+5
|
* Use ErrorKind::TorAccessFailed for misbehaving bridgesIan Jackson2022-11-081-2/+3
| | | | (Use semantic linefeed for the doc comment.)
* Run add_warnings.Nick Mathewson2022-11-031-0/+1
|
* tor-error: Tidy up use of thiserror::ErrorIan Jackson2022-10-241-2/+4
| | | | | | | | 1. Import it, as we do elsewhere, and use that import. 2. Use thiserror to generate the Display impl, rather than derive_more, as we do for errors elsewhere. (tor_error still needs derive_more::Display for ErrorKind.)
* tor-error: Rename truncated module to miscIan Jackson2022-10-242-3/+3
| | | | | This has no external API change, but makes space for other miscellaneous errors to arrive later.
* tor-error: make HasRetryTime object-safeIan Jackson2022-10-211-0/+1
| | | | | | | | We could in the future provide a version of abs_retry_time which took an &dyn closure if that turns out to be wanted. I think this isn't a semver break because trait implementors are allowed to relax bounds.
* cargo fmt to remove blank linesIan Jackson2022-10-121-1/+0
| | | | | | | Apparently cargo fmt doesn't like these, which my perl rune didn't delete. This commit is precisely the result of `cargo fmt`.
* Replace all README copies in src/lib.rs with includesIan Jackson2022-10-121-7/+1
| | | | | | | | The feature we want is `#[doc = include_str!("README.md")]`, which is stable since 1.54 and our MSRV is now 1.56. This commit is precisely the result of the following Perl rune: perl -i~ -0777 -pe 's{(^//!(?!.*\@\@).*\n)+}{#![doc = include_str!("../README.md")]\n}m' crates/*/src/lib.rs
* Allow "clippy::single_char_pattern" in tests.Ian Jackson2022-10-121-0/+1
| | | | | | | This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome.
* Merge branch 'bridge-parse' into 'main'Ian Jackson2022-10-031-1/+0
|\ | | | | | | | | Parse (and format) bridge lines See merge request tpo/core/arti!745
| * tor-error::internal: Remove a redundant suppressionIan Jackson2022-09-301-1/+0
| | | | | | | | Spotted this in passing.
* | New ErrorKind::LocalProtocolFailed.Nick Mathewson2022-09-271-0/+7
|/ | | | | This type is by analogy to `RemoteProtocolFailed`; we'll use it for cases when the Socks proxy refuses to talk to us.
* force no inlining on internal_macro_testtrinity-1686a2022-09-091-0/+1
| | | | it may fix this test when running in release, where the function gets inlined, so its name does not appear in the backtrace
* Add a dbg!() to diagnose #570.Nick Mathewson2022-09-081-0/+9
| | | | | This won't fix anything, but it will let us see what the backtrace looks like when it fails.
* enable doc_auto_cfg feature on every crate when documenting for docs.rstrinity-1686a2022-08-241-0/+1
|
* Run maint/add_warning crates/*/src/{lib,main}.rsIan Jackson2022-06-231-0/+3
| | | | Update all lint blocks
* tor-error: Fix a broken intra-doc linkIan Jackson2022-06-101-1/+2
| | | | I didn't spot this in review amongst the other messages from Nightly.
* try to differentiate transient from nontransient errortrinity-1686a2022-06-081-1/+8
|
* lints: Make lint blocks consistentIan Jackson2022-05-311-0/+1
| | | | The remaining consequences of running add_warning
* lints: Add let_unit_value allow to all cratesIan Jackson2022-05-311-0/+1
| | | | | From running add_warning, with manual picking of the right hunks/lines.
* lints: Add lint block delimiters to every crateIan Jackson2022-05-311-0/+2
| | | | | | This was the result of: maint/add_warning crates/*/src/{lib,main}.rs and then manually curating the results.
* Placate rustfmtIan Jackson2022-05-171-5/+1
| | | | I found the previous layout *much* better. Ah well.
* Do backtrace string matching test only on some platforms.Ian Jackson2022-05-171-0/+19
| | | | | | "Fixes" #455 by suppressing the test. This is !509 redux.
* Revert "Merge branch 'backtrace' into 'main'"eta2022-05-161-6/+0
| | | This reverts merge request !509
* Do backtrace string matching test only on LinuxIan Jackson2022-05-161-0/+6
| | | | "Fixes" #455 by suppressing the test.
* Add new FsPermissions ErrorKind.Nick Mathewson2022-05-091-0/+9
|
* Fix grammar and typosSamanta Navarro2022-04-272-2/+2
|
* AbsRetryTime::from_sum: Provide a test caseIan Jackson2022-04-251-0/+15
| | | | | As requested in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/470#note_2798015
* AbsRetryTime::from_sum: Add missing full stopIan Jackson2022-04-251-1/+1
| | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/470#note_2797945
* retry-error: Provide AbsRetryTime::from_sub and use itIan Jackson2022-04-251-12/+14
| | | | This same calculation was in the code three times.
* tor-error: Handle integer overflowsSamanta Navarro2022-04-231-4/+27
| | | | | | | If duration addition overflows, then continue with Never. Caching the AbsRetryTime constructed with duration from supplied function also reduces the overhead of earliest_absolute.
* RetryTime: Improve documentation.Nick Mathewson2022-04-041-7/+27
| | | | | | | | | For each case, describe its semantics (in addition to when you would create it). Explain the relationship between After and At. Stop saying "Strategy": we renamed this type to "RetryTime".
* RetryTime: make loose_cmp pub.Nick Mathewson2022-04-041-1/+1
|
* RetryTime: use strum::EnumDiscriminants to simplify loose_cmp.Nick Mathewson2022-04-041-26/+69
| | | | | Also add tests for RetryTime comparison functions to make sure they work as expected.
* tor-error: Add a new RetryTime type and related trait.Nick Mathewson2022-04-042-0/+220
|
* tor-proto: better errors when handshake fails due to untimely certsNick Mathewson2022-03-231-0/+8
| | | | | | | | | | | | | | | | | | We now check the handshake certificates unconditionally, and only report them as _expired_ as a last resort. (Rationale: if somebody is presenting the wrong identity from a year ago, it is more interesting that they are presenting the wrong ID than it is that they are doing so with an expired cert. We also now report a different error if the certificate is expired, but its expiration is within the range of reported clock skew. (Rationale: it's helpful to distinguish this case, so that we can blame the failure on possible clock skew rather than definitely attributing it to a misbehaving relay.) Part of #405.
* Provide ErrorKind::OtherIan Jackson2022-03-041-0/+10
|
* Merge branch 'clippy-allow-arc-clone' into 'main'Nick Mathewson2022-03-011-1/+0
|\ | | | | | | | | Disable clippy::clone_on_ref_ptr See merge request tpo/core/arti!352
| * Disable clippy::clone_on_ref_ptrIan Jackson2022-02-241-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lint is IMO inherently ill-conceived. I have looked for the reasons why this might be thought to be a good idea and there were basically two (and they are sort of contradictory): I. "Calling ‘.clone()` on an Rc, Arc, or Weak can obscure the fact that only the pointer is being cloned, not the underlying data." This is the wording from https://rust-lang.github.io/rust-clippy/v0.0.212/#clone_on_ref_ptr It is a bit terse; we are left to infer why it is a bad idea to obscure this fact. It seems to me that if it is bad to obscure some fact, that must be because the fact is a hazard. But why would it be a hazard to not copy the underlying data ? In other languages, faliing to copy the underlying data is a serious correctness hazard. There is a whose class of bugs where things were not copied, and then mutated and/or reused in multiple places in ways that were not what the programmer intended. In my experience, this is a very common bug when writing Python and Javascript. I'm told it's common in golang too. But in Rust this bug is much much harder to write. The data inside an Arc is immutable. To have this bug you'd have use interior mutability - ie mess around with Mutex or RefCell. That provides a good barrier to these kind of accidents. II. "The reason for writing Rc::clone and Arc::clone [is] to make it clear that only the pointer is being cloned, as opposed to the underlying data. The former is always fast, while the latter can be very expensive depending on what is being cloned." This is the reasoning found here https://github.com/rust-lang/rust-clippy/issues/2048 This is saying that *not* using Arc::clone is hazardous. Specifically, that a deep clone is a performance hazard. But for this argument, the lint is precisely backwards. It's linting the "good" case and asking for it to be written in a more explicit way; while the supposedly bad case can be written conveniently. Also, many objects (in our codebase, and in all the libraries we use) that are Clone are in fact simply handles. They contain Arc(s) (or similar) and are cheap to clone. Indeed, that is the usual case. It does not make sense to distinguish in the syntax we use to clone such a handle, whether the handle is a transparent Arc, or an opaque struct containing one or more other handles. Forcing Arc::clone to be written as such makes for code churn when a type is changed from Arc<Something> to Something: Clone, or vice versa.
* | Fix typo in messageNick Mathewson2022-02-281-1/+1
| |
generated by cgit v1.2.3 (git 2.46.0) at 2026-08-26 21:05:58 +0000