summaryrefslogtreecommitdiff
path: root/crates/tor-dirserver
Commit message (Collapse)AuthorAgeFilesLines
...
* tor-dirserver: Document nested round-robinsClara Engler2025-12-101-2/+15
|
* tor-dirserver: Improve download_single's docClara Engler2025-12-101-5/+2
|
* tor-dirserver: Rename DownloadManager to ConsensusBoundDownloaderClara Engler2025-12-101-13/+13
|
* tor-dirclient: Remove Downloadable for goodClara Engler2025-12-101-4/+4
|
* tor-dirserver: Add doc for TcpConnect errorClara Engler2025-12-101-0/+4
|
* tor-dirserver: Documentation improvementsClara Engler2025-12-101-3/+5
|
* tor-dirserver: Replace IO with TcpConnect errorClara Engler2025-12-102-4/+18
| | | | | | | | This commit replaces `AuthorityCommunicationError::IO` with `AuthorityCommunicationError::TcpConnect` while removing the respective `From<std::io::Error>` implementation, mostly because an IO error is way too generic and in our case, it would only occurr with a failed TCP connection.
* tor-dirserver: Fix wrong warning sectionClara Engler2025-12-101-1/+1
|
* tor-dirserver: Implement DownloadManagerClara Engler2025-12-104-0/+401
| | | | | | | | | This commit implements the DownloadManager in its own module, an object responsible for downloading network documents from an upstream directory authority. Further motivation for this can be found in the rustdoc comment of the respectively introduced type.
* Bump all the unstable tor- and arti- crates to 0.37.0.Gabriela Moldovan2025-12-021-5/+5
| | | | | | | | | Done using: ``` for crate in $(./maint/list_crates | rg '^(tor|arti-)'); do cargo set-version -p $crate 0.37.0 done
* dirserver: Run cargo-sort in preparation for releaseGabriela Moldovan2025-12-011-3/+8
|
* Run fixup-features in preparation for releaseGabriela Moldovan2025-12-011-1/+1
|
* tor-dirserver: Improve database::TimestampClara Engler2025-11-272-64/+99
| | | | | | | | | | This commit improves upon the work made in arti!3460, by establishing the `database::Timestamp` type as a general purpose type for the handling of timestamp throughout the code base. It also replaces all previous occurrences of `SystemTime` within `dirmirror::operation`, which leads to the reduction of code complexity in one particular function, namely `calculate_sync_timeout`.
* tor-dirserver: Fix clippy warning for timeClara Engler2025-11-261-0/+4
|
* tor-dirserver: Use `saturating-time`Clara Engler2025-11-263-243/+91
| | | | | | | This commit replaces the custom implementation of `SaturatingSystemTime` with the `saturating-time` crate, additionally adding a new type to the `database` module called `Timestamp`, in order to have a convenient wrapper around `ToSql` and `FromSql`.
* Fix name of clippy lint to unchecked_time_subtraction (2)Ian Jackson2025-11-065-5/+5
| | | | Run maint/add_warning
* Merge branch 'dirserver-http-db' into 'main'Ian Jackson2025-11-052-120/+114
|\ | | | | | | | | tor-dirserver: Apply database changes to http See merge request tpo/core/arti!3426
| * tor-dirserver: clippy fixesClara Engler2025-11-032-4/+4
| |
| * tor-dirserver: Apply database changes to httpClara Engler2025-11-032-120/+114
| | | | | | | | | | | | | | | | | | | | This commit applies the recent changes to the database module into the http and http::cache module. Notably, this includes the use of the database::sql! macro as well as the use of database::read_tx and database::rw_tx for creation transaction and saving, as well as retrying, although the latter one is subject to SQLite's own busy handler
* | tor-dirserver: Refactor cons retrieval with JOINClara Engler2025-11-041-19/+16
|/ | | | | | | | | | | | This commit refactors `get_recent_consensus()` in `tor-dirserver` to use a single SQL statement with the power of `INNER JOIN` instead of two SQL statements querying the store after retrieving the SHA256 hash. The primary motivation for this is to have cleaner code. A single SQL statement is often-times easier to comprehend, as well more performant in execution, although that can only be proven with a profiler and is not of much concern, given that this function is only executed roughly every 60-90min.
* tor-dirserver: Add SaturatingSystemTimeClara Engler2025-10-303-156/+289
| | | | | | This commit changes various things in the dirmirror operation, namely the use of a SystemTime wrapper type that provides saturation on both ends.
* tor-dirserver: Ensure positive timestampsClara Engler2025-10-301-1/+5
| | | | | This commit adds `CHECK` constraints to the database schema in order to ensure all timestamps are positive.
* tor-dirserver: Small database::open() improvementsClara Engler2025-10-301-115/+58
|
* tor-dirserver: Make database full syncClara Engler2025-10-306-292/+231
| | | | | | | | | | This commit makes the entire database operations synchronous, thereby replacing deadpool with r2d2. The full motivation is outlined in a rustdoc comment at the top of the `database` module, but it can be summarized to the fact that SQLite is by design inherently synchronous due to directly interfacing with the file system.
* tor-dirserver: Outline the dirmirror operationClara Engler2025-10-302-147/+260
| | | | | | | | | | This commit creates a function named `mirror::operation::serve`, that will serve as the primary entry point for the dirmirror operation. While the function itself already contains some logic, such as querying the timeout to wait for the next consensus, it is largely a rustdoc design document that adds lots of comment to the `mirror::operation` module.
* tor-dirserver: Implement download timeoutClara Engler2025-10-304-0/+450
| | | | | | | | | | This commit starts work in the `mirror::operation` module by implementing the functions for calculating the `Duration` to wait from a given `SystemTime` until the point in time when the dirmirror should download new documents from the authorities again. Also, this commit introduces new error types and internal helper functions in order to fulfill this purpose better.
* tor-dirserver: Implement read_tx and rw_txClara Engler2025-10-302-55/+352
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit does a large overhaul in the overall way on how we interact with SQLite. Although SQLite is a fairly straightforward tool, it has one large caveat, namely the handling of the infamous `SQLITE_BUSY` error. In WAL mode, the journaling mode we are using, the respective error may occur if there is an existing write transaction while another thread is trying to either upgrade an existing read transaction or create an exclusive transaction at the same time. In this case, SQLite will fail at the statement that either requires the write operation or at the creation of the transaction respectively. In order to tackle this problem, SQLite provides the `busy_timeout` pragma, which allows specifying a timeout in milliseconds during which SQLite will retry to obtain a write transaction or fail immediately. This only works in the latter case, that is, creating a write transaction from the beginning. To solve this issue, we introduce two new functions: 1. `database::read_tx` 2. `database::rw_tx` Both functions accept a database pool alongside a closure accepting a `Transaction` and returning an arbitrary return value. The first function creates a deferred transaction that gets rolled-back in the end, making it suitable for read-only connections. The latter function creates an exclusive transaction that gets committed in the end, making it suitable for read-write connections. This also honors the `busy_timeout`, i.e. the function retries for up to 1s to acquire a write transaction before failing ultimately.
* tor-dirmirror: Introduce the `sql!` macroClara Engler2025-10-303-2/+23
| | | | | | This commit introduces the no-op sql macro used to mark string literals as SQL statements. It is purely semantical and serves the purpose to quickly identify string literals as SQL statements.
* tor-dirserver: Outline the `mirror` APIClara Engler2025-10-302-1/+150
| | | | | | This commit introduces the `mirror` module which is fairly boilerplate at the moment. However, everything of it is very well documented using rustdoc, thereby more or less creating a design document.
* maint: remove all semver.md filesSteven Engler2025-10-301-3/+0
|
* maint: bump minor versions of all published cratesSteven Engler2025-10-291-2/+2
| | | | | | | ```bash readarray -t publish < <(cargo metadata --format-version 1 | jq -r '.packages[] | select((.id | startswith("path+file:///")) and (.rust_version != null) and (.publish == null or .publish == true or .publish != [])) | .name') for package in "${publish[@]}"; do echo "$package:"; cargo set-version --bump minor -p "$package"; done ```
* tor-dirserver: add missing semver breaking changesSteven Engler2025-10-281-0/+3
|
* tor-dirserver: bump MSRV from 1.83 to 1.86hashcatHitman2025-10-211-1/+1
| | | | | | | | | | | | I noticed that when doing `cargo generate-lockfile` in the workspace root, it was locking dependencies to 1.83 compatible versions. It turns out tor-dirserver started on MSRV 1.83 after we already bumped to 1.85, and has been missed in MSRV updates ever since. I've found no indication it is intentionally getting this special treatment and am assuming it is a mistake. Signed-off-by: hashcatHitman <[email protected]>
* tor-dirserver: Expose Arc of StoreCacheClara Engler2025-10-152-15/+15
|
* tor-dirserver: Do not lock during db queryClara Engler2025-10-151-7/+14
|
* tor-dirserver: Don't expose rusqlite::Error in PoolClara Engler2025-10-153-11/+28
|
* tor-dirserver: Fix rustdoc commentClara Engler2025-10-151-3/+3
|
* tor-dirserver: Some clippy fixesClara Engler2025-10-154-3/+19
|
* tor-dirserver: Remove unsafe unreachableClara Engler2025-10-151-3/+3
|
* tor-dirserver: Remove due TODOClara Engler2025-10-151-4/+0
|
* tor-dirserver: Improve the error situationClara Engler2025-10-153-140/+140
|
* tor-dirserver: Create database moduleClara Engler2025-10-153-88/+98
| | | | | This commit renames the schema module to the database module in order to perform better error handling while redesigning the API.
* tor-dirserver: Remove unused importsClara Engler2025-10-152-9/+0
|
* tor-dirserver: Store endpoint paths in `&str`Clara Engler2025-10-151-11/+34
|
* tor-dirserver: Get rid of the poor buildersClara Engler2025-10-153-138/+20
|
* tor-dirserver: Move StoreCache into own moduleClara Engler2025-10-152-151/+178
|
* release: Bump versions.Wesley Aptekar-Cassels2025-10-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because we've updated our MSRV, we must bump the minor version for every package. This was done as follows: cargo set-version -p arti 1.6.0 cargo set-version -p oneshot-fused-workaround 0.4.0 cargo set-version -p slotmap-careful 0.4.0 cargo set-version -p test-temp-dir 0.5.0 cargo set-version -p fslock-guard 0.4.0 cargo set-version -p hashx 0.5.0 cargo set-version -p equix 0.4.0 cargo set-version -p caret 0.7.0 cargo set-version -p fs-mistrust 0.12.0 cargo set-version -p safelog 0.6.0 cargo set-version -p retry-error 0.8.0 xargs -I P <<END cargo set-version -p P 0.35.0 tor-basic-utils tor-error tor-general-addr tor-geoip tor-rtcompat tor-rtmock tor-async-utils tor-config tor-config-path tor-rpc-connect tor-log-ratelim tor-rpcbase tor-memquota tor-units tor-llcrypto tor-bytes tor-protover tor-checkable tor-cert tor-key-forge tor-hscrypto tor-socksproto tor-linkspec tor-cell tor-proto tor-netdoc tor-consdiff tor-netdir tor-relay-selection tor-persist tor-keymgr tor-chanmgr tor-ptmgr tor-dircommon tor-guardmgr tor-circmgr tor-dirclient tor-dirmgr tor-dirserver tor-hsclient tor-hsservice tor-hsrproxy tor-relay-crypto arti-client arti-relay arti-rpcserver arti-ureq arti-rpc-client-core END
* release: Run fixup-features.Wesley Aptekar-Cassels2025-10-011-0/+3
|
* Remove "doc_auto_cfg" incantation from all crates.Nick Mathewson2025-09-291-1/+1
| | | | This feature has been removed from nightly, in favor of doc_cfg.
* tor-dirserver: Allow complexity in some fn'sClara Engler2025-09-041-0/+2
| | | | | | | This commit allows `#[allow(clippy::cognitive_complexity)]` in `HttpServer::serve` and `HttpServer::handler_tx`. Allowing this might be controversial but both functions, especially the latter one, are well documented.