| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Throughout: Use *_report!() macros for reporting Errors. | Nick Mathewson | 2023-07-07 | 1 | -9/+6 |
| | | | | | | | | | | | | | | | | I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. | ||||
| * | s/BridgeDescManager/BridgeDescMgr/g in codebase | Neel Chauhan | 2023-04-12 | 1 | -2/+2 |
| | | |||||
| * | Use ErrorReport's .report() for two errors in error! in bridgedesc.rs | Ian Jackson | 2023-01-30 | 1 | -3/+3 |
| | | | | | No functional change, just using the new idiom. | ||||
| * | "Fix" remaining unchecked-subtraction warnings. | Nick Mathewson | 2023-01-27 | 1 | -1/+3 |
| | | | | | | In both cases I think it's fine to panic; but it's best to do so explicitly. | ||||
| * | dirmgr: Spelling fixes and normali[sz]ations | Nick Mathewson | 2022-12-06 | 1 | -11/+11 |
| | | |||||
| * | bridge desc mgr: Add dormancy comment to effective_parallelism | Ian Jackson | 2022-11-23 | 1 | -0/+2 |
| | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/861#note_2856922 | ||||
| * | bridge desc mgr: Honour specified dormancy | Ian Jackson | 2022-11-23 | 1 | -6/+13 |
| | | | | | Fixes #630 | ||||
| * | bridge desc mgr: Introduce effective_parallelism helper | Ian Jackson | 2022-11-23 | 1 | -5/+12 |
| | | |||||
| * | bridge desc mgr: Move set_dormancy to impl that is for mock too | Ian Jackson | 2022-11-23 | 1 | -6/+6 |
| | | |||||
| * | BridgeConfig: Replace all Arc<BridgeConfig> with BridgeConfig | Ian Jackson | 2022-11-22 | 1 | -3/+3 |
| | | | | | BridgeConfig is itself an Arc now, so these are redundant. | ||||
| * | dirmgr Store: Introduce DirMgrStore and use for BridgeDescMgr (fmt) | Ian Jackson | 2022-11-14 | 1 | -8/+1 |
| | | | | | rustfmt only, broken out to ease review. | ||||
| * | dirmgr Store: Introduce DirMgrStore and use for BridgeDescMgr | Ian Jackson | 2022-11-14 | 1 | -6/+8 |
| | | | | | We are going to change DirMgr's constructors to also take a DirMgrStore. | ||||
| * | dirmgr Store: Abolish redundant trait impl | Ian Jackson | 2022-11-14 | 1 | -1/+1 |
| | | |||||
| * | bridge descriptor dormancy: Accept the dormancy value | Ian Jackson | 2022-11-11 | 1 | -1/+10 |
| | | | | | But right now, don't do anything with it. That will come in a future MR. | ||||
| * | bridge descriptor dormancy: Add a TODO for this enum | Ian Jackson | 2022-11-11 | 1 | -0/+2 |
| | | |||||
| * | bridge descriptor dormancy: Define an enum and semantics | Ian Jackson | 2022-11-10 | 1 | -0/+39 |
| | | | | | This is part of #630. | ||||
| * | Merge branch 'bridge-error' into 'main' | Nick Mathewson | 2022-11-10 | 1 | -3/+2 |
| |\ | | | | | | | | | Use ErrorKind::TorAccessFailed for misbehaving bridges See merge request tpo/core/arti!842 | ||||
| | * | Use ErrorKind::TorAccessFailed for misbehaving bridges | Ian Jackson | 2022-11-08 | 1 | -3/+2 |
| | | | | | | | | | (Use semantic linefeed for the doc comment.) | ||||
| * | | Merge branch 'bdm-process-doc-test' into 'main' | Nick Mathewson | 2022-11-10 | 1 | -2/+0 |
| |\ \ | | | | | | | | | | | | | bridge descs: Add tests for process_document See merge request tpo/core/arti!841 | ||||
| | * | | bridge descs: Add tests for process_document | Ian Jackson | 2022-11-08 | 1 | -2/+0 |
| | |/ | |||||
| * | | Merge branch 'bdm-params' into 'main' | Nick Mathewson | 2022-11-10 | 1 | -1/+0 |
| |\ \ | | | | | | | | | | | | | Remove TODO re BridgeDescDownloadConfig defaults See merge request tpo/core/arti!839 | ||||
| | * | | Remove TODO re BridgeDescDownloadConfig defaults | Ian Jackson | 2022-11-08 | 1 | -1/+0 |
| | |/ | |||||
| * / | bridge desc: todo re config: weaken and reference a new ticket | Ian Jackson | 2022-11-08 | 1 | -3/+2 |
| |/ | |||||
| * | Merge branch 'store' into 'main' | Nick Mathewson | 2022-11-08 | 1 | -29/+172 |
| |\ | | | | | | | | | | | | | Persistently cache bridge descriptors Closes #619 See merge request tpo/core/arti!831 | ||||
| | * | bridge descs: Rename BridgeDescMgr from BridgeDescManager | Ian Jackson | 2022-11-08 | 1 | -13/+13 |
| | | | | | | | | | | | | | This is more consistent with our naming elsewhere. Suggested-by: Nick Mathewson <[email protected]> | ||||
| | * | bridge descs: Apply sensitive() to bridge identity in error log msg | Ian Jackson | 2022-11-08 | 1 | -1/+2 |
| | | | |||||
| | * | bridge desc: Make Downloaded be Debug | Ian Jackson | 2022-11-04 | 1 | -0/+1 |
| | | | |||||
| | * | bridge desc: Implement cache reuse logic and if-modified-since | Ian Jackson | 2022-11-04 | 1 | -9/+115 |
| | | | | | | | | | | | | | | | | | | | | | | | | | This introduces the new API functions to Store. But currently they are all no-ops. So all this machinery doesn't actually do anything. Also, it changes the API to the mockable downloader, to allow it to support if-modified-since. So this isn't used either. But it is more convenient to do this all at once in BridgeDescManager, since care needs to be taken about the intraction between if-modified-since and the persistent cache. | ||||
| | * | bridge desc: Rename one more variable to text | Ian Jackson | 2022-11-04 | 1 | -1/+1 |
| | | | |||||
| | * | bridge desc: Catch panics in the download functionality | Ian Jackson | 2022-11-04 | 1 | -1/+8 |
| | | | |||||
| | * | bridge desc: Provide a Store to the bridge desc manager | Ian Jackson | 2022-11-04 | 1 | -9/+37 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We use the one in the dirmgr. That means that our constructor now has to take a dirmgr. And, the dirmgr must have a circmgr. This is all rather odd, TBH. Add .. to the binding of the return values from setup, as future-proofing. The tests now need to provide a Store too. Make the sqlite::new_empty function pub(crate) so we can use it. We must retain the _db_tmp_dir, since when it goes away the tmp directory is deleted and the db goes readonly. | ||||
| * | | Fix typos | Dimitris Apostolou | 2022-11-06 | 1 | -1/+1 |
| |/ | |||||
| * | bridgedesc: Rename "text" from "output" | Ian Jackson | 2022-11-03 | 1 | -5/+5 |
| | | | | | | | This was confusing, because it's the output of the donwload, but nowhere near the output of the whole process. And it's going to become even less so. | ||||
| * | bridgedesc: Make process_document into a free function | Ian Jackson | 2022-11-03 | 1 | -53/+67 |
| | | | | | It deserves this treatment, I think. | ||||
| * | bridgedesc: Introduce Downloaded | Ian Jackson | 2022-11-03 | 1 | -13/+17 |
| | | | | | | This gives names to things and makes things clearer, and this will be even more true in a moemnt. | ||||
| * | bridgedesc: download: Break out process_document | Ian Jackson | 2022-11-03 | 1 | -47/+54 |
| | | | | | We're going to want to reuse this for handling cached stuff. | ||||
| * | bridgedesc: Prepare Mockable trait for if-modified-since | Ian Jackson | 2022-11-03 | 1 | -4/+12 |
| | | |||||
| * | bridge descriptors: logging: Log addition and removal (fmt) | Ian Jackson | 2022-11-03 | 1 | -12/+20 |
| | | | | | Worsify formatting as demanded by rustfmt. | ||||
| * | bridge descriptors: logging: Log addition and removal | Ian Jackson | 2022-11-03 | 1 | -8/+31 |
| | | | | | | This involves breaking the calls to `new_bridges.remove` into a helper that does the logging. | ||||
| * | bridge descriptors: logging: Log download start and outcome | Ian Jackson | 2022-11-03 | 1 | -0/+6 |
| | | |||||
| * | bridge descriptors: Rewrite set_bridges | Ian Jackson | 2022-11-03 | 1 | -18/+12 |
| | | | | | | | | | This was fundamentally confused and irregular. Now it is more regular: it does the same things to all the elements of Tracked, and a simple filtering on current. This fixes a bug, for which I'm about to add a test case. | ||||
| * | bridge descriptors: Change default max_refetch | Ian Jackson | 2022-11-03 | 1 | -1/+1 |
| | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/820#note_2850269 | ||||
| * | bridge descriptors: Add clarification about bridge states | Ian Jackson | 2022-11-03 | 1 | -0/+3 |
| | | |||||
| * | bridge descriptors: Improve and fix docs for consider_launching | Ian Jackson | 2022-11-03 | 1 | -1/+6 |
| | | |||||
| * | bridge descriptors: Add comments where StateGuard is dropped | Ian Jackson | 2022-11-03 | 1 | -0/+8 |
| | | |||||
| * | bridge descriptors: Document `changed` and `earliest_timeout` Options | Ian Jackson | 2022-11-03 | 1 | -0/+5 |
| | | |||||
| * | bridge descriptors: Document updates argument to timeout_task | Ian Jackson | 2022-11-03 | 1 | -0/+6 |
| | | |||||
| * | bridge descriptors: Tests | Ian Jackson | 2022-11-03 | 1 | -0/+13 |
| | | |||||
| * | bridge descriptors: Provide a consistency check function | Ian Jackson | 2022-11-03 | 1 | -0/+196 |
| | | | | | | This is really part of the tests, but I put it here so that it can be compiled-in if someone wants it during debugging. | ||||
| * | bridge descriptors: Provide an implementation of BridgeDescProvider | Ian Jackson | 2022-11-03 | 1 | -0/+1095 |
| Tests will come in a moment. | |||||
