| Commit message (Collapse) | Author | Age | Files | Lines |
| | |
|
| |
|
| |
Co-authored-by: gabi-250 <[email protected]>
|
| |
|
|
|
|
|
|
| |
Some of the tests used derive(Builder), which is not current
practice for our configuration.
Additionally, they didn't implement the requisite ConfigBuilder
logic to pass with the other changes in this branch.
|
| |
|
|
|
|
|
| |
I've left the options here as booleans, but moved them into a
struct. (IMO, booleans are at their riskiest when they are passed
as function arguments, and much less risky when they are used as
struct fields.)
|
| |
|
|
|
|
| |
This functionality exposes the part of the configuration tree that
was actually used, along with any defaulted values. RPC will want
this.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This new method modifies a builder by replacing any unset values
that have a default with that default. We're using this method
so that we can re-serialize a builder into a `ConfigurationTree`
with all of its default values included.
In all cases, `b.apply_defaults()?; b.build()` should produce
the same output as `b.build()`.
The interesting parts of this commit are in tor_config::load
and tor_config::derive. The rest of this commit just adds
`apply_defaults` to other builders that _aren't_ made with
`derive_deftly(TorConfig)`.
|
| |
|
|
| |
This isn't strictly necessary, but it helps for consistency.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This affects the automatic builder code made by our
derive_deftly macro. It is only relevant (for now)
in the case of the `NonZero<>` types and their special handling.
Previously, when a builder contained Option<U>,
and we wanted to generate a configuration holding T,
we would _first_ apply a transformation from Option<U> to Option<T>
and _second_ unwrap the result or apply a default.
Now, we _first_ convert from Option<U> to U by applying a default,
and only _then_ perform any necessary conversion from U and T.
This is only relevant in the case where U and T are different.
It simplifies writing the defaults for `NonZero` options,
and will significantly simplify the logic for setting builder defaults.
|
| |
|
|
| |
It previously referred to a function that didn't exist.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow these types to be shared by arti and arti-relay.
This does change these types from being behind the experimental-api
flag. I think this is okay, as tor-config is not a stable crate anyways,
but it's worth keeping in mind.
There is also an argument to be made for having two separate types, one
in arti and one in arti-relay, as we do for LoggingConfig. I think that
using a single type has benefits, and we should strive to eventually
merge the LoggingConfigs, for instance, and perhaps other types, but it
doesn't seem critical in either direction at the moment.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
We'll use this in RPC to implement configuration changing.
|
| |
|
|
|
|
| |
This will be used by RPC. Probably. It might actually be a better
to re-serialize the configuration after parsing it, so that our
inspection functions can see default values.
|
| |
|
|
|
| |
Rust 1.88 added these, so we no longer have to use `any()` for false
and `all()` for true.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Previously, it used the sub_builder rule, which doesn't make sense
when the value is a stub place-holder to tell us whether to warn.
|
| |\
| |
| |
| |
| | |
Port several crates to derive_deftly(TorConfig)
See merge request tpo/core/arti!3691
|
| | |
| |
| |
| |
| |
| |
| |
| | |
1. When we are told to `extend_with`, we should obey that directive
even if we have a sub_builder etc.
2. Provide an `extend_with_replace` function for the common case
where we want to just replace one object with another.
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
|
| |
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
|
| |\
| |
| |
| |
| | |
Allow to set paths in CLI arguments
See merge request tpo/core/arti!3556
|
| | |
| |
| |
| | |
The set of allowable characters now includes colon, dot, slash, and backslash. This makes it a bit more convenient to pass in paths.
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
I'm undecided whether we want to keep `resolve_alternative_specs`
around, but it seems possible/likely that we'll want it in the future,
so I think we can keep it.
|
| |/
|
|
| |
This adds the lint to all our crates.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
These are a nicer syntax than using port "0" explicitly.
|
| |
|
|
| |
Nothing actually uses it any more, which is good.
|
| |
|
|
|
| |
Have the part of them that does the "no multiple addresses" work
be common, so that we can simplify how they actually behave.
|
| | |
|
| |
|
|
| |
This reverts commit c7c8eb5a03439ce31319389183e64cb0db539fc9.
|
| |
|
|
|
|
|
|
| |
This template is meant to replace most of our use of derive_builder
for configuration objects. Where possible and reasonable, it
delegates to existing macros, and automatically infers what special
patterns we use for individual types. In other cases, it uses
compile-time errors to inform the caller about pattern violations.
|
| |
|
|
|
|
|
|
| |
This trait will be implemented by every type that our
derive_deftly(TorConfig) template generates. It will, among other
things, help us figure out the Builder type for a given config type
in cases where string-pasting magic is intractable, or where we
want to use assert_not_impl to double-check the attributes.
|
| |
|
|
|
| |
The derive-deftly TorConfig template will use these as appropriate
for the inputs to setter functions, based on field types.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
If we don't do this, then any attempt to use it from a derive-deftly
template will cause a warning about referring to it as
$crate::macroname.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
derive_deftly wants to expand types before passing them to
macro_rules macros, which is quite reasonable. But map_builder
wants its input collection type to be an `ident`, not a `path`.
(And macro_rules doesn't accept `path` before a `<`.)
To fix this, we're providing an alternative syntax for map_builder,
where the inputs are the map type and the builder map type.
|
| | |
|