| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
|
| |
|
|
| |
This adds the lint to all our crates.
|
| |
|
|
|
| |
This hopefully will mean that future people will not need to spend time
figuring out the difference.
|
| |
|
|
| |
Makes it nicer to use asterisks for bold text.
|
| |
|
|
|
|
|
|
|
| |
Fixes part of #2193.
(Edits from nickm: I selected the cases here that I could verify
were correct from immediate context.)
Edited-by: Nick Mathewson <[email protected]>
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
| |
This feature has been removed from nightly, in favor of doc_cfg.
|
| |
|
|
|
| |
Only Unix systems use the variable path_resolver.
Annotate it as unused for all other systems.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| |
|
|
|
| |
Use unix-specific crates only if needed and suppress clippy warnings of
unused variables if their usage is unix-specific.
|
| |
|
|
| |
This resolves some nightly clippy warnings.
|
| |
|
|
| |
See #2060.
|
| |
|
|
|
|
| |
- Replaced `once_cell::sync::Lazy` with `std::sync::LazyLock`.
Signed-off-by: hashcatHitman <[email protected]>
|
| |
|
|
|
|
| |
We change `NoUnixAddressSupport` to `NoAfUnixSocketSupport` because it
doesn't make much sense to talk about support for the addresses
separately from support for the sockets.
|
| |
|
|
| |
Change `..UnixAddress...` to `...AfUnixAddress..`.
|
| | |
|
| |
|
|
|
|
|
| |
This patch fixes a relatively harmless build error introduced for
non-unix builds.
Additional comma introduced in b5aa8f7a88.
|
| |
|
|
|
|
| |
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
|
| | |
|
| |
|
|
|
| |
This time, we make explicit that it is a _base_ resolver,
and that it is client-only.
|
| |
|
|
|
|
|
|
| |
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.
|
| |
|
|
| |
We'll need this for implementing the connect point logic.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Also updated to use the `PATH_RESOLVER` resolver.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a big change across multiple crates since there isn't a good way
to break it up.
This changes the signature of `CfgPath::path` to:
```
pub fn path(&self, path_resolver: &CfgPathResolver) -> Result<PathBuf, CfgPathError> {
```
Making this change means that our global `CfgPathResolver` needs to be
stored in the 'arti-client' library instead of `tor-config-path`, and
must be passed through to anything that calls `path` to expand the
variables.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
These tests were in the 'test_serde' module, which wasn't the right
place for them.
|
| |\
| |
| |
| |
| | |
tor-config-path: remove exploratory code in comment
See merge request tpo/core/arti!2610
|
| | |
| |
| |
| |
| | |
I meant to remove this after confirming that the current approach
works; but apparently I never did.
|
| | |
| |
| |
| | |
I think `USER_HOME` was intended here.
|
| |/
|
|
|
| |
The old code used a shortcut to access the `Figment` directly, but we
need to do the whole config builder thing to be able to parse the toml.
|
| |
|
|
|
| |
This type behaves like a variant of `general::SocketAddr`
that allows the Unix variant to be a CfgPath.
|
| | |
|
| | |
|
| |
|
|
| |
This is a direct move of the `path` module from tor-config.
|
| |
|