| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | tor-circmgr: Log the kind of HS circuit stub we are selecting. | Gabriela Moldovan | 2024-06-03 | 1 | -1/+7 | |
| | | ||||||
| * | tor-circmgr: Remove VanguardMode from Pool (fmt). | Gabriela Moldovan | 2024-06-03 | 2 | -6/+2 | |
| | | ||||||
| * | tor-circmgr: Remove VanguardMode from Pool. | Gabriela Moldovan | 2024-06-03 | 3 | -34/+18 | |
| | | | | | | | | | | Storing the VanguardMode in multiple places (in the VanguardMgr *and* the HS circ Pool) is dangerous and can lead to split brain situations where different parts of the code think they are running in different VanguardModes. See #1424 | |||||
| * | tor-circmgr: Remove dangerous vanguards_enabled() function. | Gabriela Moldovan | 2024-06-03 | 2 | -9/+9 | |
| | | | | | | | | `VanguardMgr` should be the source of truth for obtaining the current `VanguardMode`. Closes #1424 | |||||
| * | tor-circmgr: Add a test to check that the pool uses the right VanguardMode. | Gabriela Moldovan | 2024-06-03 | 1 | -0/+86 | |
| | | | | | See arti#1424 | |||||
| * | tor-circmgr: Ensure we don't select an incompatible circuit stub. | Gabriela Moldovan | 2024-06-03 | 1 | -3/+19 | |
| | | | | | | | | | | | | Previously, HS stub circuit selection (with vanguards enabled) was buggy: when selecting a circuit stub from the circ pool, we failed to ensure its last hop was different from the circuit target. So in some cases, arti would attempt to extend a stub circuit of the form G -> L2 [-> L3] -> T to T, which can't work, because a relay won't extend a circuit to itself (or to its predecessor, for that matter). Closes #1417 | |||||
| * | tor-circmgr: Move vanguard circuit validation to a separate function. | Gabriela Moldovan | 2024-06-03 | 1 | -1/+20 | |
| | | | | | This will soon grow more complex. | |||||
| * | tor-circmgr: Return an error if HS circ has an invalid length. | Gabriela Moldovan | 2024-06-03 | 1 | -4/+15 | |
| | | | | | | | | | | | | | Previously, we'd `debug_assert` that the length of the path is valid. However, `debug_` asserts are compiled out for release builds, which means that if we have some code path that triggers the assertion failure, it will go unnoticed unless our tests happen to exercise it. It's safer to return an internal error, because we definitely don't want to proceed if the path is too short (see arti#1400 and arti#1409). Addresses https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2154#note_3030820 | |||||
| * | tor-guardmgr: Replace From impl with VanguardConfig::mode accessor. | Gabriela Moldovan | 2024-06-03 | 1 | -1/+1 | |
| | | ||||||
| * | tor-guardmgr: Use ExplicitOrAuto in the VanguardConfig | Gabriela Moldovan | 2024-06-03 | 1 | -1/+1 | |
| | | ||||||
| * | tor-guardmgr: Unconditionally define VanguardConfig. | Gabriela Moldovan | 2024-06-03 | 3 | -5/+5 | |
| | | | | | | | | | | We want to export the `VanguardConfig` even if the `vanguards` feature is disabled (we will need to unconditionally include it in the arti config). Note that if `vanguards` are disabled, the `VanguardMode` from the `VanguardConfig` can only be `Dsiabled`. | |||||
| * | tor-circmgr: Downgrade a HS-VANGUARDS TODO. | Gabriela Moldovan | 2024-06-03 | 1 | -1/+1 | |
| | | ||||||
| * | tor-circmgr: Fix a broken doc link. | Gabriela Moldovan | 2024-05-16 | 1 | -1/+1 | |
| | | ||||||
| * | tor-circmgr: Clarify module-level docs. | Gabriela Moldovan | 2024-05-16 | 1 | -0/+6 | |
| | | ||||||
| * | tor-circmgr: Replace STUB/STUB+ terminology with SHORT/EXTENDED (fmt). | Gabriela Moldovan | 2024-05-16 | 1 | -1/+3 | |
| | | ||||||
| * | tor-circmgr: Replace STUB/STUB+ terminology with SHORT/EXTENDED. | Gabriela Moldovan | 2024-05-16 | 3 | -46/+44 | |
| | | | | | | | | The previous STUB/STUB+ terminology was confusing, because STUB and STUB+ are both "circuit stubs" (but STUB is shorter than STUB+). Closes #1339 | |||||
| * | tor-circmgr: Rename HsCircStubKind::Stub to HsCircStubKind::Short. | Gabriela Moldovan | 2024-05-16 | 3 | -25/+31 | |
| | | | | | Part of #1339 | |||||
| * | tor-circmgr: Reword a somewhat inaccurate comment about vanguards. | Nick Mathewson | 2024-05-14 | 1 | -1/+1 | |
| | | ||||||
| * | tor-circmgr: Fix path not being extended if lite vanguards are enabled. | Gabriela Moldovan | 2024-05-14 | 1 | -1/+10 | |
| | | ||||||
| * | tor-circmgr: Assign error-handling closure to variable. | Gabriela Moldovan | 2024-05-14 | 1 | -7/+10 | |
| | | | | | We will soon need to reuse this. | |||||
| * | tor-circmgr: Rename neighbor_exclusion variables for clarity. | Gabriela Moldovan | 2024-05-14 | 1 | -4/+4 | |
| | | | | | | | I am about to reuse one of these on the "lite" vanguards branch. I am renaming them to make it easier to see which one of the two I will be using. | |||||
| * | tor-circmgr: After building the HS path, assert the length is correct. | Gabriela Moldovan | 2024-05-14 | 1 | -1/+18 | |
| | | | | | | | One of these assertions currently fails, because we have a bug in the vanguard path builder: if lite vanguards are enabled, we only build 2-hop circuits instead of 3. | |||||
| * | tor-circmgr: If necessary, extend the circuit to become STUB+. | Gabriela Moldovan | 2024-05-13 | 1 | -8/+42 | |
| | | | | | Closes #1400 | |||||
| * | tor-circmgr: Add a helper for extending HsCircStubs by one hop. | Gabriela Moldovan | 2024-05-13 | 1 | -2/+15 | |
| | | | | | | | We're about to use this in `maybe_extend_stub_circuit` too. Part of #1400 | |||||
| * | tor-circmgr: Remove TODO expressing doubt about VanguardHsPathBuilder. | Gabriela Moldovan | 2024-05-09 | 1 | -2/+0 | |
| | | | | | | I don't think it's all wrong, this was left over from the first draft implementation. | |||||
| * | tor-circmgr: Downgrade some TODO HS-VANGUARDs. | Gabriela Moldovan | 2024-05-09 | 2 | -2/+2 | |
| | | ||||||
| * | Re-run maint/add_warning. | Nick Mathewson | 2024-05-06 | 1 | -2/+2 | |
| | | | | | This commit is automatically generated. | |||||
| * | Resolve some clippy warnings about empty rustdoc. | Nick Mathewson | 2024-05-05 | 1 | -5/+1 | |
| | | | | | | (In most cases, by writing the documentation; in tests, by permitting the documentation to be missing.) | |||||
| * | tor-circmgr: Don't log unless we are launching some circuits. | Gabriela Moldovan | 2024-04-29 | 1 | -5/+7 | |
| | | | | | Otherwise we end up logging that we're launching 0 circuits. | |||||
| * | tor-circmgr: Remove no-longer-relevant TODO. | Gabriela Moldovan | 2024-04-29 | 1 | -1/+1 | |
| | | | | | The wanted_kind _does_ matter. | |||||
| * | tor-circmgr: The circuit must still be usable, even if vanguards are enabled. | Gabriela Moldovan | 2024-04-29 | 1 | -3/+1 | |
| | | ||||||
| * | tor-circmgr: Prefer STUB+ where possible. | Gabriela Moldovan | 2024-04-29 | 2 | -10/+61 | |
| | | | | | Closes #1385 | |||||
| * | tor-circmgr: Remove no-longer-needed dead_code allow. | Gabriela Moldovan | 2024-04-29 | 1 | -1/+0 | |
| | | ||||||
| * | tor-circmgr: Have separate targets for the STUB and STUB+ pools (fmt). | Gabriela Moldovan | 2024-04-29 | 1 | -3/+3 | |
| | | ||||||
| * | tor-circmgr: Have separate targets for the STUB and STUB+ pools. | Gabriela Moldovan | 2024-04-29 | 1 | -32/+46 | |
| | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2102#note_3024366 | |||||
| * | tor-circmgr: Add a TODO about launching HS circuits in parallel. | Gabriela Moldovan | 2024-04-29 | 1 | -0/+1 | |
| | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2102#note_3024370 | |||||
| * | tor-circmgr: Expand on the ForLaunch docs. | Nick Mathewson | 2024-04-29 | 1 | -1/+2 | |
| | | ||||||
| * | tor-circmgr: Remove an addressed TODO. | Gabriela Moldovan | 2024-04-29 | 1 | -13/+0 | |
| | | ||||||
| * | tor-circmgr: Log the kinds of circuits we're about to launch (fmt). | Gabriela Moldovan | 2024-04-29 | 1 | -4/+1 | |
| | | ||||||
| * | tor-circmgr: Log the kinds of circuits we're about to launch. | Gabriela Moldovan | 2024-04-29 | 2 | -3/+24 | |
| | | ||||||
| * | tor-circmgr: Remove no-longer-needed dead code allows. | Gabriela Moldovan | 2024-04-29 | 1 | -2/+0 | |
| | | ||||||
| * | tor-circmgr: Make a fraction of preemptive HS circuits be STUB+. | Gabriela Moldovan | 2024-04-29 | 2 | -11/+111 | |
| | | | | | Closes #1353 | |||||
| * | tor-guardmgr: Temporarily reintroduce VanguardConfig. | Gabriela Moldovan | 2024-04-29 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | As discussed on #tor-dev, I'm reintroducing `VanguardConfig` for now. The `VanguardConfig` specifies what mode (full/lite/disabled) the `VanguardMgr` should run in. We currently don't have a separate modes for HS clients and HS services. We shouldn't actually *need* a `VanguardConfig` at all, so this is just a (hopefully!) short- or medium-term fix until we sort out #1382 (which might involve making breaking changes to our `reconfigure()` APIs). Closes #1272 | |||||
| * | tor-circmgr: Loop until we run out of circuits to launch. | Gabriela Moldovan | 2024-04-25 | 1 | -1/+1 | |
| | | | | | | Previously this would only loop `n_to_launch - 1` times, so the pool was always 1 circuit short of the `n_to_launch` target. | |||||
| * | Use clone_from in CircMgr config updater. | Nick Mathewson | 2024-04-22 | 1 | -1/+3 | |
| | | | | | | Clippy prefers this idiom as potentially more efficient. It's not critical-path, but let's let clippy have its way. | |||||
| * | tor-guardmgr: Store whether we're running an onion svc (fmt). | Gabriela Moldovan | 2024-04-11 | 1 | -1/+6 | |
| | | ||||||
| * | tor-guardmgr: Store whether we're running an onion svc. | Gabriela Moldovan | 2024-04-11 | 2 | -2/+10 | |
| | | | | | | | The `VanguardMgr` needs to know whether arti is running as an onion service or not, in order to figure out which of the `vanguards_enabled` and `vanguards_hs_service` modes to use. | |||||
| * | tor-circmgr: Call VanguardMgr::launch_background_tasks. | Gabriela Moldovan | 2024-04-05 | 2 | -1/+10 | |
| | | ||||||
| * | tor-guardmgr: Pass an rng to select_vanguard. | Gabriela Moldovan | 2024-04-05 | 1 | -2/+2 | |
| | | | | | | This function will need to randomly select a vanguard, so it needs an `Rng`. | |||||
| * | tor-guardmgr: Give VanguardMgr a handle to the runtime (fmt). | Gabriela Moldovan | 2024-04-05 | 2 | -3/+14 | |
| | | ||||||
 |
index : mirrors/arti.git | |
| mirror of https://gitlab.torproject.org/tpo/core/arti |
| aboutsummaryrefslogtreecommitdiff |