summaryrefslogtreecommitdiff
path: root/crates/tor-circmgr/src
Commit message (Collapse)AuthorAgeFilesLines
* Remove "doc_auto_cfg" incantation from all crates.Nick Mathewson2025-09-291-1/+1
| | | | This feature has been removed from nightly, in favor of doc_cfg.
* opentelemetry: Add some instrument macros.Wesley Aptekar-Cassels2025-09-241-0/+2
| | | | | I've added these in places that are useful for the debugging that I've been doing.
* Merge branch 'expire-halfstream-cbt' into 'main'gabi-2502025-09-242-12/+38
|\ | | | | | | | | | | | | proto: Remove half-streams when they expire. Closes #264 See merge request tpo/core/arti!3267
| * proto: Use the circuit build timeout instead of the abandon timeout.Gabriela Moldovan2025-09-221-2/+2
| | | | | | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3267#note_3259820
| * circmgr: Pass the timeout estimator to circuit constructor (fmt).Gabriela Moldovan2025-09-161-8/+13
| |
| * circmgr: Pass the timeout estimator to circuit constructor.Gabriela Moldovan2025-09-161-7/+16
| | | | | | | | | | This enables us to read the CBT estimates from the circuit reactor (we need these to compute the half-stream timeouts for #264).
| * circmgr: Implement TimeoutEstimator for Estimator.Gabriela Moldovan2025-09-161-0/+12
| | | | | | | | | | This will enable us to pass the timeout estimator to the circuit reactor in tor-proto.
* | circmgr: Replace BoundedVecDeque with a much smaller wrapperNick Mathewson2025-09-171-10/+79
| | | | | | | | Closes #2174. See that ticket for rationale.
* | tor-proto: use `CellCount` in `FlowCtrlParameters`Steven Engler2025-09-161-4/+4
|/
* Merge branch 'xon-xoff-checker' into 'main'David Goulet2025-09-151-1/+9
|\ | | | | | | | | tor-proto,tor-netdir: add flow control consensus parameters See merge request tpo/core/arti!3249
| * tor-proto: add `FlowCtrlParameters` to `CircParameters` and `HopSettings`Steven Engler2025-09-111-1/+9
| |
* | Move `FallbackDir` into `tor-dircommon`Clara Engler2025-09-113-3/+3
|/
* Merge branch 'the-bell-tolls-for-once_cell' into 'main'wesleyac2025-09-031-7/+1
|\ | | | | | | | | various crates: Updated MSRV TODOs for `once_cell` removal See merge request tpo/core/arti!2953
| * tor-circmgr: Modified MSRV TODOs for `once_cell` removalhashcatHitman2025-08-201-7/+1
| | | | | | | | | | | | | | | | | | - Shortened the TODO added in e9ef7bea96c2860fa81d03e8d8da2605d0661425 in the style of [this maintainer request] for consistency. [this maintainer request]: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2953#note_3197719 Signed-off-by: hashcatHitman <[email protected]>
* | tor-circmgr: Removed dependency on `static_assertions`hashcatHitman2025-09-011-3/+2
| | | | | | | | | | | | | | | | Replaced use of [`static_assertions::const_assert`] with the newly available "assert in const" pattern. This completely removes the dependency on `static_assertions` for `tor-circmgr`. Signed-off-by: hashcatHitman <[email protected]>
* | proto: Add a circuit module shared between client and relay impls.Gabriela Moldovan2025-08-287-8/+13
| | | | | | | | | | | | | | This is just code motion (I suggest reviewing with `--color-moved`). This also moves the implementation-agnostic parts from `tor_proto::client::circuit` to a new `tor_proto::circuit` module.
* | Merge branch 'circmgr-timeout-estimator-logging' into 'main'Nick Mathewson2025-08-271-0/+2
|\ \ | |/ |/| | | | | tor-circmgr: Add more logging about timeout estimation. See merge request tpo/core/arti!3152
| * tor-circmgr: Make connection failure log at debug level.Wesley Aptekar-Cassels2025-08-131-1/+1
| |
| * tor-circmgr: Add more logging about timeout estimation.Wesley Aptekar-Cassels2025-08-121-0/+2
| | | | | | | | | | | | We're seeing the logic that resets the timeouts when 18/20 connections fail not triggering when we're expecting it to, this logging may help figure out what's going on there.
* | chanmgr: Add KeyMgr to channel builderDavid Goulet2025-08-202-0/+2
| | | | | | | | | | | | | | This is so a relay can build authenticated channels. Several keys/cert are required for this that are within the key manager. Signed-off-by: David Goulet <[email protected]>
* | proto: Move the `stream` module under `client` (fmt).Gabriela Moldovan2025-08-181-1/+3
| |
* | proto: Move the `stream` module under `client` (breaking).Gabriela Moldovan2025-08-181-3/+3
|/ | | | | | | | | | | | The `stream` module is client-specific, for the most part, so I am moving it under `client`. Later on, we will factor out the parts that can be shared with the relay implementation. Note: this is a breaking change as the deleted `stream` module was `pub`. We could've kept the module and reexported from it the public types from `tor_proto::client::stream`, but I think it's better to have this `client` namespacing, because it makes the separation between the client and relay parts clearer.
* circmgr: Move the body of get_channel_to_guard into its only caller.Nick Mathewson2025-08-071-33/+23
|
* circmgr: Don't count channel negotiation towards circuit built time.Nick Mathewson2025-08-072-53/+77
| | | | | | | | | | This is important, since some circuits require us to negotiate a new channel, and some don't: by adding this variability, we can easily learn a timeout based on pre-existing channels to our guards, but then later time out if it takes a while to open a TLS connection. This is a possible solution to part of #2079, a bug where we "learn" a circuit timeout that is too low for us to satisfy.
* cirmgr: extract code that opens a channel.Nick Mathewson2025-08-071-14/+26
|
* Fix warnings and errors from edition 2024.Nick Mathewson2025-08-072-8/+9
| | | | | | | | | | The two main causes of errors were: - Since some of the lifetime rules have changed, we no longer need to do as many "bind a variable and immediately return it" patterns, and so clippy now warns about them. - We needed to adjust the explicit captures (`use<...>`) in a couple of our RPIT instances.
* Switch Cargo.toml files to edition 2024.Nick Mathewson2025-08-0721-85/+90
| | | | | | | | | | | | | | First, run ``` git grep -l "^edition =" | xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;' ``` Second, manually verify that all Cargo.toml files have changed, and nothing else has changed. Third, run cargo fmt again.
* Update code for Edition 2024Nick Mathewson2025-08-073-4/+3
| | | | | | | | | | | | | | | | | | 1. Run cargo fix --edition 2. Selectively revert the "if let"->"match" changes. These changes are meant to protect us from the lifetime changes for "if let" bindings in Rust 2024. But we're not actually relying on the old lifetime rules anywhere, and the match syntax here is quite ugly. 3. Automatically revert `$pat:expr_2021` to `$pat:expr`. (We don't actually want to restrict the expression syntax that our macros accept). Done with `git grep -l expr_2021 | xargs perl -i -pe 's/expr_2021/expr/g;'` 4. Run cargo fmt.
* Merge branch 'use-cc' into 'main'Nick Mathewson2025-08-051-39/+24
|\ | | | | | | | | Use congestion control when "flowctl-cc" is enabled See merge request tpo/core/arti!3118
| * tor-proto: use congestion control when "flowctl-cc" is enabledSteven Engler2025-08-041-39/+24
| |
* | circmgr: Feature gate multi path tunnel with conflux flagDavid Goulet2025-08-052-5/+13
| | | | | | | | Signed-off-by: David Goulet <[email protected]>
* | Revert "circmgr: Feature-gate all the onion service tunnel types."Gabriela Moldovan2025-08-052-22/+2
| | | | | | | | This reverts commit 9dca6010d17e2a4b9deee34c9bb66e523a6ac834.
* | circmgr: Feature-gate all the onion service tunnel types.Gabriela Moldovan2025-08-052-2/+22
| | | | | | | | | | We shouldn't be exposing these unless `hs-service`/`hs-client` is enabled.
* | Do not fully-qualify Sync.Gabriela Moldovan2025-08-053-15/+15
| | | | | | | | It's necessary and more verbose (and it's rather uncommon).
* | proto: Fix infinite recursion in ClientTunnel::extend().Gabriela Moldovan2025-08-051-2/+2
| | | | | | | | | | `AbstractTunnel::extend()` was calling itself endlessly because there was no `ClientTunnel::extend()` function to call.
* | conflux: Adjust docs and fix doc links.Gabriela Moldovan2025-08-053-15/+17
| |
* | proto: abolish path_ref() in favor of all_paths().Gabriela Moldovan2025-08-055-32/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | Until now, we've been using `ClientCirc::path_ref()` to get the *only* path of a circuit. Now that `ClientCirc` is a handle to a tunnel reactor (which may or may not be multi-path), we need to decide for each call site of `path_ref()`, if we actually want *all* paths in the tunnel, or if we expect the tunnel to be single-path and thus want the *only* path in the tunnel. I've added two new APIs to address this: `all_paths()`, for getting all the paths in the tunnel, and `single_path()` for getting the only path in the tunnel, or an error if the tunnel is single-path.
* | circmgr: Feature-gate ServiceOnionServiceIntroTunnel to fix compile errors.Gabriela Moldovan2025-08-051-0/+1
| |
* | circmgr: Feature-gate send_raw_msg.Gabriela Moldovan2025-08-051-0/+1
| |
* | circmgr: Gate tor_proto::handshake usage behind hs-common.Gabriela Moldovan2025-08-051-1/+6
| |
* | proto, circmgr: Fix feature-gating.Gabriela Moldovan2025-08-051-1/+2
| |
* | circmgr: Fully-qualify types in macro.Gabriela Moldovan2025-08-051-4/+2
| |
* | circmgr: Add back cognitive_complexity allows.Gabriela Moldovan2025-08-052-0/+2
| | | | | | | | | | These were removed somewhere along the way (which is now causing the clippy checks to fail).
* | circmgr: Fix unit testsDavid Goulet2025-08-052-15/+15
| | | | | | | | Signed-off-by: David Goulet <[email protected]>
* | tunnel: Implement start_conversation() for all tunnel typesDavid Goulet2025-08-051-9/+15
| | | | | | | | | | | | | | | | | | | | The BaseTunnel now has a start_conversation() which takes a TargetHop meaning it can be used with a multi path tunnel. The Conversation object has been moved into the tunnel namespace out of the circuit one. Signed-off-by: David Goulet <[email protected]>
* | hs: Use the new Tunnel interface for onion serviceDavid Goulet2025-08-054-12/+90
| |
* | circmgr: Return more type specific tunnelDavid Goulet2025-08-052-8/+12
| | | | | | | | | | | | | | | | | | | | This is the first step towards making the circmgr return high level tunnel types (wrappers around ClientTunnel). Future commits will then modify each subsystems to use those specific types. They are split in order to reduce complexity. Signed-off-by: David Goulet <[email protected]>
* | tunnel: Implement Buildable for ClientTunnelDavid Goulet2025-08-055-84/+88
| | | | | | | | | | | | | | | | | | | | | | | | In order to pull this off, the Arc requirement needs to go away because the Arc<ClientCirc> is now within the ClientTunnel. This commit also has a rename of the CircuitBuilder to TunnelBuilder in order to reflect the change that it now builds a ClientTunnel. There is a slight rename in tor-proto as well just for accuracy. Signed-off-by: David Goulet <[email protected]>
* | proto: Change PendingClientCirc to yield back a ClientTunnelDavid Goulet2025-08-051-3/+3
| | | | | | | | | | | | And rename it in the process to "PendingClientTunnel". Signed-off-by: David Goulet <[email protected]>
* | circmgr: Major rename for the new Tunnel namespaceDavid Goulet2025-08-058-625/+635
| | | | | | | | | | | | | | | | | | | | | | | | The CircMgr will no longer yield circuits but tunnels (src/tunnel.rs). This is a first step to rename most circuit related objects to use "tunnel" instead. Some "circuit" names have been kept for more precise definitions. No behavior changes. Signed-off-by: David Goulet <[email protected]>