| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
| |
In !948 we renamed a couple of accessor functions, which is a
breaking change in `tor-cell`'s API.
In retrospect, perhaps we should have deprecated the old names and
added the new ones, so we wouldn't have to break the API. (This is
the only API break AFAICT since 1.1.0.)
|
| |
|
|
|
|
| |
These crates had API or behavior changes that may affect downstream
crates. Fortunately, they're all version 0.x, and don't need minor
bumps for this.
|
| |
|
|
|
|
|
| |
These changes influence behavior, but not effect compatibility.
(If I messed up, and any crate except for `arti` has non-breaking
API changes, that's still fine, since they are all version
0.x.)
|
| |
|
|
| |
It was erroneously created in the wrong place.
|
| |
|
|
|
| |
This panics on error, and we're fine with a panic on misbehavior in
tests.
|
| |
|
|
|
|
|
|
| |
This warning kind of snuck up on us! (See #748) For now, let's
disable it. (I've cleaned it up in a couple of examples, since
those are meant to be more idiomatic and user-facing.)
Closes #748.
|
| |
|
|
|
| |
These are symlinks which are actually checked in. They should not be
ignored. (This caused trouble for some of my privsep tooling...)
|
| | |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| | |
Add test lint blocks to all "mod test"
See merge request tpo/core/arti!937
|
| | |
| |
| |
| |
| | |
This is precisely the result of running the rune in
maint/adhoc-add-lint-blocks.
|
| |/ |
|
| | |
|
| |
|
|
|
| |
We made this job easy this time around: by incrementing our MSRV, we
have forced ourselves to do at least a minor bump everywhere.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| | |
tor-cell: Assert data length in Data cells
See merge request tpo/core/arti!800
|
| | |
| |
| |
| |
| |
| | |
This commit adds a `debug_assert!` macro into the `new_unchecked()`
function of the Data cell. Beside this, it also fixes a misleading
comment regarding that limit.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-cell: Consistent and secure conversion to u16
See merge request tpo/core/arti!803
|
| | |/
| |
| |
| |
| |
| |
| | |
This commit improves the overflow protection of one call to
Vec::write_u16(), by replacing the cast conversion from self.sig.len()
with a call to u16::try_from(), like it is already done in the rest of
the accompanying function.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-cell: Rename for_client and for_relay
See merge request tpo/core/arti!793
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit renames the for_client and for_relay functions to
from_client and from_relay respectively, in order to indicate their
origin, as the term "for" is more likely to indicate a destination,
which is not true in that situation.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Add semver.md in tor-cell for MR#793
See merge request tpo/core/arti!798
|
| | | |/
| |/| |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
tor-cell: Fix typos in msg.rs
See merge request tpo/core/arti!802
|
| | |/ / |
|
| |/ /
| |
| |
| |
| | |
This commit adds a comment explaining composition of the magic number
"11" found in the assignment of the Data::MAXLEN constant.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-cell: Fix typos in msg.rs
See merge request tpo/core/arti!788
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | | |
tor-cell: Remove redundant match clauses
See merge request tpo/core/arti!792
|
| | |/
| |
| |
| |
| | |
This commit removes two redundant match clauses inside the
take_one_netinfo_addr function found inside msg.rs.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-cell: Make historical comments more concrete
See merge request tpo/core/arti!787
|
| | |/
| |
| |
| |
| | |
This commit extends comments that make references to historical protocol
versions of Tor, by adding the concrete protocol version numbers.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-cell: Avoid redundant pointer copy
See merge request tpo/core/arti!791
|
| | |/
| |
| |
| |
| |
| | |
This commit changes an iteration by copying a u16 (which is 2 bytes)
instead of a pointer address, which is most likely 8 bytes on most
machines.
|
| |\ \
| | |
| | |
| | |
| | | |
tor-cell: Avoid redundant allocation
See merge request tpo/core/arti!790
|
| | |/
| |
| |
| |
| |
| | |
This commit changes the way how a vector with a known sized gets
allocated, by using Vec::with_capacity() instead of Vec::new().
It will eventually avoid an allocation of more memory than required.
|
| |/
|
|
|
|
| |
This commit renames the fixed_len! macro to fixed_len_handshake!, in
order to indicate, that this macro is only suited for cells with
commands related to handshaking.
|
| | |
|
| |
|
|
|
|
|
| |
Apparently cargo fmt doesn't like these, which my perl rune didn't
delete.
This commit is precisely the result of `cargo fmt`.
|
| |
|
|
|
|
|
|
| |
The feature we want is `#[doc = include_str!("README.md")]`, which is
stable since 1.54 and our MSRV is now 1.56.
This commit is precisely the result of the following Perl rune:
perl -i~ -0777 -pe 's{(^//!(?!.*\@\@).*\n)+}{#![doc = include_str!("../README.md")]\n}m' crates/*/src/lib.rs
|
| | |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| | |
Implement Introduce2 tor cell
See merge request tpo/core/arti!736
|
| | |
| |
| |
| |
| | |
Reuse the same Introduce inner body implementation
of Introduce1.
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
As a matter of good crypto practice, we shouldn't use
short-circuiting checks to compare keys or key-like objects, since
the amount of time taken by those checks can leak information about
their inputs.
I don't think it's actually _necessary_ to use a constant-time
operation in this case, but let's establish the precedent.
This is a follow-up to !724.
|