| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
We need this pattern in a lot of places; we might as well just
define it once.
|
| |
|
|
|
| |
It looks like we renamed this macro, but didn't rename it in its
documentation.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Fixes
warning: `rand::RngExt::random_range` does not refer to a reachable function
--> /volatile/rustcargo/Rustup/Arti/arti/clippy.toml:7:5
|
7 | { path = "rand::RngExt::random_range", reason = "Prefer tor_basic_utils::RngExt::gen_range_checked to avoid uncontrolled panics, or gen_range_infallible if applicable" },
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: add `allow-invalid = true` to the entry to suppress this warning
|
| |
|
|
|
|
|
|
|
|
|
| |
When the circ-padding feature is enabled, we use maybenot, which does
not yet support rand 0.10. In the meantime, enabling this feature pulls
in rand 0.9. This is not ideal, but should be okay as a temporary
situation.
This also replaces the use of ReseedingRng (which was removed in 0.10)
with the reseeding_rng crate. This is somewhat less performant, but it
should be okay.
|
| |
|
|
|
| |
It is no longer needed since we require Rust 1.89. Nobody was using
it.
|
| |
|
|
| |
We now know when it was stabilized, so we can say when to use it.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
IoErrorExt existed to provide a workaround for Rust versions
that didn't have io::ErrorKind::NotADirectory. But NotADirectory
was stabilized in 1.83 and our MSRV is 1.89.
BinaryHeapExt existed to provide an implementation for Rust
versions that didn't have BinaryHeap::retain. But
BinaryHeap::retain was stabilized in 1.70 and our MSRV is 1.70.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Closes #2418.
Fixes TROVE-2026-005, where we would use a less cryptographically
secure (and probably less DoS resistant) hash function for these
tables if:
- We are built alongside another crate that uses `weak-table`
- That crate enables the `weak-table/ahash` feature.
- We are running on a system without hardware AES.
Severity: Low
|
| | |
|
| |
|
|
| |
Will clean this up in the following commit.
|
| |\
| |
| |
| |
| |
| |
| | |
Use ErrorSources where appropriate to walk an error stack.
Closes #2338
See merge request tpo/core/arti!3685
|
| | | |
|
| |/
|
|
|
|
|
|
|
| |
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
|
| | |
|
| |
|
|
| |
This adds the lint to all our crates.
|
| | |
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
|
|
| |
We'll be using this for x509 certificates in #2197.
We might also use it for SNI/ESNI as in !198.
|
| |
|
|
| |
This feature has been removed from nightly, in favor of doc_cfg.
|
| |\
| |
| |
| |
| | |
Fix a comment about Result::flatten
See merge request tpo/core/arti!3138
|
| | |
| |
| |
| | |
Previously this API was nightly-only; now it's in 1.89.
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| | |
|
| |
|
|
| |
See #2060.
|
| |
|
|
|
|
| |
This method has always been deprecated, so it's not a big deal to
remove. It can be replaced with the corresponding iterators's `Default`
implementation.
|
| |
|
|
|
| |
- Part of a series of commits aimed at replacing all MSRV-related TODOs with a
standardized format, which should be easier to find when the MSRV is bumped.
|
| |
|
|
| |
I also added an additional non-doc TODO comment.
|
| |
|
|
| |
- `Rng::gen_range()` has been renamed to `Rng::random_range()`
|
| |
|
|
| |
- The rand::distributions module has been renamed to rand::distr
|
| |
|
|
| |
- `rand::thread_rng()` has been deprecated and renamed to `rand::rng()`
|
| |
|
|
|
| |
This is partly for consistency, and partly to facilitate
a global search-and-replace.
|
| |
|
|
|
|
| |
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
|
| |
|
|
|
|
|
|
| |
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.
|
| |
|
|
|
| |
This is not a memory safety requirement. We don't need `unsafe` here,
so we shoudln't have it.
|
| |
|
|
|
| |
This is based off of the `n_key_set` macro, but lets you store multiple
items per key.
|
| | |
|
| | |
|
| |
|
|
| |
This finally makes this type suitable for parsing in config files.
|
| |
|
|
| |
Display can now choose appropriate units.
|
| | |
|
| | |
|
| |
|
|
| |
The serde ones are going to need to be conditional.
|
| |
|
|
| |
Code motion of byte_qty.rs, and minimal necessary supporting changes.
|
| |
|
|
| |
This commit is automatically generated.
|
| |
|
|
|
|
| |
The old code produced a warning from clippy nightly; we may as well
update to use the new associated consts. (They've been there since
Rust 1.4x.)
|
| | |
|
| | |
|
| | |
|
| | |
|
