| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
| |
These are warnings that we've decided it's okay to suppress elsewhere.
|
| | |
|
| |
|
|
| |
I think this is worse code, but it's not *significantly* worse.
|
| |
|
|
| |
I intend to reintroduce this in its own MR.
|
| | |
|
| |
|
|
| |
So we can change unwrap to expect, which makes this too long to repeat.
|
| |
|
|
| |
Apropos review.
|
| |
|
|
|
|
| |
When I added these tests, they didn't find any bugs in my own
implementation, but I did find a bug in futures::future::unfold.
See the in-code comment.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a general-purpose implementation of the ad-hoc approach
currently taken in (eg) crates/tor-proto/src/channel/reactor.rs,
with an API intended to defned against the more obvious mistakes.
This allows us to separate the two concerns: the channel reactor can
focus on handling channel cells and control messages and is over 2.5x
shorter.
The complexity of the manual sink implementation, and the machinery
needed to avoid having to suspend while holding an item, are dealt
with separately. That separate implemenation now has proper
documentation. (Tests are in the nest commit to avoid this one being
even more unwieldy.)
We use `extend` to define this as an extension trait. A competitor is
`ext` but in my personal projects I have found `extend` slightly
better.
|
| |
|
|
|
| |
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/471#note_2798026
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Previously the code would do stuff like
```
schedule = RetrySchedule::new(INITIAL_DELAY);
```
which is needlessly verbose, since the schedule already keeps track
of its initial delay.
|
| |
|
|
| |
Noticed this while reviewing !426
|
| | |
|
| |
|
|
| |
Instead, check initial_delay in dirmgr directly.
|
| |
|
|
|
| |
It's no longer about downloads; it's about whatever you need to
retry.
|
| |
|
|
|
| |
This (almost) a pure code-movement commit: it also makes one public
function private in order to suppress a warning.
|
| |
|
|
|
|
| |
We have upstreamed this code.
This reverts commit 6193c9d9742d1d19a45a0ee1c383858201304912.
|
| |
|
|
|
| |
This will be used to allow our config *builder* structs to be
Deserialize.
|
| |
|
|
|
|
|
|
|
|
| |
The doc include rune does not work with our MSRV; it needs 1.54.
The alternative would be some kind of cfg() but that would
- not provide the crate-level doc on Rust 1.53
- involve the use of cfg_attr
Instead, just do it the old way.
|
| |
|
|
| |
Now the diff from the merge base does not contain any hits for ^\+.*bytes
|
| |
|
|
|
|
|
| |
Code motion and the minimal mechanical changes.
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/375#note_2783078
|
|
|
Empty crate right now
|
