| Commit message (Collapse) | Author | Age | Files | Lines |
| |\
| |
| |
| |
| | |
tor-basic-utils: Improve docs for iter_join
See merge request tpo/core/arti!4213
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| |
|
|
| |
Removed unnecessary lint
|
| |
|
|
| |
We will make use of it in the next commit.
|
| |\
| |
| |
| |
| | |
Fix string_slice exceptions outside of netdoc
See merge request tpo/core/arti!4092
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
I want to call this in one of tor-netdoc's parse2 derives, which *do*
support generics.
|
| | |
| |
| |
| |
| | |
If we move this let into the item impl, it will have access to the
generics we're about to add to the `impl $rule`.
|
| | |
| |
| |
| |
| |
| |
| | |
Previously we were relying on the macro_rules pattern being in the
rustdoc. But it's about to get more complex.
Document it manually.
|
| | |
| |
| |
| |
| | |
Usually Rust doesn't put a space after `:` in trait bounds. But it
does when calling a macro with { } syntax.
|
| | |
| |
| |
| |
| | |
This bit of the doc contains both succeeding and failing examples,
each marked with an appropriate comment.
|
| |/
|
|
|
|
|
| |
I want this in tor-netdoc (which doesn't use tor-config and probably
shouldn't).
Almost entirely code motion. Review with --color-moved.
|
| |
|
|
|
|
|
|
| |
This commit adds #[allow(clippy::string_slice)] to all functions in the
code where string slices are used, alongside a TODO comment.
We do this add the function header to have it consistent, as things like
expression based allow's are still experimental.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| |
|
|
| |
Signed-off-by: David Goulet <[email protected]>
|
| |
|
|
|
| |
We need this pattern in a lot of places; we might as well just
define it once.
|
| |
|
|
|
| |
It looks like we renamed this macro, but didn't rename it in its
documentation.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Fixes
warning: `rand::RngExt::random_range` does not refer to a reachable function
--> /volatile/rustcargo/Rustup/Arti/arti/clippy.toml:7:5
|
7 | { path = "rand::RngExt::random_range", reason = "Prefer tor_basic_utils::RngExt::gen_range_checked to avoid uncontrolled panics, or gen_range_infallible if applicable" },
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: add `allow-invalid = true` to the entry to suppress this warning
|
| |
|
|
|
|
|
|
|
|
|
| |
When the circ-padding feature is enabled, we use maybenot, which does
not yet support rand 0.10. In the meantime, enabling this feature pulls
in rand 0.9. This is not ideal, but should be okay as a temporary
situation.
This also replaces the use of ReseedingRng (which was removed in 0.10)
with the reseeding_rng crate. This is somewhat less performant, but it
should be okay.
|
| |
|
|
|
| |
It is no longer needed since we require Rust 1.89. Nobody was using
it.
|
| |
|
|
| |
We now know when it was stabilized, so we can say when to use it.
|
| |
|
|
|
|
|
|
|
|
| |
IoErrorExt existed to provide a workaround for Rust versions
that didn't have io::ErrorKind::NotADirectory. But NotADirectory
was stabilized in 1.83 and our MSRV is 1.89.
BinaryHeapExt existed to provide an implementation for Rust
versions that didn't have BinaryHeap::retain. But
BinaryHeap::retain was stabilized in 1.70 and our MSRV is 1.70.
|
| | |
|
| |
|
|
| |
Will clean this up in the following commit.
|
| |
|
|
|
|
|
|
|
| |
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
|
| | |
|
| |
|
|
| |
This adds the lint to all our crates.
|
| | |
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
|
|
| |
We'll be using this for x509 certificates in #2197.
We might also use it for SNI/ESNI as in !198.
|
| |
|
|
| |
This feature has been removed from nightly, in favor of doc_cfg.
|
| |
|
|
| |
Previously this API was nightly-only; now it's in 1.89.
|
| | |
|
| |
|
|
| |
See #2060.
|
| |
|
|
|
| |
- Part of a series of commits aimed at replacing all MSRV-related TODOs with a
standardized format, which should be easier to find when the MSRV is bumped.
|
| |
|
|
| |
I also added an additional non-doc TODO comment.
|
| |
|
|
| |
- `Rng::gen_range()` has been renamed to `Rng::random_range()`
|
| |
|
|
| |
- The rand::distributions module has been renamed to rand::distr
|
| |
|
|
| |
- `rand::thread_rng()` has been deprecated and renamed to `rand::rng()`
|
| |
|
|
|
| |
This is partly for consistency, and partly to facilitate
a global search-and-replace.
|
| |
|
|
|
|
| |
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
|
| |
|
|
|
|
|
|
| |
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.
|
| |
|
|
|
| |
This is based off of the `n_key_set` macro, but lets you store multiple
items per key.
|
| |
|
|
| |
Code motion of byte_qty.rs, and minimal necessary supporting changes.
|
| |
|
|
| |
This commit is automatically generated.
|