summaryrefslogtreecommitdiff
path: root/crates/safelog/src
Commit message (Collapse)AuthorAgeFilesLines
* safelog: impl From<T> for Redacted<T>Ian Jackson2023-03-231-0/+1
| | | | I think this is uncontroversial; we already have it for Sensitive.
* Allow clippy::unchecked_duration_subtraction in testsNick Mathewson2023-01-273-0/+3
| | | | | This panics on error, and we're fine with a panic on misbehavior in tests.
* Disable clippy::unlinlined-format-argsNick Mathewson2023-01-271-0/+1
| | | | | | | | This warning kind of snuck up on us! (See #748) For now, let's disable it. (I've cleaned it up in a couple of examples, since those are meant to be more idiomatic and user-facing.) Closes #748.
* Merge branch 'test-lints' into 'main'eta2023-01-063-0/+24
|\ | | | | | | | | Add test lint blocks to all "mod test" See merge request tpo/core/arti!937
| * test lint blocks: Add many many automaticallyIan Jackson2022-12-123-0/+24
| | | | | | | | | | This is precisely the result of running the rune in maint/adhoc-add-lint-blocks.
* | Rename Sensitive::into_inner() from ::unwrap()Ian Jackson2022-12-121-5/+19
|/ | | | | | | | | | By analogy with similar methods on Mutex, Cell, BufReader, etc. etc. Discussed here https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/890#note_2856885 Make it a method, as per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/928
* safelog: tests for accessors.Nick Mathewson2022-12-061-0/+2
|
* safelog: tests for BoxSensitive.Nick Mathewson2022-12-061-0/+17
|
* safelog: more tests for Redacted.Nick Mathewson2022-12-062-3/+50
|
* safelog: Apply #[serial] to test_redacted()Nick Mathewson2022-11-301-0/+1
| | | | Closes #675.
* Fix a logic error in Redacted.Nick Mathewson2022-11-301-4/+13
| | | | | | | Previously it was redacting exactly when safelogging was _disabled_, which obviously isn't correct. Fixes #671. Regression test included.
* safelog: Make MaybeRedacted<T> opaque.Nick Mathewson2022-11-281-22/+8
|
* Add a default debug_redacted impl to save space.Nick Mathewson2022-11-282-29/+3
|
* safelog: Add a MaybeRedacted wrapper too.Nick Mathewson2022-11-281-0/+38
| | | | | This is super helpful for cases where we want to write two nearly identical implementations to format a type.
* safelog: implement Redactable for network addr types.Nick Mathewson2022-11-282-0/+73
|
* safelog: Define a "Redactable" traitNick Mathewson2022-11-281-0/+91
| | | | | | A "redactable" object is one that can be _partially_ scrubbed in sensitive contexts. This can be very helpful for UX, but is not risk-free: see comments.
* safelog: Provide BoxSensitiveIan Jackson2022-11-231-0/+47
|
* safelog: Remove type argument from `impl_display_traits`Ian Jackson2022-11-231-3/+3
| | | | | | We're going to have this same macro implement the same traits for a second type. And its function is specific to `Sensitive`, so have it know that.
* safelog: Provide some more accessorsIan Jackson2022-11-231-0/+15
| | | | | We're about to use `.as_inner()` in a few places, and `.as_ref()` (by analogy with `Option`) seems obviously necessary.
* Run add_warnings.Nick Mathewson2022-11-031-0/+1
|
* cargo fmt to remove blank linesIan Jackson2022-10-121-1/+0
| | | | | | | Apparently cargo fmt doesn't like these, which my perl rune didn't delete. This commit is precisely the result of `cargo fmt`.
* Replace all README copies in src/lib.rs with includesIan Jackson2022-10-121-69/+1
| | | | | | | | The feature we want is `#[doc = include_str!("README.md")]`, which is stable since 1.54 and our MSRV is now 1.56. This commit is precisely the result of the following Perl rune: perl -i~ -0777 -pe 's{(^//!(?!.*\@\@).*\n)+}{#![doc = include_str!("../README.md")]\n}m' crates/*/src/lib.rs
* enable doc_auto_cfg feature on every crate when documenting for docs.rstrinity-1686a2022-08-241-0/+1
|
* Run maint/add_warning crates/*/src/{lib,main}.rsIan Jackson2022-06-231-0/+3
| | | | Update all lint blocks
* Style fixes to safelog errors.Nick Mathewson2022-06-221-3/+3
|
* lints: Add let_unit_value allow to all cratesIan Jackson2022-05-311-0/+1
| | | | | From running add_warning, with manual picking of the right hunks/lines.
* lints: Add lint block delimiters to every crateIan Jackson2022-05-311-0/+2
| | | | | | This was the result of: maint/add_warning crates/*/src/{lib,main}.rs and then manually curating the results.
* Punctuation fix.eta2022-05-061-1/+1
|
* Implement a safe-logging facility.Nick Mathewson2022-05-063-0/+629
This is a rough first-cut of an API that I think might help us with keeping limited categories of sensitive information out of our logs. I'll refine it based on experiences with using it.