| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | fix compiling fs-misstrust on tvOS | yaucp | 2025-03-26 | 3 | -11/+27 |
| | | |||||
| * | fix: fix typos | Dimitris Apostolou | 2025-01-30 | 1 | -1/+1 |
| | | |||||
| * | fs-mistrust: document that follow_final_links is not insecure | Nick Mathewson | 2025-01-28 | 1 | -0/+4 |
| | | | | | | Since it makes an exception, we need to be clear about the exceptions that it _doesn't_ make. | ||||
| * | fs-mistrust: link to documentation about "obeying constraints" | Nick Mathewson | 2025-01-28 | 1 | -5/+5 |
| | | | | | | | Since "obeying the constraints of a FileAccess" is a term of art, this commit introduces links from the places where it is used to the place where it is defined. | ||||
| * | fs-mistrust: Fix test compilation on windows. | Nick Mathewson | 2025-01-16 | 1 | -1/+2 |
| | | | | | | | | | | `std::os::unix::fs::MetadataExt` was indeed the right trait to import, but it doesn't exist on non-unix platforms. This is another bugfix on !2707. It should retain the fix of !2717. I've confirmed that it builds on Windows and passes tests on Linux and Mac. | ||||
| * | Fix: Tests fails to run on macos | hhamud | 2025-01-16 | 1 | -5/+5 |
| | | |||||
| * | file_access: Refactor APIs to consume self. | Nick Mathewson | 2025-01-14 | 1 | -7/+16 |
| | | | | | | This approach makes it even less likely for people to store a FileAccess for repeated use. | ||||
| * | file_access: Make link-following behavior explicitly controlled. | Nick Mathewson | 2025-01-14 | 1 | -8/+38 |
| | | |||||
| * | Documentation fixes from Gabi | Nick Mathewson | 2025-01-14 | 1 | -5/+3 |
| | | |||||
| * | fs-mistrust: Try more to explain what FileAccess is for. | Nick Mathewson | 2025-01-14 | 1 | -3/+7 |
| | | |||||
| * | fs-mistrust: Follow symlinks when using file-access outside a CheckedDir. | Nick Mathewson | 2025-01-14 | 1 | -9/+98 |
| | | | | | | | When we're not bound to a CheckedDir, it doesn't make sense to forbid following symlinks, so long as their targets are also sensible. | ||||
| * | fs-mistrust: Add FileAccess for Verifier (and Mistrust). | Nick Mathewson | 2025-01-14 | 2 | -9/+42 |
| | | |||||
| * | fs-mistrust: Have Verifier check methods take self by reference. | Nick Mathewson | 2025-01-14 | 1 | -2/+2 |
| | | | | | There is no reason for these to consume self. | ||||
| * | fs-mistrust: Add ability to create files with chosen mode. | Nick Mathewson | 2025-01-14 | 1 | -10/+117 |
| | | |||||
| * | fs-mistrust: Clean up documentation. | Nick Mathewson | 2025-01-14 | 1 | -15/+13 |
| | | |||||
| * | fs-mistrust: Move file access methods on CheckedDir to FileAccess. | Nick Mathewson | 2025-01-14 | 2 | -69/+168 |
| | | | | | | These are the methods which we'd like to give new options in #1746; we can move other methods later if we want to. | ||||
| * | fs-mistrust: Define a (stub) FileAccess type. | Nick Mathewson | 2025-01-14 | 3 | -0/+38 |
| | | | | | | We're going to move functionality and configuration functions here to implement #1746. | ||||
| * | fs-mistrust::CheckedDir: Refactor some common code. | Nick Mathewson | 2025-01-14 | 1 | -22/+32 |
| | | |||||
| * | fs-mistrust: Add test for (not) opening symlink from CheckedDir. | Nick Mathewson | 2025-01-14 | 1 | -1/+10 |
| | | |||||
| * | fs-mistrust: clarify doc for a private function. | Nick Mathewson | 2025-01-14 | 1 | -0/+2 |
| | | |||||
| * | clippy: deny `mod_module_files` | Steven Engler | 2025-01-06 | 1 | -0/+1 |
| | | | | | | | Denies 'mod.rs' files for consistency. https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files | ||||
| * | fs-mistrust: trim whitespace in env var values | Steven Engler | 2024-12-18 | 2 | -4/+8 |
| | | |||||
| * | fs-mistrust: commit to stable env var handling | Steven Engler | 2024-12-18 | 2 | -4/+43 |
| | | | | | | | | | Since these environment variables become part of the stable API for applications that use fs-mistrust, we should be explicit about how these environment variables are interpreted so that applications can show the values in their documentation or help text, and so that we don't accidentally change the behaviour and break applications. | ||||
| * | fs-mistrust: (docs) fix incomplete list of env variable values | Steven Engler | 2024-12-18 | 1 | -2/+2 |
| | | |||||
| * | Resolve clippy::empty_line_after_doc_comments warnings. | Nick Mathewson | 2024-12-03 | 1 | -1/+0 |
| | | | | | These are new in Rust 1.83. | ||||
| * | add_warnings, *: Allow clippy::needless_lifetimes | Nick Mathewson | 2024-12-03 | 1 | -0/+1 |
| | | | | | | | | | In 1.83, this warning triggers on many of our crates. We're thinking of fixing them all, but for now, we're going to disable the warning. This is part of #1765. | ||||
| * | fs-mistrust: Remove outdated thiserror syntax | Clara Engler | 2024-11-12 | 1 | -1/+1 |
| | | | | | | | This commit removes an outdated syntax in a `thiserror` macro which will be removed in `thiserror` version 2. The change this commit makes is backwards compatible in itself. | ||||
| * | Replace _ => panic!() elsewhere | Ian Jackson | 2024-10-15 | 1 | -1/+1 |
| | | |||||
| * | Fix a couple of lifetime warnings from nightly. | Nick Mathewson | 2024-10-01 | 1 | -1/+1 |
| | | | | | | | | | | Nightly rustdoc, under some circumstances, issues a warning when you have an elided lifetime that matches a lifetime with a name. (It would prefer that you name the lifetime explicitly.) This does not change the actual lifetime of anything; it only makes some formerly elided lifetimes explicit. | ||||
| * | fs-mistrust: Make fake PathExt return impl Display | Ian Jackson | 2024-08-19 | 1 | -3/+4 |
| | | | | | Otherwise it doesn't compile when actually used. | ||||
| * | fs-mistrust: Make a comment into a doc | Ian Jackson | 2024-08-19 | 1 | -2/+2 |
| | | | | | Placates clippy. | ||||
| * | fs-mistrust: Decorate some items with missing walkdir cfg | Ian Jackson | 2024-08-19 | 2 | -1/+5 |
| | | |||||
| * | fs-mistrust: Make CheckedDir::metadata() return an error if path is symlink. | Gabriela Moldovan | 2024-08-12 | 1 | -2/+45 |
| | | |||||
| * | fs-mistrust: Avoid opening the file in CheckedDir::metadata(). | Gabriela Moldovan | 2024-08-08 | 1 | -5/+19 |
| | | | | | Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2291#note_3057232 | ||||
| * | fs-mistrust: Add a TODO about refactoring CheckedDir::metadata(). | Gabriela Moldovan | 2024-08-08 | 1 | -0/+1 |
| | | |||||
| * | fs-mistrust: Note that metadata() can return Error::NotFound. | Gabriela Moldovan | 2024-08-08 | 1 | -0/+2 |
| | | |||||
| * | fs-mistrust: Apply deferred cargo fmt. | Gabriela Moldovan | 2024-08-08 | 1 | -1/+4 |
| | | |||||
| * | fs-mistrust: Add a CheckedDir::metadata function. | Gabriela Moldovan | 2024-08-08 | 1 | -1/+28 |
| | | |||||
| * | fs-mistrust: Use Path::try_exists() instead of Path::exists(). | Gabriela Moldovan | 2024-07-30 | 1 | -2/+2 |
| | | |||||
| * | fs-mistrust: Explain that Error might not be a permissions error | Ian Jackson | 2024-07-10 | 1 | -0/+7 |
| | | |||||
| * | fs-mistrust: Fix a formatting botch | Ian Jackson | 2024-07-10 | 1 | -2/+3 |
| | | | | | rustfmt didn't want to fix this, for some reason. | ||||
| * | Fix a footnote reference that Nightly complains about | Ian Jackson | 2024-07-08 | 1 | -1/+1 |
| | | |||||
| * | Re-run maint/add_warning. | Nick Mathewson | 2024-05-06 | 1 | -2/+2 |
| | | | | | This commit is automatically generated. | ||||
| * | Run maint/add_warning. | Nick Mathewson | 2024-03-13 | 8 | -0/+8 |
| | | |||||
| * | Fix typos in doc comments | Tobias Stoeckmann | 2024-03-06 | 2 | -2/+2 |
| | | |||||
| * | Fix typos in comments | Tobias Stoeckmann | 2024-03-06 | 1 | -1/+1 |
| | | |||||
| * | fs-mistrust: Introduce a fn display_lossy | Ian Jackson | 2024-03-05 | 1 | -2/+9 |
| | | | | | | We're going to tell clippy to forbid Path::display. But we can't have the PathExt from tor-basic-utils, here. | ||||
| * | deny clippy::unchecked_duration_subtraction | trinity-1686a | 2024-02-29 | 1 | -0/+1 |
| | | |||||
| * | educe: Use std's default for enums where default variant is unit | Ian Jackson | 2024-02-12 | 2 | -10/+6 |
| | | | | | | | | | | | | | | Since Rust 1.66, std's default works properly for enums, provided that the default variant is a unit. Review all uses of `#[educe(default)]` on enums and replace them with std where possible, which is most of them. In 1.66 and later, std's `#[derive(Default)]` doesn't infer any generic bounds on the derived impl, where it's an enum - since the unit variant can always be constructed. So this change doesn't add any generic bounds and is not API-visible. | ||||
| * | fs_mistrust: Provide CheckedDir::make_secure_dir | Ian Jackson | 2024-01-29 | 1 | -0/+18 |
| | | | | | | | state_dir wants this, to descend into subdirectories. I think the implementation could be improved - see the TODO. | ||||
