| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
| |
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The access_symlink() test fails when using musl libc, which for ELOOP
uses the string: [1]
> "Symbolic link loop"
libc errors should be matched against the standardized error names
rather than the libc error messages.
This behaviour has been recognized by the maintiner of the Alpine Linux
Arti port who had to delete this test to have it build against musl.[2]
[1] https://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n52
[2] https://gitlab.alpinelinux.org/alpine/aports/-/blob/3.23-stable/community/arti/disable-access_symlink-test.patch
|
| |
|
|
| |
Run maint/add_warning
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
|
| |
|
|
|
|
|
| |
The `IoError::other` function is an easier way to say
`IoError::new(IoErrorKind::Other, ...)`. It's been around since
1.74, but clippy started warning about the more verbose version in
1.87.
|
| |
|
|
|
| |
These are the methods which we'd like to give new options in #1746;
we can move other methods later if we want to.
|
| |
|
|
|
| |
We're going to move functionality and configuration functions here
to implement #1746.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2291#note_3057232
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
state_dir wants this, to descend into subdirectories.
I think the implementation could be improved - see the TODO.
|
| |
|
|
|
|
|
|
|
| |
I'm not sure why this isn't public. It seems like an obviously
reasonable transformation.
If I as author of !1927 had been an external contributor, I could have
worked around the lack of .make_secure_directory() if .verifier() had
existed. So I think exposing it would be useful.
|
| |
|
|
| |
Closes #1117.
|
| | |
|
| | |
|
| |
|
|
|
| |
This panics on error, and we're fine with a panic on misbehavior in
tests.
|
| |
|
|
|
| |
This is precisely the result of running the rune in
maint/adhoc-add-lint-blocks.
|
| |
|
|
|
|
| |
These changes make sure that the errors conform to our preferred
style, and include a description of what exactly we were doing when
something went wrong.
|
| |
|
|
| |
Next commit adds another parameter to Error::BadPermission.
|
| |
|
|
|
| |
This is an approximately minimal revision to get Builder in place;
subsequent commits will clean up the API.
|
| |
|
|
|
|
|
|
|
|
|
| |
This includes:
* a CachedDir::join method.
* functions to read and write from provided filenames in a
CachedDir.
* a method to tell whether a fs-mistrust error is about bad file
permissions, or failure to inspect file permissions or some other
kind of IO problem.
|
| | |
|
| | |
|
| | |
|
|
|
The only way to get a SecureDir is by having checked a directory.
Once you have one, it encourages you to open and create files and
directories with the right permissions, and checks them for you.
|
