| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now have `trycmd` tests that cover most cases, so I am removing this
module. The reason this was introduced in the first place is in the
module level docs
```rust
//! The `assert_cmd` crate is used here instead of the preferred `trycmd` (see
//! [`README`](../README.md)) because the output of `keys list` is not deterministic across
//! different machines. The design choices of some components are workarounds for this limitation.
```
But this is no longer an issue now that the `keys list` output is
sorted.
Ideally, all tests would be written this way (we have a few more modules
in `cli_tests` that we should probably port to `trycmd` sometime).
Note: some of the tests I'm removing here don't have a `trycmd`
counterpart in `arti/tests/testcases/keys`. In my opinion, this is
perfectly fine, because the old tests were unnecessarily testing all the
possible configurations involving 1-2 keystores (one arti, and one C
Tor): it is not the responsibility of the CLI tests to cover all these
permutations (they should be tested in `tor-keymgr`).
|
