| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
and `keystores`
|
| | |
| |
| |
| | |
The function now returns `Result<Vec<InvalidKeystoreEntry<'a>>>`
|
| | |
| |
| |
| |
| |
| |
| | |
Add a check in `run_check_integrity` to verify that the `expired_entries`
collection is empty after processing all registered keystores. This should
always be true, as all expired entries are expected to be removed during
iteration. If not, it indicates a bug.
|
| | |
| |
| |
| |
| | |
Replace raw tuples with named structs to reduce type complexity and improve
code clarity and maintainability.
|
| | | |
|
| | |
| |
| |
| | |
`run_check_integrity`
|
| | |
| |
| |
| |
| |
| | |
- Fix bug where expired keys from one keystore were incorrectly
associated with all keystores
- Remove unnecessary clone
|
| | |
| |
| |
| | |
`run_check_integrity`
|
| | |
| |
| |
| |
| |
| | |
- Add `display_invalid_keystore_entries` helper function
`print_check_integrity_incipit`
- Add `display_invalid_keystore_entries` comment
|
| | |
| |
| |
| |
| |
| | |
Add initial functional implementation of `display_invalid_keystore_entries`,
which processes a list of invalid keystore entries grouped by `KeystoreId`
and displays them with associated error messages.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Create the skeletal version of the new `display_invalid_keystore_entries` function
and adapt `run_check_integrity` to use it.
The function now takes a slice of pairs, each containing a `KeystoreId` and a vector
of invalid keystore entries along with their error messages, and processes all
entries internally by iterating over each keystore, instead of being called
once per keystore.
|
| |/
|
|
|
|
|
|
|
| |
Previously, the function worked with a flat `Vec<KeystoreEntryResult<KeystoreEntry>>`.
Now, it uses a structured `Vec<(KeystoreId, Vec<KeystoreEntryResult<KeystoreEntry>>)>`,
grouping entries by keystore.
This makes it easier to track which keystore each entry belongs to,
and prepares the code for upcoming improvements.
|
| |
|
|
| |
This feature has been removed from nightly, in favor of doc_cfg.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
It's unlikely these arguments will be particularly useful, and omitting
skip_all can have security implications, so it's better to avoid it to
reflect good practice.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
We may want to add a way to opt out of this check, if someone asks for
it. Checking for "localhost" and "127.0.0.1" is not a very robust check
for a loopback interface, and it's possible that there could be other
situations we can't detect where HTTP is safe (private network,
WireGuard tunnel, etc). But I don't expect those to be likely to come up
in practice, so this should be fine for now.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
I've added these in places that are useful for the debugging that I've
been doing.
|
| | |
|
| |
|
|
|
|
|
| |
This commit implements proposal 330 in the context of `tor-dircommon`,
by replacing the single `Authority` structure used in a list context by
a single structure called `AuthorityContacts` which contains all
v3idents, upload, download, and vote endpoints in one central place.
|
| |\
| |
| |
| |
| | |
arti: test: Add integration test suite for `hss ctor-migrate`
See merge request tpo/core/arti!3216
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| |
|
|
| |
See #1977, #2122.
|
| |\
| |
| |
| |
| |
| |
| | |
tor-error,arti: Support tracing fields in the `_report!` macros
Closes #2096 and #2116
See merge request tpo/core/arti!3142
|
| | | |
|
| | | |
|
| |\ \
| |/
|/|
| |
| | |
Note that not all memory is tracked by memqouta
See merge request tpo/core/arti!3165
|
| | |
| |
| |
| | |
Partially addresses #2102.
|
| | |
| |
| |
| |
| | |
This mainly separates the two options,
and adds the word "tracked".
|
| |\ \
| |/
|/|
| |
| | |
Fix clippy errors on nightly
See merge request tpo/core/arti!3148
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
```text
error: implicitly cloning a `String` by calling `to_string` on its dereferenced type
--> crates/tor-config/src/lib.rs:109:32
|
109 | V::String(_, s) => s.to_string(),
| ^^^^^^^^^^^^^ help: consider using: `s.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
note: the lint level is defined here
--> crates/tor-config/src/lib.rs:20:9
|
20 | #![deny(clippy::implicit_clone)]
| ^^^^^^^^^^^^^^^^^^^^^^
```
|
| | | |
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| |
| |
| | |
Update code for Edition 2024 (second attempt)
Closes #2101
See merge request tpo/core/arti!3137
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The two main causes of errors were:
- Since some of the lifetime rules have changed, we no longer need
to do as many "bind a variable and immediately return it"
patterns, and so clippy now warns about them.
- We needed to adjust the explicit captures (`use<...>`)
in a couple of our RPIT instances.
|