summaryrefslogtreecommitdiff
path: root/crates/arti/src
Commit message (Collapse)AuthorAgeFilesLines
* Run maint/add_warning crates/*/src/{lib,main}.rsIan Jackson2022-06-232-0/+6
| | | | Update all lint blocks
* Updated the warning message providing additional information about the type ↵0x4ndy2022-06-211-2/+1
| | | | of the proxy port.
* Merge branch 'reachable_addrs_v2' into 'main'Nick Mathewson2022-06-171-0/+10
|\ | | | | | | | | | | | | Implement support for reachable_addrs Closes #491 and #93 See merge request tpo/core/arti!583
| * Add a configuration option for reachable_addrsNick Mathewson2022-06-171-0/+10
| | | | | | | | (This doesn't do anything yet.)
* | Merge branch 'config-fix2' into 'main'Nick Mathewson2022-06-161-14/+6
|\ \ | | | | | | | | | | | | Use impl_standard_builder more and remove manual Default/builder impls See merge request tpo/core/arti!594
| * | impl_standard_builder: Use for arti::logging::LogfileConfigIan Jackson2022-06-161-7/+2
| | |
| * | arti: logging config: Replace a manual Debug implIan Jackson2022-06-161-7/+4
| | |
* | | Merge branch 'config-fix' into 'main'Ian Jackson2022-06-162-46/+89
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Config handling and logging fixes Closes #480 See merge request tpo/core/arti!589
| * | | arti: cfg: Remove another needless borrowIan Jackson2022-06-161-1/+1
| | | |
| * | | arti cfg tests: Remove a redundant line that shadows an earlier bindingIan Jackson2022-06-161-1/+0
| | | | | | | | | | | | | | | | | | | | Prompted by review https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/589#note_2813596
| * | | Fix grammar erroreta2022-06-161-1/+1
| | | |
| * | | arti: Enable some pre-config loggingIan Jackson2022-06-161-2/+16
| | | |
| * | | arti: Introduce closure which will be used for pre-config loggingIan Jackson2022-06-161-31/+52
| | | | | | | | | | | | | | | | Right now this is an IEFI and therefore a no-op.
| * | | arti cfg tests: Test that example config works as-isIan Jackson2022-06-161-0/+2
| | | | | | | | | | | | | | | | It contains only sections, but we want to detect when that is a problem!
| * | | arti: cfg tests: Refactor to prepare for new testIan Jackson2022-06-161-16/+23
| |/ / | | | | | | | | | We're going to call this new closure another time.
* | | Merge branch 'main' into 'accel-features'Nick Mathewson2022-06-162-2/+6
|\ \ \ | | |/ | |/| | | | # Conflicts: # crates/arti-client/Cargo.toml
| * | Merge branch 'high-level-features' into 'main'Nick Mathewson2022-06-161-41/+60
| |\ \ | | |/ | |/| | | | | | | | | | | | | Add "full" and "experimental" features to arti, arti-client, and below. Closes #499 See merge request tpo/core/arti!584
| | * Remove "rustls" from "full", for license reasons.Nick Mathewson2022-06-151-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | Rustls uses ring, which uses code from BoringSSL, which derived from OpenSSL before OpenSSL changed their license. So ring is currently under 3BSD/SSLEay licenses, which aren't GPL-compatible, which may be a problem for some people. See #493.
| * | config: Do not strip_option for journald (and in future)Ian Jackson2022-06-101-1/+1
| | | | | | | | | | | | | | | As per point 1 in https://gitlab.torproject.org/tpo/core/arti/-/issues/488
* | | Add "accel-*" features to arti-client and arti.Nick Mathewson2022-06-131-0/+9
| |/ |/| | | | | | | | | | | | | | | | | These need to be optional: they improve performance by shifting to asm implementations, which may not be everybody's idea of good practice. These are not 'pure' features, since they select one implementation but disable another. Therefore they don't go in `full`. Closes #441.
* | Document "full", "experimental" in toplevel crate documentation.Nick Mathewson2022-06-131-41/+56
|/ | | | | Also, unify the features documentation format for those two crates, and document previously undocumented features there.
* try to differentiate transient from nontransient errortrinity-1686a2022-06-081-2/+0
|
* return nodata instead of servfail in some instancestrinity-1686a2022-06-081-3/+13
|
* Merge branch 'lint' into 'main'Ian Jackson2022-05-312-6/+10
|\ | | | | | | | | | | | | lints: Make lint blocks consistent and ensure they stay that way Closes #469 See merge request tpo/core/arti!557
| * lints: Make lint blocks consistentIan Jackson2022-05-312-4/+0
| | | | | | | | The remaining consequences of running add_warning
| * lints: Add let_unit_value allow to all cratesIan Jackson2022-05-312-0/+2
| | | | | | | | | | From running add_warning, with manual picking of the right hunks/lines.
| * lints: arti: Move some allows outside the auto blockIan Jackson2022-05-311-2/+4
| | | | | | | | These need to survive.
| * lints: Add lint block delimiters to every crateIan Jackson2022-05-312-0/+4
| | | | | | | | | | | | This was the result of: maint/add_warning crates/*/src/{lib,main}.rs and then manually curating the results.
* | arti config: Check that example config is exhaustiveIan Jackson2022-05-301-0/+114
| | | | | | | | This is the final piece of #457.
* | mistrust: Canonicalise prefix from Some("") to NoneIan Jackson2022-05-301-0/+1
| | | | | | | | | | This allows us to add the proper default example to the arti example config file.
* | arti: config: Canonicalise ports, and provide example dns_portIan Jackson2022-05-302-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | Now the validated configuration will never be `Some(0)`, even if that is what was written in the config file. The arti CLI parser can still produce this, so we don't touch the code that actually uses this. (Without the canonicalisation the default builder produces `None` for the `dns_port`, but the example would produce `Some(0)`, which is semantically identical but fails the test.) See https://gitlab.torproject.org/tpo/core/arti/-/issues/488 for some background.
* | config: Provide tor_config::resolve_option and resolve journaldIan Jackson2022-05-302-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Canonicalise the `logging.journald` setting in the validated configuration. Now it will never be `Some("")`, even if that is what was written in the config file. This allows us to write `journald = ""` in the example configuration. (Without the canonicalisation the default builder produces `None` and the example would produce `Some("")`, which are semantically identical but fail the test.) See https://gitlab.torproject.org/tpo/core/arti/-/issues/488 for some background.
* | arti: config example: Add entries for tor_network fieldsIan Jackson2022-05-301-0/+9
| | | | | | | | | | These weren't previously discussed. It's not practical or useful to show the actual default values here.
* | arti: config example: Add some missing defaultsIan Jackson2022-05-301-3/+17
| | | | | | | | Found by my forthcoming test.
* | arti: example config: Arrange to uncomment logfilesIan Jackson2022-05-301-2/+2
| | | | | | | | | | This makes the config default parser see just "[ ]", an empty list, which is indeed the default.
* | arti: Make ProxyConfig no longer DeserializeIan Jackson2022-05-301-4/+1
| | | | | | | | That this remained was an oversight.
* | arti: cfg: Actually uncomment *all* the things in the exampleIan Jackson2022-05-301-1/+1
|/
* Merge branch 'arti-cfg-tests' into 'main'Ian Jackson2022-05-301-0/+24
|\ | | | | | | | | add unit tests for ArtiConfig public functions See merge request tpo/core/arti!551
| * add unit tests for ArtiConfig public functionsmichael mccune2022-05-281-0/+24
| | | | | | | | | | this change adds some simple tests for the ArtiConfig public getter functions to help expand coverage in this crate.
* | deduplicate dns requests based on transaction idtrinity-1686a2022-05-301-49/+139
|/
* Merge branch 'config-split' into 'main'Ian Jackson2022-05-263-73/+44
|\ | | | | | | | | | | | | Break TorClientConfig out of ArtiConfig and warn on unknown config keys Closes #459 and #417 See merge request tpo/core/arti!529
| * arti: Better doc for ArtiCombinedConfigIan Jackson2022-05-251-1/+3
| |
| * tor-config: Rename resolve_return_unrecognized, ..._ignore_...Ian Jackson2022-05-251-1/+1
| | | | | | | | | | As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807077
| * tor-config: Rename "ignored" to "unrecognized" throughoutIan Jackson2022-05-251-3/+3
| | | | | | | | | | As per review comments https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807076
| * tor-config: Tests for ignored config key handlingIan Jackson2022-05-241-8/+4
| |
| * Split TorClientConfig out of ArtiConfig, and Resolvable traitIan Jackson2022-05-243-45/+21
| | | | | | | | | | | | | | | | | | | | | | | | This gets rid of `#[serde(flatten)]` which prevents serde_ignored (and other kinds of introspection) from working properly. The price is now that the toplevel has to deal with two configuration objects. The Resolvable trait is overkill right now, but is going to do More Things in a moment. In particular, we need the impl on tuples, so that the whole config can be processed in one go.
| * arti tests: Introduce bld_tor variableIan Jackson2022-05-241-22/+19
| | | | | | | | | | | | We are going to reorganise ArtiConfig to not contain a TorClientConfig. This test case's calls to bld.tor() will all need to change. Do this in advance to make that future commit more readable.
* | reply socks error on more codepathtrinity-1686a2022-05-251-48/+67
|/
* Apply fs-mistrust to logfile directories.Nick Mathewson2022-05-243-7/+26
|
* Make fs-mistrust configurable from the top level.Nick Mathewson2022-05-242-19/+31
| | | | | | This change requires a little refactoring of TorClientBuilder: now, instead of enabling or disabling mistrust, it enables or disables the decision to _override_ the mistrust in the config.